Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp758751pxb; Tue, 12 Apr 2022 12:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlzED18WDU2NKYaltNzNf8b8QJ/GYTKzp414+gAEzFk1mljKZmy/vufHGOvtUs3C+53Y8H X-Received: by 2002:a17:90b:3e85:b0:1c7:7eab:2649 with SMTP id rj5-20020a17090b3e8500b001c77eab2649mr6757354pjb.232.1649792469518; Tue, 12 Apr 2022 12:41:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649792469; cv=none; d=google.com; s=arc-20160816; b=PilSWGb2B9GFbbH2x51A2BaYkp68XgTEaMhSvXwNZRIVT+kHH52PXji0ZDFvbMwMUj C3ViuKyrG2wfoLeEZC+TLK22DZWpYh+flrZZfl/VZV8l73MsVgBNWB23+TfvZ34Ade54 NMhWcrXdtrLjcYkjxGAswCRYcEJGxNzo8qQOBzPg0Cb6+Sy8ZMCUEUG82gTDOax5Jtyf zPSIh35WI/YmrDMtwpkTSuV0XvouvoOr1MkQqd9o23MPxpkd2FjvYkyEzt5wKgaXy/QO S6Ee2LlRf+fJmewqws3jBw0876LJiosHF4Gu6LIKaT/HEdcEvyQRSie1EJBWujg8a/RR Nijw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3iJ0+IyNxZZvzlcEwSrBUQGDtb2vpNXdBn5X6y0AW7o=; b=FRK4gXX7QMj0aJgoICxkkyDJ31el5+zZSv9wXWRv3hZFmW1K/wz/Guo5o3EGjE2yrF aEiyH+4i+JojyBQrzPC9avnJY/VJvJQ/sDKNPbEGy/8CoDs/FGtNWXI4LHC8Drfx6ua+ d9j3DcYabYYKi7ZYQVpqF/KgihkRNykjNYrOJF9VipxrAalNJeqDO+Ra6MUZMAcAQ1SW Dhs34/qzNwSMBR/lprJHDYtoDk4e2PtNmt944b2KCAaSP9XqZuzcCZyiUg/M3u4g+RRn Gg1sG/3uN7A0GDC1xPTE0/2xxMBzmeCYMOMZKPtzAB7YfSSjQwExIcEwbCMYxcaumdeB ONOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OqL8dcoB; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d11-20020a056a00198b00b004fa7bbf2aefsi6924218pfl.304.2022.04.12.12.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:41:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OqL8dcoB; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CAEAEF77; Tue, 12 Apr 2022 12:39:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238450AbiDLL0b (ORCPT + 99 others); Tue, 12 Apr 2022 07:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352781AbiDLLZl (ORCPT ); Tue, 12 Apr 2022 07:25:41 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52743275F5; Tue, 12 Apr 2022 03:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649758109; x=1681294109; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pC4oMCwiVQJHi/ouQqRKkAncvNZ0T2XkSEgopnaDXwk=; b=OqL8dcoBrZnmxoe5yZIC/ltuXWtxg83ePG33r/EHXJxf8tP6EnxDekhy CEqIOoaZyepPuarkxBzJcTHbNDYOCLDGOFqxe58dwJF/g2nBZKT5LZnsx FzhKNTLDg1UqSHVky6EuqTEQoYEeEPbdf01chRgjxWuUR+IT4c9yPIwAM cttTzqqZHru79BvdVzltwxGM9a6KGMURo8kAEMemmfJSgfWbzlGLMi4HO rSKujCi3+Zaxe/hzRdNc8vYFfdv/jwRQ4onoUGMniAlYH5gPUaaFIIsX5 M5ZQauDlSbZesS/Tf7FbZ1ADhzsWAVTYv9nTgp1h7ujgAvkiFvTDzX5kk g==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="262517009" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="262517009" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 03:08:09 -0700 X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="802174815" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 03:08:06 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 12 Apr 2022 13:08:04 +0300 Date: Tue, 12 Apr 2022 13:08:04 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linux PCI , Linux PM , LKML , Bjorn Helgaas Subject: Re: [PATCH v2 0/9] PCI/PM: Improvements related to device transitions into D0 Message-ID: References: <4419002.LvFx2qVVIh@kreacher> <11975904.O9o76ZdvQC@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11975904.O9o76ZdvQC@kreacher> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Mon, Apr 11, 2022 at 04:17:41PM +0200, Rafael J. Wysocki wrote: > Hi All, > > On Saturday, April 9, 2022 3:03:14 PM CEST Rafael J. Wysocki wrote: > > Hi All, > > > > This series supersedes the one at > > > > https://lore.kernel.org/linux-pm/4198163.ejJDZkT8p0@kreacher > > > > It addresses some potential issues related to PCI device transitions from > > low-power states into D0 and makes the related code more straightforward > > and so easier to follow. > > > > Please refer to the patch changelogs for details. > > Here's a v2 of this patch series which is being sent, because I realized that > one of the checks in pci_power_up() added by patch [4/7] in v1 was redundant > and can be dropped, but that affected the last 3 patches in the series and > then I noticed that more improvements were possible and hence the new patches > [2/9]. I sent a few minor nits separately. The series looks good to me in general and certainly improves readability :) Reviewed-by: Mika Westerberg