Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp761008pxb; Tue, 12 Apr 2022 12:45:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPHKa7JP6Fc/Zq14/B1GaYh1ZuHuiuhNmxA7vhJL5YVukoxeHgI15sJ5uH/JUTxHKy7B27 X-Received: by 2002:a05:6a00:b89:b0:505:dead:db1d with SMTP id g9-20020a056a000b8900b00505deaddb1dmr6885667pfj.74.1649792717740; Tue, 12 Apr 2022 12:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649792717; cv=none; d=google.com; s=arc-20160816; b=kiHnFp5effCiiBwk5LT1z15sdPVeDnQ85uUHccfOqYB4RYD4DEo25S/kdqjwtndmyp csdI2LClJnODeD0TVU8o1Q+4sNtyq2CNCqevGfcs9S0ufcYHJqDOBFBUxBlT4XGVsjMg fuI9mwiz3KlmYdJlxapcxr9zrCwkwikM3ntalMeV1arIdTVWfayfxYWq+XHESzadw+LX YM7x4X/PHwV74k062zwdjH/yWmCYbyMOusJ2Houvx4RAWx2U5PHtykw4jZBaJ3/dKXNE 3dD6nEs52dxxCADLXDIQM6KHh+6zj+yZr5Uda99QNGyRNu3vuVyKVH/y/nUYewys/Tl8 WDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=svCJiNYCVSTSADFJuSISCpOI75wKzQz4JEvN3pdJrsM=; b=sf2rPXffAvRV0BwuQQ8K2rWSvpTtEs7mGJ54WiMSt2Go5YbueIe8mOD2A+UBGDgviy WzgoPnkz/rU8QYaZvXKHowPFZ3K5QlIUynqWoYwapnK5DLLEc/Sbyhcw0sBUuJYh7miy XuR7LYySr4j8fP0Jy0SjCHOzh64djBXqGFjrt/a3bNfDgqU92KWvKhIuh0ff7LFZD+Iv vzKaRcMNRVPegpvQ4oTJaHFD0XhhHXNgTOfZzuFqvpffT9zO7VNufPBi8KwjxL0Y6hRJ qFwBJ2g7X+xQfx9a8NNPjS1n+FFPGMvf/sejtfYs1NDrVC5dkBc5I9VagYHihmNqTV8f Fc3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I0pM3O+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n20-20020a6563d4000000b0039d1c1fdd0esi3560849pgv.10.2022.04.12.12.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I0pM3O+H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 65AAC62A2B; Tue, 12 Apr 2022 12:43:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353676AbiDLRGu (ORCPT + 99 others); Tue, 12 Apr 2022 13:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357962AbiDLRGd (ORCPT ); Tue, 12 Apr 2022 13:06:33 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48BB813E8E for ; Tue, 12 Apr 2022 10:04:14 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id q3so6097221plg.3 for ; Tue, 12 Apr 2022 10:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=svCJiNYCVSTSADFJuSISCpOI75wKzQz4JEvN3pdJrsM=; b=I0pM3O+HVyaN+WR40sxZKPBujfPiS3TYbtroP2cR9D3EyonmrVjWLo+lFmCjjMF/C9 cKC95ZxJ5Wrj7D8YYDHGFUDvGV5CqSfJIeyJZp4xia9AH0fNss/9hGUjx3Dc5k/kk+NI SK55KI1P+NrSthu6nAnBYzB/AAGQORsGEG9JNxBoBlmcVXq8WOOypF/3nfo1RTjKbfAK 3wkiCRIRYK/PBpuqmNWFGd3fnVzQpOgfZYmS3EiJjdqvm+ZOuX4X+FXha0FXLcH2RAYv wEPfq51y/pCgvHdYlIvMzU1RG15mFEFWbDIbpcC1v792nKvKq9up0JlbsebYKLsxNu3N N77w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=svCJiNYCVSTSADFJuSISCpOI75wKzQz4JEvN3pdJrsM=; b=xbKPpwRiH9TAI4ueDod1xqu+lTqa/kV+2wzK9ByNET6hxEi2aZDij1qZABEdrC/gyv Q80eZMgp+yvDIJePYvCdMDOToh3Vi3EeXx2gqTmbGJQc2O2FZUKaBUKgOTjcK9biZiXW 9MRw3duMB2Jyso1o3B16RVSIQawjw5mAIJWDpp/E4qm0ax0lPRM1nBzurXBmDhYEUeqL 0wYgPriVp4pnf22M9CtXZ00L8cIo2IMThkKzAl+bAB9SA9L3oDfzdIJWT8d1q0RoNnJ3 SMP/VWzVnTDdcgHKNTvtXouX2pL01icXJp6xuvTfwh++m5i9Ziwn59er2GkugUwoGsNe efng== X-Gm-Message-State: AOAM530tw5Bk4zDiIeawj4iOdsiN79iiag9q5xl5hQK6+80Gju0RrPFQ 3zQTKF59E7E5FlqB6LBchLjUEavbwihrlw== X-Received: by 2002:a17:90b:19d0:b0:1cb:7ef1:d915 with SMTP id nm16-20020a17090b19d000b001cb7ef1d915mr6130873pjb.16.1649783053717; Tue, 12 Apr 2022 10:04:13 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id k92-20020a17090a4ce500b001ca69b5c034sm49060pjh.46.2022.04.12.10.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 10:04:12 -0700 (PDT) Date: Tue, 12 Apr 2022 11:04:10 -0600 From: Mathieu Poirier To: AngeloGioacchino Del Regno Cc: Christophe JAILLET , Bjorn Andersson , Matthias Brugger , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] remoteproc: mtk_scp: Fix a potential double free Message-ID: <20220412170410.GA465495@p14s> References: <1d15023b4afb94591435c48482fe1276411b9a07.1648981531.git.christophe.jaillet@wanadoo.fr> <34c30f7c-70e2-dc95-a664-9379f91f5aed@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34c30f7c-70e2-dc95-a664-9379f91f5aed@collabora.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2022 at 10:55:52AM +0200, AngeloGioacchino Del Regno wrote: > Il 09/04/22 08:27, Christophe JAILLET ha scritto: > > 'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need > > to free it explicitly in the remove function. > > > > Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()") > > Signed-off-by: Christophe JAILLET > > Reviewed-by: AngeloGioacchino Del Regno Applied. Thanks, Mathieu > >