Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp764724pxb; Tue, 12 Apr 2022 12:51:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzteFsnH0HrbgEUTn2TSvMVOG4mpJNLvWLgwtrtRdvkdeV3WxNZ1ftYTRT1NvLA3E5pcOs7 X-Received: by 2002:a17:90b:2385:b0:1cb:7b13:934b with SMTP id mr5-20020a17090b238500b001cb7b13934bmr6719431pjb.121.1649793089038; Tue, 12 Apr 2022 12:51:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649793089; cv=none; d=google.com; s=arc-20160816; b=OfBfYliRoQmTQMMv/zQvUeX1gWnGSafIdpcDSIhsWEr4swNbC4ikIkgpu4EavIp58X CUlh9FjH8+t/0HEcLWB3p2fhmg69rEHYysabGFS7nSUAxKzGwCLOw8bs2WHSe9VVUwxb k6tkzM4ueZjsRywxIj+tUdJlTx4jwBgiOvqLVq3bcgbd68eFSUyvdzkDrkAWq/kbznSQ 55MFuHS6WvvH+RKRXvGegwe35yy37w9O3vm8zrvN/yZK+Zd7nm39jikF9c19YY14sWas rBMPoHtjIM+mtsPUhK3va6uVVGeevNoqxgKGTR//Nst/+wHrXtNmjqVl9qHCT1veENZQ VgLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=4fzpyZsSZ8MB/OESakwuykL/h7QjXDh8jwM2tR5aekQ=; b=bQVcwbeeGVollQgmmxDAjSuEIk5PW3Bf1SWpNypizEDCxXtnH3jwRVpw6+FH6fX1Mk CFK3GbusoKlu7RgnhImIXPPf5nr7q82L6Xqrw8zeb/PI2SDd4RPf6zGqdBbCjb2aw3m1 U+/NhrsbM5EDRoghrjepgb/6lzYLNlkcgZAQ7c6BVKra76Bim9EPxfu7aGygjECLwp+G smXR/pkmDVntK5KZ4JG7jIOHHqlHksHkzinCIm8gDYqMTxn2OZe07WqPUUKeEBBYFLgD 17bA+Zu47cd5q5XdVR1JlfyMXe5Q0uR3hoc0zHBXg9fy1ZLXJxiQPQRfS1qyMYwlXat4 r9Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=L8aAup+x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n13-20020a170902f60d00b001582ce97029si12037916plg.122.2022.04.12.12.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:51:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=L8aAup+x; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D88C06D385; Tue, 12 Apr 2022 12:47:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379948AbiDLIVG (ORCPT + 99 others); Tue, 12 Apr 2022 04:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351752AbiDLHdL (ORCPT ); Tue, 12 Apr 2022 03:33:11 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3EB15006C; Tue, 12 Apr 2022 00:08:39 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id bo5so16713771pfb.4; Tue, 12 Apr 2022 00:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=4fzpyZsSZ8MB/OESakwuykL/h7QjXDh8jwM2tR5aekQ=; b=L8aAup+xdNnWuw249ZD6hgE4GGJ9esOXKuRAdS5MHIf46QB1cv/i9GFgnMEI44oshf 78kk0faDuNwDF1mKY2mjrpWztlmGM8Qy+MCDc3T4yREVXIgn365mz5+WNOlaF1HsS7Ls ItDLUIa061z/9azpxGGajCR3HGDsUw03dWM6Phpion1hAh5JW09QQD6BiyUEK8ZTaRrL CXfH7uZ/gFwPHGzBXjp1KpAWASso1plw6K6TKMMLs1e4OGgbjeljWg71dmfbWlXd7xxH bRPQv4xVouA8gVgrjr/mQfcNXjwfelD9vmDPEFICJvL78el5uqWL9zQnJWcTRydmHpAK lv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4fzpyZsSZ8MB/OESakwuykL/h7QjXDh8jwM2tR5aekQ=; b=c9HwYGWA/ilhMdIDkeqCcP6KNquDt8FiIk0HHDVzqnJ40497+xAtlyCFG9IkoSXFNY zAYvHQ0nYIRDi8DJXoedKshHTopPdtodO/Zw+32cHudPI/jWPU4kRwCuqHHQEvl3LS85 8d3MAldr8AwSVCO+O5l58ijZsIo3/ph1vQnXXK6fzalmJskLdbIbvlQf+yRw3LZwv3B8 KhvTPkSqwsMhfJLSMRn/CMAPuc2QbtQN5Cd5LYgUXYO9Ks8hWxN0zgMAEANrBkNv3cDl 8g2ClfPoMJmlX9tUMGsdUCPkbqQ5/XKTcWSOFjHNgGyWFFAuM+o9QkZnG6sG0y5foRWu R46A== X-Gm-Message-State: AOAM5314BWiWe7RRt/euCILim2STfZlID0dZYsT2mympCQ0hAR3S/tLR ME9HpRfIf8SCa5v/RZnVRJM= X-Received: by 2002:a05:6a00:1903:b0:4fa:fa9e:42e6 with SMTP id y3-20020a056a00190300b004fafa9e42e6mr36721734pfi.1.1649747318954; Tue, 12 Apr 2022 00:08:38 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id h19-20020a632113000000b0039d9c5be7c8sm763916pgh.21.2022.04.12.00.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 00:08:38 -0700 (PDT) From: Miaoqian Lin To: Wim Van Sebroeck , Guenter Roeck , Tero Kristo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking Date: Tue, 12 Apr 2022 07:08:23 +0000 Message-Id: <20220412070824.23708-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1, so a test for negative value should be used to check for errors. Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support") Signed-off-by: Miaoqian Lin --- drivers/watchdog/rti_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c index db843f825860..00ebeffc674f 100644 --- a/drivers/watchdog/rti_wdt.c +++ b/drivers/watchdog/rti_wdt.c @@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = pm_runtime_get_sync(dev); - if (ret) { + if (ret < 0) { pm_runtime_put_noidle(dev); pm_runtime_disable(&pdev->dev); return dev_err_probe(dev, ret, "runtime pm failed\n"); -- 2.17.1