Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp768837pxb; Tue, 12 Apr 2022 12:59:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTEca9XrhNlOSNOeG5CG3fX/luoboOXLLx32BSFf2r++4eZIfMIzMQA0Rl9G/FXCxbkfxD X-Received: by 2002:a63:eb13:0:b0:382:1cd5:7d06 with SMTP id t19-20020a63eb13000000b003821cd57d06mr32142269pgh.280.1649793567296; Tue, 12 Apr 2022 12:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649793567; cv=none; d=google.com; s=arc-20160816; b=fHgBvYcWzdzAf7hEyWbnz+qWZP/G/XLohA++zeazUhaAC9P+8Cau+/gjx8IrbE9kB2 VaEeIhjs1qe4oTCXiwR1VYdLpvoxqBtyJvEaW8RnPUh9AdMNuzA+MysqqkIIoc6UQ4n7 4g0u+N/xfUYjREc6O0RhXD2qNwbOxBeDn3HUE9KLaB7dv6rRyC/u2BXincViQ1F9v2db r+VNSzycLmc2Ju6FtUbFhcneoFYgWhyt54lpwn430eo2O2AxOh6AZjTS1f/XKK0O9jU3 /KvKwzHQplEVpuRr3hI/HPiwlMGZ0XZD45SFohdvZNPASZgbsPs0r6y33zxaNDj6YFix jGtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Ffc5sqRLtFsVMh/uA99sFf0ZJA1w+M6NwEFaMPOC4oo=; b=EInp7MwQmtgz2hwJ2IrNHGT2PVDN9F8/PiqTR9PwrlhxGHyniAVQyodbh8t8THIZPL 6P5uliGWbfMZzbvJzUQsx5i/HbiSSAdAMib4bMo27ZNsjbfIDCWizuxaHZTzZiyFeRz9 mTfQFRSWvdrCv5VTD2BNYYwC1veYwV8iCNMYXTLUh5Oxpnk44MoSKB60RMr3pL03mgm+ zYMqudD80uvopj+NMR3Eo0LHzS4T9FfjVkl8Rle4Oo8d9uFvfVnTS+yDmnlu5DwGHkRL 6hVuOM7ihiapjqOjX3hWSqD7WKq6VkvdVKGb7pAOmrrPmDHo/P8pN5VB+VOddQ8BPm+T zigw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f6-20020a63dc46000000b0039daee3c8b0si177759pgj.631.2022.04.12.12.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:59:27 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C291276590; Tue, 12 Apr 2022 12:52:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241062AbiDLMbK (ORCPT + 99 others); Tue, 12 Apr 2022 08:31:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345421AbiDLM1W (ORCPT ); Tue, 12 Apr 2022 08:27:22 -0400 X-Greylist: delayed 561 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 12 Apr 2022 04:34:08 PDT Received: from sym2.noone.org (sym.noone.org [178.63.92.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A52A931200; Tue, 12 Apr 2022 04:34:08 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4Kd3KT2lSTzvjfn; Tue, 12 Apr 2022 13:24:45 +0200 (CEST) Date: Tue, 12 Apr 2022 13:24:45 +0200 From: Tobias Klauser To: Jiri Slaby Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tty: serial: altera: use altera_jtaguart_stop_tx() Message-ID: <20220412112444.ovep2442cybue5nu@distanz.ch> References: <20220411104506.8990-1-jslaby@suse.cz> <20220411104506.8990-4-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411104506.8990-4-jslaby@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-11 at 12:45:06 +0200, Jiri Slaby wrote: > altera_jtaguart_tx_chars() duplicates what altera_jtaguart_stop_tx() > already does. So instead of the duplication, call the helper instead. > > Not only it makes the code cleaner, but it also says what the "if" > really does. > > Cc: Tobias Klauser > Signed-off-by: Jiri Slaby Acked-by: Tobias Klauser Thanks