Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 12 Apr 2022 11:11:17 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 2/2] clk: imx8m: check mcore_booted before register clk
Message-ID: <YlU0JRrInWbCiylZ@abelvesa>
References: <20220228124112.3974242-1-peng.fan@oss.nxp.com>
 <20220228124112.3974242-2-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220228124112.3974242-2-peng.fan@oss.nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VPC1Tbswn3oLE/s48Wpvlfsm+q/71lkfOtj40AtWhvBiNNW5rcT7IZY84KQj?=
 =?us-ascii?Q?fcHaQ6l319QTPzShj1Cwq7ttXVh6/rIVYf0d+4gzCq0HJM6B3IZrl0mVRaRq?=
 =?us-ascii?Q?RkH0XYwCjH5eujM2lKFXT/WoTGWzDlKtBjS6Yew9a8PnNlEEXJ2tDd0Hi2zV?=
 =?us-ascii?Q?8lnv8742y53/q5T/2w6lqfL9Lerd/fFX8nFuEj1VfH8bkv0JPyftoOt4Atyp?=
 =?us-ascii?Q?8l5udWdZVmWDNXe9lGqPnrj8y8JZ0HDCiITyZ8jdadrh0dycchgnOnjaEe4h?=
 =?us-ascii?Q?DN20KTbYAQzMClRVMIGDdldBg/NeKsGiBPAfbC0WH9RitnHRmfnsV1MY/HW6?=
 =?us-ascii?Q?ZnerEJm6aRjt6TJS4xED6eKhZsNnIaczzuFxwg1ze0SA7hcRWu6R/7XDxNy8?=
 =?us-ascii?Q?q350WM+W84zQxvGNir2XPpNw//rb7ab61PxnR03Y4Gy3+ZIlhEc+DzUFdOU5?=
 =?us-ascii?Q?EItAP+jEr5C2AlHMRhgkyvwGfiAlYRBiyjryzoZo9bv6YzjsjseW29a89Kd8?=
 =?us-ascii?Q?YLWhoTQGKhOzdi2h7Lda9ak1vjhNcsjmIg1tUQXXwPALiCX9HeksN7LY/XUD?=
 =?us-ascii?Q?NwN1sjaBURt9YAP6G+WespCXME9SMILCA6UZD/bypGJ73Wq0boJ98ENH9Y9V?=
 =?us-ascii?Q?sTIU2yRcLgOzTQJOoxpt95qRxuaVj6fAZ06Nwi7ZSuTNeD4n5PUZCCiGk+ta?=
 =?us-ascii?Q?7IBpiUu2C24SNNNzjujnTYIP/RgmmSNteGffjWJ+9BvAdckn3eoYfMkKRDcz?=
 =?us-ascii?Q?X/yl+MtCgR1fEGu+578OMajwHeX1D1y8H82tQeHk9mjJxm684pOWevSZT7xh?=
 =?us-ascii?Q?mm74GUNHaAAouqOtonVTfEX/WEF6hztOk0c2nSqzdmSC1KKgBibzD1b9mkf5?=
 =?us-ascii?Q?D4l/2ewtetshwOpbWia95XgINZ/T89haKaenhNpr9lI2kC8MCQQJj05NO39g?=
 =?us-ascii?Q?TI5JdNMQ7rKxHr8mos7HUlVGJtJfI5DBm/efKQ/13SFfYHoExlK+/2gRyK8J?=
 =?us-ascii?Q?9GFwizYXITxsBptzB7sSFdcqqD7tT1gFKBCQ+Hi4SsJmz5ivrTfJKqr69TH4?=
 =?us-ascii?Q?EttgVQwnQctzhjP5VZaRua5wgGHDjVSkymjz12/9cfHmgtyMPGbrtQvfCDbL?=
 =?us-ascii?Q?CX4XmGblDjnEBLDDjFvQgceBqOhI9+/QhP4PEtJ12TUyrFFJd3zBF3vWkUnc?=
 =?us-ascii?Q?/Iuo7RTUZQPZ3nGUjdzW6OdxJ3ATVLkFKRA7H+Eock2Kvt2SrTSHkOZIIqsR?=
 =?us-ascii?Q?274/guou+1uPe8dKX27pkj40nctU3nmaJcUaMUefvd7Nu0NtkX8NThp5XiIF?=
 =?us-ascii?Q?KcMs94F67/q/A/kbs7ydB7J8OW9tfSngjqYgFyuXgGT99J9B7xlw4dN0fqZL?=
 =?us-ascii?Q?OgdagRu8T+2HPm1LKOKTgUVwiW0JZXuvqviXNcivAQAjftzFc89DxtwQ4P/1?=
 =?us-ascii?Q?afCdR4m07aTFETfcQ/a+TW9FEBc/vAzlE+cTingb7y2S/bz8iHWwVQKDAzro?=
 =?us-ascii?Q?hMOjsRvWoNArWY4PTI1r+0yl78+vs13yeuKkCvngxdOwMUVc8z/3N0GaOuLQ?=
 =?us-ascii?Q?58py4jPFJfpcyIqq4GYpCQDHpkkOl9PpCrVB2+BtE9pcPpUJePN9zNEm6Egg?=
 =?us-ascii?Q?LZWNFmyol3pFtH4IZlEk0ZvMqrRzZruGtF8RkeXaI8T6dRuKgsZqrVF75bsg?=
 =?us-ascii?Q?gjznfd7G77BJM2g12FTTErxOwfFdjLd3fl+oYNvRapAv5Yob5Kz4HFSjig8m?=
 =?us-ascii?Q?2zikiirxnw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e10221b8-313b-4400-1aa4-08da1c5c0660
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 08:11:19.7126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sFtHjOLu3nIsMjW1UgnOzkgXgSlE6kSpwwg1roSEkaDu3QsfD27VlxbxGUoKDFzA53x7/a/4FdJOTFDJpKFCrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3209
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-02-28 20:41:12, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> If mcore_booted is true, ignore the clk root gate registration and
> this will simplify AMP clock management and avoid system hang unexpectly
> especially Linux shutdown clk used by mcore.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V2:
>  None
>
>  drivers/clk/imx/clk-composite-8m.c | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
> index 2dfd6149e528..b16c2c0ea9f6 100644
> --- a/drivers/clk/imx/clk-composite-8m.c
> +++ b/drivers/clk/imx/clk-composite-8m.c
> @@ -223,14 +223,19 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name,
>  	div->lock = &imx_ccm_lock;
>  	div->flags = CLK_DIVIDER_ROUND_CLOSEST;
>
> -	gate = kzalloc(sizeof(*gate), GFP_KERNEL);
> -	if (!gate)
> -		goto fail;
> -
> -	gate_hw = &gate->hw;
> -	gate->reg = reg;
> -	gate->bit_idx = PCG_CGC_SHIFT;
> -	gate->lock = &imx_ccm_lock;
> +	/* skip registering the gate ops if M4 is enabled */
> +	if (mcore_booted) {
> +		gate_hw = NULL;

Lets have the gate_hw set to NULL when declared and get rid of this if
case.

> +	} else {

And then lets do here:

	if (!mcore_booted) {
> +		gate = kzalloc(sizeof(*gate), GFP_KERNEL);
> +		if (!gate)
> +			goto fail;
> +
> +		gate_hw = &gate->hw;
> +		gate->reg = reg;
> +		gate->bit_idx = PCG_CGC_SHIFT;
> +		gate->lock = &imx_ccm_lock;
> +	}
>

Would look a bit cleaner this way.

With that done:

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

>  	hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
>  			mux_hw, mux_ops, div_hw,
> --
> 2.25.1
>