Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <a7d28775-2dbe-7d97-7053-e182bd5be51c@redhat.com>
Date:   Mon, 11 Apr 2022 19:40:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 092/104] KVM: TDX: Handle TDX PV HLT hypercall
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
Cc:     Isaku Yamahata <isaku.yamahata@gmail.com>,
        isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <6da55adb2ddb6f287ebd46aad02cfaaac2088415.1646422845.git.isaku.yamahata@intel.com>
 <282d4cd1-d1f7-663c-a965-af587f77ee5a@redhat.com>
 <Yk79A4EdiZoVQMsV@google.com>
 <8e0280ab-c7aa-5d01-a36f-93d0d0d79e25@redhat.com>
 <20220408045842.GI2864606@ls.amr.corp.intel.com>
 <27a59f1a-ea74-2d75-0739-5521e7638c68@redhat.com>
 <YlBL+0mDzuTMYGV9@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <YlBL+0mDzuTMYGV9@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/8/22 16:51, Sean Christopherson wrote:
>> It also documents how it has to be used.  So this looks more or less okay,
>> just rename "vmxip" to "interrupt_pending_delivery".
> 
> If we're keeping the call back into SEAM, then this belongs in the path of
> apic_has_interrupt_for_ppr(), not in the HLT-exit path.  To avoid multiple SEAMCALLS
> in a single exit, VCPU_EXREG_RVI can be added.

But apic_has_interrupt_for_ppr takes a PPR argument and that is not 
available.

So I suppose you mean kvm_apic_has_interrupt?  You would change that to 
a callback, like

         if (!kvm_apic_present(vcpu))
                 return -1;

	return static_call(kvm_x86_apic_has_interrupt)(vcpu);
}

and the default version would also be inlined in kvm_get_apic_interrupt, 
like

-       int vector = kvm_apic_has_interrupt(vcpu);
         struct kvm_lapic *apic = vcpu->arch.apic;
         u32 ppr;

-       if (vector == -1)
+       if (!kvm_apic_present(vcpu))
                 return -1;
+       __apic_update_ppr(apic, &ppr);
+	vector = apic_has_interrupt_for_ppr(apic, ppr);

Checking the SEAM state (which would likewise not be VCPU_EXREG_RVI, but 
more like VCPU_EXREG_INTR_PENDING) would be done in the tdx case of 
kvm_x86_apic_has_interrupt.

Paolo