Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp781326pxb; Tue, 12 Apr 2022 13:17:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytcbnog2PPI0GKDsr7lArQgmpkKyiKa4MdaeJT6p14VJTt7hxLLeEvjQRreNG219AaAIuN X-Received: by 2002:aa7:9255:0:b0:505:a44b:275c with SMTP id 21-20020aa79255000000b00505a44b275cmr16904360pfp.40.1649794658636; Tue, 12 Apr 2022 13:17:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649794658; cv=none; d=google.com; s=arc-20160816; b=EuFh7/C7QIKbndPpl/T87Wv5b50j3YTA/NimIwngVRfhWLrK5MbT9SLzZ4Ozf67wLg OIl/fnt2J+HjLnFz8BSeg9PIgWVmqtpm8P0trkBeZXAHJGNZjDx8uRGxCAS+IqIVxPVN SQdUDb51NGAf68U2Thj3FEb5n1X1+G8F1C4Tud1HTlYZIF451pzWakzdFyxSbS6nDQVJ 1Vt5J7PtwGeAfQQTCiFQD/Miq93+qAcbrHAZvo1urR6SgacCp+MgQGXJ+xetDMOzgkBe FJt/sLwh8usqAdk3MfIalIMppWNdDkxsyIHKsozS3q7Ye7Z1qQNSAUy7d+aiGVkNsC9Q BB8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=f8+kdZ1zr5QlSyeJ75DMqXcYkBRVmFmMygBPhp4eCzg=; b=GTU6s6xH+7/LOpeLFAMDVu/1+BZ5G5uGlKayIEDr9aYeaJIAObsWSTc2n4QjeXbBR3 GJUMZfL75qdiP/rfAF+/CrHRqf0iInYw8ZCes27LnBBCV6yTO/6DkKGjZPdSdpF/3hvG y6TLMR3c3pGJvTCHZY43h9WYwOsVOQ0yMRFxrJV926RFjbZs5UDTf7QayvlgQvdi7poe r07j/3q/U7VYDbQIDBamg11sb8BklmXsd2ytpFTFNECWiNNepSKrQdgApwjfUooosIQM YPJ8uqsvyyNWzq3k63WZLo/iy6xFbP45gUoyPhOTUHAm/OKf2DzM3MAPlLdzGUYhh3W+ qQHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=myyILqVt; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id t1-20020a639541000000b0039d9a13b8b1si2466729pgn.135.2022.04.12.13.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 13:17:38 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=myyILqVt; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 44FB98BE2B; Tue, 12 Apr 2022 13:01:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244567AbiDLGi2 (ORCPT + 99 others); Tue, 12 Apr 2022 02:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349222AbiDLGga (ORCPT ); Tue, 12 Apr 2022 02:36:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AEE36173; Mon, 11 Apr 2022 23:33:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0F62B81B41; Tue, 12 Apr 2022 06:33:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 595E9C385A6; Tue, 12 Apr 2022 06:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649745227; bh=Y57laqo09HMB6kgB7bj0/c0TOESGTg7lIYYGBdaRjlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=myyILqVt/rIvtwdVKJhKjl60xbIKNvYYnJY5TlHaNs4QWrhzE04S9s3ou/+c5Sadb q1wv7wePlap9ees0e1+eGAxI7wkcIjGTCC2J7oKxKTIaN/3mMwyngdiegwNJ/4zTbv JqYAPwV0O5kIGMdOSmWV+3tIEeaUI1QUtVIgsByc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Avraham Stern , Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH 5.10 023/171] cfg80211: dont add non transmitted BSS to 6GHz scanned channels Date: Tue, 12 Apr 2022 08:28:34 +0200 Message-Id: <20220412062928.555843881@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062927.870347203@linuxfoundation.org> References: <20220412062927.870347203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Avraham Stern [ Upstream commit 5666ee154f4696c011dfa8544aaf5591b6b87515 ] When adding 6GHz channels to scan request based on reported co-located APs, don't add channels that have only APs with "non-transmitted" BSSes if they only match the wildcard SSID since they will be found by probing the "transmitted" BSS. Signed-off-by: Avraham Stern Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20220202104617.f6ddf099f934.I231e55885d3644f292d00dfe0f42653269f2559e@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/scan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index fd614a5a00b4..c1b2655682a8 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -702,8 +702,12 @@ static bool cfg80211_find_ssid_match(struct cfg80211_colocated_ap *ap, for (i = 0; i < request->n_ssids; i++) { /* wildcard ssid in the scan request */ - if (!request->ssids[i].ssid_len) + if (!request->ssids[i].ssid_len) { + if (ap->multi_bss && !ap->transmitted_bssid) + continue; + return true; + } if (ap->ssid_len && ap->ssid_len == request->ssids[i].ssid_len) { @@ -830,6 +834,9 @@ static int cfg80211_scan_6ghz(struct cfg80211_registered_device *rdev) !cfg80211_find_ssid_match(ap, request)) continue; + if (!request->n_ssids && ap->multi_bss && !ap->transmitted_bssid) + continue; + cfg80211_scan_req_add_chan(request, chan, true); memcpy(scan_6ghz_params->bssid, ap->bssid, ETH_ALEN); scan_6ghz_params->short_ssid = ap->short_ssid; -- 2.35.1