Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH net-next v2 05/18] net: dsa: mv88e6xxx: remove redundant
 check in mv88e6xxx_port_vlan()
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <YlViPWWKhvoV2DLN@shell.armlinux.org.uk>
Date:   Tue, 12 Apr 2022 13:37:17 +0200
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        UNGLinuxDriver@microchip.com, Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Jiri Pirko <jiri@resnulli.us>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Casper Andersson <casper.casan@gmail.com>,
        Colin Ian King <colin.king@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Michael Walle <michael@walle.cc>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Eric Dumazet <edumazet@google.com>,
        Xu Wang <vulab@iscas.ac.cn>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, bpf@vger.kernel.org,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8BAFAAD1-D9AB-4339-BE81-18BE564F78F6@gmail.com>
References: <20220412105830.3495846-1-jakobkoschel@gmail.com>
 <20220412105830.3495846-6-jakobkoschel@gmail.com>
 <YlViPWWKhvoV2DLN@shell.armlinux.org.uk>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Precedence: bulk


> On 12. Apr 2022, at 13:27, Russell King (Oracle) =
<linux@armlinux.org.uk> wrote:
>=20
> On Tue, Apr 12, 2022 at 12:58:17PM +0200, Jakob Koschel wrote:
>> We know that "dev > dst->last_switch" in the "else" block.
>> In other words, that "dev - dst->last_switch" is > 0.
>>=20
>> dsa_port_bridge_num_get(dp) can be 0, but the check
>> "if (bridge_num + dst->last_switch !=3D dev) continue", rewritten as
>> "if (bridge_num !=3D dev - dst->last_switch) continue", aka
>> "if (bridge_num !=3D something which cannot be 0) continue",
>> makes it redundant to have the extra "if (!bridge_num) continue" =
logic,
>> since a bridge_num of zero would have been skipped anyway.
>>=20
>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> Isn't this Vladimir's patch?
>=20
> If so, it should be commited as Vladimir as the author, and Vladimir's
> sign-off should appear before yours. When sending out such patches,
> there should be a From: line for Vladimir as the first line in the =
body
> of the patch email.

yes, you are right. I wasn't sure on how to send those commits, but
I guess if I just set the commit author correctly it should be fine.

regarding the order: I thought I did it correctly doing bottom up but
I confused the order, wasn't on purpose. Sorry about that.

I'll resend after verifying all the authors and sign-offs are correct.

>=20
> The same goes for the next mv88e6xxx patch in this series - I think
> both of these are the patches Vladimir sent in his email:
>=20
> https://lore.kernel.org/r/20220408123101.p33jpynhqo67hebe@skbuf
>=20
> Thanks.
>=20
> --=20
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Thanks for pointing it out!
Jakob