Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c5d10dc4-a76f-fdab-0ca3-2850871f36b3@quicinc.com>
Date:   Tue, 12 Apr 2022 11:15:58 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v11] arm64: dts: qcom: sc7280: Add WPSS remoteproc node
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <robh+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_sibis@quicinc.com>,
        <kuabhs@chromium.org>, <quic_pillair@quicinc.com>
References: <20220406111101.27412-1-quic_mpubbise@quicinc.com>
 <CAE-0n51vq_V85SKh+hN1Ueas9t1dV7ZFaFyQsG9vukRBAHUc5A@mail.gmail.com>
 <5c87d5d9-66d0-41d9-4adb-53b3ec7cadeb@quicinc.com>
 <CAE-0n51PheX1poksttyYVEOVe2amWbWwZSQMwguTUxajSHm6bQ@mail.gmail.com>
From:   Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
In-Reply-To: <CAE-0n51PheX1poksttyYVEOVe2amWbWwZSQMwguTUxajSHm6bQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/7/2022 11:46 PM, Stephen Boyd wrote:
> Quoting Manikanta Pubbisetty (2022-04-06 23:11:50)
>>
>>
>> On 4/6/2022 8:47 PM, Stephen Boyd wrote:
>>> Quoting Manikanta Pubbisetty (2022-04-06 04:11:01)
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> index ecbf2b89d896..f61a3e15fa8b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>>>> @@ -547,3 +547,6 @@ sw_ctrl: sw-ctrl {
>>>>           };
>>>>    };
>>>>
>>>> +&remoteproc_wpss {
>>>> +       status = "okay";
>>>> +};
>>>
>>> This should be before the PINCTRL section in this file. I believe after
>>> the uart node.
>>
>> I have not understood your concern, any specific reason as why
>> remoteproc_wpss node has to be before PINCTRL section?
>> There is no problem in moving, just wanted to understand the reason.
>>
> 
> It's a style that this file is following. The end of the file is for
> pinctrl configurations. Before that section is where soc nodes are
> modified. There are different sections of the file with comments
> delineating them.
> 
> Furthermore, adding things to the end of the file is a recipe for
> conflicts when applying patches as a maintainer. This is another reason
> why we sort the nodes. I suspect having different sections helps here so
> that we don't sort everything alphabetically and have pinctrl settings
> scattered throughout the file.

Thanks for the explanation, I'll send out a revised patch.

Manikanta