Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp787581pxb; Tue, 12 Apr 2022 13:27:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwYNYexUgxwie+J44VubbXEu88XlpfzS3uXDnDaRZB5awjH+1lS/aWn8CX/eJPd2uko6xL X-Received: by 2002:a63:f452:0:b0:382:7af1:6ad6 with SMTP id p18-20020a63f452000000b003827af16ad6mr31795683pgk.500.1649795257412; Tue, 12 Apr 2022 13:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649795257; cv=none; d=google.com; s=arc-20160816; b=icC0UYLIVlBClqU21OnmYVzY59BzwidfQ+e1tjTE4LfSMh2QFsxvCSJnKaxUFPEgbl 5vn1cMBDRJ9fcBz2e4Owhaj7xhR1RpR9aagJLFVS68a4z1fmCCLbzMnx+OJc9g5czku8 vKpgl7jrk8MgAlXvJtYwQDT7z7+obHOPf0QMbinroQ3hnt5lkNunhJUjsPqcgcKmCdG6 I6XYM3uUiTb5k+XX5gxEwGFr54RD/orrBO170H1gKBVO8WLyYGUrRLCF/7bHtu4f0ZMn gkFKHjcWv4hVjfQp+HE5Iv6cTLpfAlDjCxPLpbC+O35HwA51csikQKh7toZcIIQzy8Wc esuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LPCp0aFnOEUIsu/+Wmrldlurtvj44ZJm8WKdKYKZ75Q=; b=FmdFwlRuc7BFQyqjSVTjVOReSdvSAm9GrcSYAG4Dns9qnJjmexgC7W44iQNK+hI9xJ cZh1uI8wBbJFrkzfkxbqy5p9g3+E3W9kKk/f4JWp+z4vH6juim6ktnfVYK3ozci7OFZE k0csjW6sEdNbNxI62Me5IpFy4CmK9Xp4dBhEky7HYPQ7heIhCTJ6DgXc0Atd+IsXo6wE U/pCVVZuhzFy8YiVQUgMDXQ+Uk9gvdg4mjZ/Tq0FptKNDbExdhI5z45dqVJJ0mg4Hi4C AjWvEjMnhJF6lQybeipLwInl2kKDpZnJPHfTHKzStyGHz+16lzePPffU3LnlpTSFSfD7 3Chw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=s3Ff7LNw; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j24-20020a635518000000b003816043f0d6si3571180pgb.715.2022.04.12.13.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 13:27:37 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=s3Ff7LNw; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 651D98FE45; Tue, 12 Apr 2022 13:06:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350170AbiDLGkZ (ORCPT + 99 others); Tue, 12 Apr 2022 02:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350534AbiDLGiI (ORCPT ); Tue, 12 Apr 2022 02:38:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB2A167F5; Mon, 11 Apr 2022 23:34:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC88C618C8; Tue, 12 Apr 2022 06:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EED56C385A8; Tue, 12 Apr 2022 06:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649745285; bh=9EP2H3FmaY9uDflc+OPb8r+3hcuSkuIj0pvJzZiloEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s3Ff7LNwQYmUh9CV25Vh1KQHIEhpu6hOBqSFU8Q4QDi4qTF7dplE7C3pvomxuyix0 XCpL//z5iZ9zSVKYElBv1nygEWlasCZ4QczGcheVh6oVg4Y1HeARUM3l34+nskZlir UvjPyNPv4UeP9i9Fqk3SdBg/d/LwIN+f69I/dObM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jack Wang , Damien Le Moal , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 044/171] scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() Date: Tue, 12 Apr 2022 08:28:55 +0200 Message-Id: <20220412062929.162009623@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062927.870347203@linuxfoundation.org> References: <20220412062927.870347203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Damien Le Moal [ Upstream commit f792a3629f4c4aa4c3703d66b43ce1edcc3ec09a ] In pm8001_chip_fw_flash_update_build(), if pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex allocated must be freed. Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com Reviewed-by: Jack Wang Signed-off-by: Damien Le Moal Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index 397fce8de46c..da9fbe62a34d 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4845,8 +4845,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, ccb->ccb_tag = tag; rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info, tag); - if (rc) + if (rc) { + kfree(fw_control_context); pm8001_tag_free(pm8001_ha, tag); + } return rc; } -- 2.35.1