Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp798220pxb; Tue, 12 Apr 2022 13:45:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1slqaeCswiCyczKreN35xCryFWGoikTIxwuVOYeVqfo/YHla/L+auQC6dYiY21PiUmP4l X-Received: by 2002:a05:6a00:a26:b0:4fd:f9dd:549c with SMTP id p38-20020a056a000a2600b004fdf9dd549cmr39732098pfh.42.1649796359201; Tue, 12 Apr 2022 13:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649796359; cv=none; d=google.com; s=arc-20160816; b=ZBUk8tXZztSr8PH+6/ECuckFiQ9LaKFb7g2oaThBwsZy/EpbMe30ZIHODjeMa8mjui Hlsesdym0eQ1jM0vzNuJbQMq1gIWjTT7pskvI+EpBY//oJBkjhxyMkEZiyXgiflZhY8x Uegtbmzzac+kp21Skp70SOGTUFA/6Pym+ZXXK6b1wtfk8sq5a6/b8IEM74H5cgiK+/7c X/PxXPZWhBi4fbEIH+ZRqrhQUCjBq8nzKtUo0NFjy22d6J+DV56Yfg6VLmp/wm9boVk0 V3XsspKiepUeH7v//eP0ZElMqCxf9bZ/StM8YDrCZ4Id6bIZqWmFxt8Mm1nf3qGpALiB c2dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zuE9Oa+Qeir18sQSYzqnRYIpuPNJeRgzj07o7ivdwmk=; b=PkwJ7J2clexriAeItt0kaP/vq2LToMkptN5GsaBHVGgJfsFIIMbpedTxzQDm8RNJcG d8+h5EfOu5Oeb0OYL/GU7dxSC6xnYDxfIRSdKpam+JGfubPNkWTGIYKnW2xC5IYsvc5s F6yqRNVr6hvQsk/KZLQdSp9boTSwU4pqkDKXFADX3tep5db1MToyekADAKMYIaQGtW0Y LZuBn7ENroOZHjakO/wZLgsghf+tyJNmKGF4tuJuFoyJ/8eHpTMDyc7tTQZCTeYMl6zt WiguLBVqeEhFd39rGsxFqhGAd9A6vnqK+pCwBQrBk3IaEOo4t5bGwRT+kRNDucuFUm4C 14Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jhLaW6gC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u12-20020a63600c000000b003816043f105si3522991pgb.762.2022.04.12.13.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 13:45:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jhLaW6gC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 49E9F2C11F; Tue, 12 Apr 2022 13:15:01 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244971AbiDKGjh (ORCPT + 99 others); Mon, 11 Apr 2022 02:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234271AbiDKGjd (ORCPT ); Mon, 11 Apr 2022 02:39:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FFAE222B7; Sun, 10 Apr 2022 23:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zuE9Oa+Qeir18sQSYzqnRYIpuPNJeRgzj07o7ivdwmk=; b=jhLaW6gCJNXjHQjbpXI001NoLm AdFauJ9hVbDbbdwuShc0kE3TWVJ7U6cHbS1IVv5Dkz7vDn/LxPDJbM1rz1CQYtaBq9enHaO+9NlL/ jw3q0mng0Gv7hWxJJvqwU/5geav0RGI5PD2R26zZwNTmbVZ0e2qgaOoci6Tk8P03ECRbTlHhAWhWI Nu2CciiC2elMY1Hh1rOZEbKyZ+CMYK7ToiTB8yDWTIR+NTU9faXcILk2jK5BIglpKBW1v2DZQYhXT c4S6MZxbtPM/AI23zj/vdJiRazAwFyTd0o2QCLP287g1iNfUVd0oCI7ghVyoF7Tju6mc5yarGTDAJ +XuGp9AA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndnfr-006wdX-RD; Mon, 11 Apr 2022 06:37:19 +0000 Date: Sun, 10 Apr 2022 23:37:19 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com, Christoph Hellwig Subject: Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap Message-ID: References: <20220410160904.3758789-1-ruansy.fnst@fujitsu.com> <20220410160904.3758789-3-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410160904.3758789-3-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + unmap_and_kill(&to_kill, pfn, page->mapping, page->index, flags); > +unlock: > + dax_unlock_page(page, cookie); > + return 0; As the buildbot points out this should probably be a "return rc".