Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 11 Apr 2022 12:25:08 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile
Message-ID: <20220411152508.GH2120790@nvidia.com>
References: <20220411141403.86980-1-hch@lst.de>
 <20220411141403.86980-6-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220411141403.86980-6-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wzPuRw6mQbvzxJOnLSVLJBXySCi6aPKnLEoLxoLpaFcAAkvcSXaoowrQ7RtB?=
 =?us-ascii?Q?zakniJXVB2ZFsoj/tQdeLqMvmC/Z50EaI9ibuyVQ8v11cqhLULELEE/7oAnh?=
 =?us-ascii?Q?fwOcJBrJDVQGUvifd2MYOFn8HEZmtpAqQljn/0r2H3BBb1n6cHMdfL7MYaFo?=
 =?us-ascii?Q?TSwJd+LheC4nY8dxTVvIp2gaUMqVGDTDn3TAxjouh/c3+3yiI4u36WvjiPZ0?=
 =?us-ascii?Q?hdmeQxrKSFa+QS1Y6e7rgVovsHGs4B+G/+fLXdSGRuTnY6coVFKg2FPWlWnU?=
 =?us-ascii?Q?wZUWm/Pv8Q8HTzbuV84ZnrN32NsT3UpzmAmBXy5yx5i3YZnORTAHY5QtSxg+?=
 =?us-ascii?Q?kRWufAdcDni5jN2fiIMXpYDA8stzhoaVrLDiSyT/sH6hqeliX8F0VkX6WXrh?=
 =?us-ascii?Q?dBGnNxSNcc59+l3EPkCNRLf/ooqV62ifZd1ER8+Z2CQfH+TsDUtFdI9rZiGR?=
 =?us-ascii?Q?yS7CE7lfuRPN1Xmd8iWCNPd5Fbg67N/wP06WhJsa+5aV4sRq4wLqzEBjp65W?=
 =?us-ascii?Q?igBZOjgeJbHZcHyBgs9ppaxWQHx+l/TNkBIrPUPIzvdmPtRURpNJBoUWsk3u?=
 =?us-ascii?Q?NFZuIWrDnnZNtP3gdA1qXZ3O4nbPgACA3BrdVOb76wQ2Z0xGA+DgyB4LDkRP?=
 =?us-ascii?Q?pchIXYyeJkJ95ZOVFizr5lqEyU2cJeDEuPjIhVYvzwPY1mQLsmnvTmPXrm1G?=
 =?us-ascii?Q?xvvLQAd58IQXgm7TWDZuj0T87kxS9dtHAaAhsNfAu3wilZos7Sk1nzbdCNhv?=
 =?us-ascii?Q?coUgMH68DDDMKIfQzqnxLn6fNAtDxQfkUQU8Z38DowPNPFCugjRNXFzpOq7q?=
 =?us-ascii?Q?m3z5XJZmv4AH2zo+WKfWBVCGwO+kKntGwflNbCI6EU1qmaJPVlfCmOqVhfNq?=
 =?us-ascii?Q?R0Nn8+PZNkavLEJd6iLNlCEP1yCLNWBIohjlgKQujAqAgVRJxvmZNMuCGwmV?=
 =?us-ascii?Q?tUVVb2wNKH4yTCKSILHOmwv0h/XdCyW3oPKBUm1hMDGdUy3niH3wsg3pp+Ao?=
 =?us-ascii?Q?MbgA9gFNzSkmzBpCL4WBDIAhBy7ducPl41kre6YD5qL9ybHo2bQNrFYJzUzj?=
 =?us-ascii?Q?oiB74CgBBQ+Iku/6RGMqUKFScHNQntqtMEV96ueEOPPcSOF1o6K8+ZWoM/ZC?=
 =?us-ascii?Q?wQIfvte/4/axw7GZbctVsOO8GnD2xXfcicsPkcpGMkVbvpcD7KoJdWD3uy00?=
 =?us-ascii?Q?I8RpH5dcGhh1Kdt/E5zFNk8bpdKuX1XYPZ1egUmlRfDSuULdf7E/h0QCCpRg?=
 =?us-ascii?Q?AW/MY9aKckXszeXJIXMNflD/+84jlt6EjnRVBtl+BMEHCiE0u2QERlx0q0aL?=
 =?us-ascii?Q?Ag6z4VFzfEmdPdydLMHDpZ4GGHO2OP66L23FrCQeVw+hxXwZuHn3BxGSCAOc?=
 =?us-ascii?Q?nXHgS6Dazi9TsG6VmEE74PwuEaRAJvOo4F+osqg4a0IVd2YqP9BGHM+XFsa8?=
 =?us-ascii?Q?/BR0gggs9EYndlIN7K/YzYDBb3naWVqFr7Eymksd3E6xCHeMr01UELXx5k7c?=
 =?us-ascii?Q?vRjMsj6bJY29WpSDjjjBTMcnWXSXEOtYexMn3PzYFAvioRPS6QiVVInuh5ff?=
 =?us-ascii?Q?9oVTjpa4pYJhG82HwEXlplTijBP3bT42EE26M3F9lBypwtSyNbfHB58985ee?=
 =?us-ascii?Q?DRiZS3DNmJ6ThDUD297GF0cvyCHXBZQSUyOVWNw7jMFtvVwfbqmLfdkom9jS?=
 =?us-ascii?Q?nIbEvcwC9OJXKH71GqN2a8L9NlljukAMGFdedbSIWIlYUJDiKwyKR0SxNp+k?=
 =?us-ascii?Q?gpGryeQ5MA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac77500-be48-4060-84f4-08da1bcf76bc
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 15:25:09.1374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KNImqD7L5nX6ia+s+3n3m6fZLbSw2hi43IqDcMF8T2N+DNq6U6k5SaoXx78El1Iw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4105
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 11, 2022 at 04:13:34PM +0200, Christoph Hellwig wrote:
> Match the style of the main i915 Makefile in the gvt-specfic one and
> remove the GVT_DIR and GVT_SOURCE variables.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  drivers/gpu/drm/i915/gvt/Makefile | 29 +++++++++++++++++++++++------
>  1 file changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile
> index 4d70f4689479c..f2f6ea02714ec 100644
> +++ b/drivers/gpu/drm/i915/gvt/Makefile
> @@ -1,8 +1,25 @@
>  # SPDX-License-Identifier: GPL-2.0
> -GVT_DIR := gvt
> -GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \
> -	interrupt.o gtt.o cfg_space.o opregion.o mmio.o display.o edid.o \
> -	execlist.o scheduler.o sched_policy.o mmio_context.o cmd_parser.o debugfs.o \
> -	fb_decoder.o dmabuf.o page_track.o
>  
> -i915-y					+= $(addprefix $(GVT_DIR)/, $(GVT_SOURCE))
> +i915-y += \
> +	gvt/gvt.o \
> +	gvt/aperture_gm.o \
> +	gvt/handlers.o \
> +	gvt/vgpu.o \
> +	gvt/trace_points.o \
> +	gvt/firmware.o \
> +	gvt/interrupt.o \
> +	gvt/gtt.o \
> +	gvt/cfg_space.o \
> +	gvt/opregion.o \
> +	gvt/mmio.o \
> +	gvt/display.o \
> +	gvt/edid.o \
> +	gvt/execlist.o \
> +	gvt/scheduler.o \
> +	gvt/sched_policy.o \
> +	gvt/mmio_context.o \
> +	gvt/cmd_parser.o \
> +	gvt/debugfs.o \
> +	gvt/fb_decoder.o \
> +	gvt/dmabuf.o \
> +	gvt/page_track.o

Up to you but I usually sort these lists

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason