Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 12 Apr 2022 10:28:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jaehee Park <jhpark1013@gmail.com>
Cc:     johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH 2/2] staging: greybus: remove return in an empty void
 function
Message-ID: <20220412072843.GD3293@kadam>
References: <cover.1649712572.git.jhpark1013@gmail.com>
 <eaf51ac31d264179298cb24c91f05a14e3651bda.1649712572.git.jhpark1013@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eaf51ac31d264179298cb24c91f05a14e3651bda.1649712572.git.jhpark1013@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t1+bBNZGqgZotuQohVZWosSHZxLgFsacThHyyJPbaNVPdsgYNPO0gBzbua2v?=
 =?us-ascii?Q?Bfg4OVWbA9d0reSrKVn85VTO73kibArBNE8JR6laSlnlvE6qwHZiSl2tugbf?=
 =?us-ascii?Q?0osdXs0IJM3OxhZ4jK/Iep+5X1C2fhfnec0d6VbbCDAteDTGAdLVmsAwVLr3?=
 =?us-ascii?Q?znQHtQUMtubXhnn1ChZLmo87rWpGz645thWkz+utr0O7+Q8wOe6QjwW1KDd7?=
 =?us-ascii?Q?d0XZN/J7vSk9N3yRGPFw91A8yICejS8bsiLrfm1QvHC4Guj4FjKjcjJ+yP05?=
 =?us-ascii?Q?L9ja0/as7AhdJRs3qVOwf0ch6Kaklt2vZSbrQOlzFo4rMx6XqSroket4DzbD?=
 =?us-ascii?Q?gFzYeDMP3VSOVkkPQuVciuzW/uDiuUUl1ciLc+Dzjr1A+eE0uHwF1EhVU2t/?=
 =?us-ascii?Q?hikXYG52UYTSrQqpDfmZRSjRkDwSugeVSGODcD2TW+Muqj7CUQNC9Hhvp/34?=
 =?us-ascii?Q?ocbKm1Wg2ORuT4oim4kMIf0cuzOFkI51+uqQeJBYtX84c4nCr3ADEFVO0MZO?=
 =?us-ascii?Q?8S1F2z5Wgcd9u4C0TX/QEKH9Cyyy+mukNBKqWF7PCDtE5IglTN/nCkv4gdyR?=
 =?us-ascii?Q?fYalMnIR5rE31Bd0dXcZWoHDTt8fP5sxnjWM6kor2b7QOPdutGqFG9xdfNQ5?=
 =?us-ascii?Q?9WSFGzu3L7sF27NvKajKhrSVW91iVymQGe06zNNh+W3j0EBaFFr4UjZ3BzbP?=
 =?us-ascii?Q?oOX7B2H7Hmz9Pf/HmhNdK1mmQZFZ11bkPRCMKlqgrjckJnIzYrv/vLpbeOsY?=
 =?us-ascii?Q?5oJqxHh0u74dxjTTA7jyAOUpdstrgA92BAk4tHwRKwLjwcLhyPbOPhO0DUeH?=
 =?us-ascii?Q?EysPM/pvKvdDtbPnZHAEsy8xsB89x15is83AIQrZp1jX2kFPynmkU2PbLCIY?=
 =?us-ascii?Q?01X/QM9I1cTfjUdvgBytAUPRgbooaSUnFw1YGYumBkMDtF8u95/sOskY0lU1?=
 =?us-ascii?Q?M6fo73FWKi0UkfKyNazGBppm3nnkzDz8FY1bWJA8X8Cm+l8s14gbnOYUU7Ij?=
 =?us-ascii?Q?oOy6sQ1bceXb1vLUnBNxXgBbDrkdUCQh6DxmW/nVCdJ8tZwcrEZKvl5+QhN9?=
 =?us-ascii?Q?nxEPcY20FISs8YabT8kLCJ55pj+K9iSpaPxIwlnodx8sFgLZBXBEjiMgcUMO?=
 =?us-ascii?Q?Hfq0Mb6llLL+Cdl6+yXRjbPw8/P7KLky16K0BskJYajjOCTbPXXXZb5pLd8R?=
 =?us-ascii?Q?Je3F6aKOVFzO+DuFJ2c+JIVh5fIL9FOSmma5qLvkzAkPHmZc1ElbLYT8VNmh?=
 =?us-ascii?Q?Dt03Y0OTMfG2i01XoYCvR1TKlxIr86pcXCBMGZ+7Y8D6izoWpJv53H+QVvHh?=
 =?us-ascii?Q?qkD0azJyojKj1F8kGKzqFAw9kiXOsvjiixO17M70dbzAg7eXasKGeow/1Alh?=
 =?us-ascii?Q?oxltLyumMj9kdhCWv//+WROLB583WhHJ6KgLOz7j5nB8U+I8S3R2IEgY2WXJ?=
 =?us-ascii?Q?AfJRsrg8J/Cf7pihkIZFlc0khADLrwsJU8UnkImIzBNG1SXWBPt+pcKQejtL?=
 =?us-ascii?Q?Wdo+oWtxz4WuBeRERHgKsnnrLoA9Tv22YeM0twg59U5fxTicOTuXjGx1TZaE?=
 =?us-ascii?Q?63w6vV5+x0LFsMIVvYPm4b6kggMQ5eGsG1kCaojOWQvdsqMIshirIcDQacdS?=
 =?us-ascii?Q?uvxH51iirOCjJfYXh5VvmgGrag/Wc+c3TpNNJSCR6enqEUY2WThalKmHGq7u?=
 =?us-ascii?Q?vraPDSMNFifekgdkVBpN72qJiC43ACK0Tqj/Ny981IdOP6EmfbnE8i8pD6XY?=
 =?us-ascii?Q?4DJ7/kaqT9OxSrhOrsDrAm1SvPZc3Vw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a50ec1ce-ef88-43df-bfc9-08da1c561f90
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 07:29:05.3222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7nLTNq9XF6Sd49RctmkLGhCGdVvtz7rAMJGMu+q5l6oCFUTq5YLWabLsZ0RIgxUEF5L9cK1q72q2shCem2kt/Vmu1j5Ll0f+c3KOXxp08ZQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2813
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-12_02:2022-04-11,2022-04-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204120035
X-Proofpoint-GUID: JdD3anpQKnbib8P5-6RcIf7scQ7U-wgC
X-Proofpoint-ORIG-GUID: JdD3anpQKnbib8P5-6RcIf7scQ7U-wgC
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 11, 2022 at 09:50:22PM -0400, Jaehee Park wrote:
> Issue found by checkpatch:
> WARNING: void function return statements are not generally useful
> 
> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 0f50d1e51e2c..3e3a16568def 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1032,7 +1032,6 @@ static int gbcodec_probe(struct snd_soc_component *comp)
>  static void gbcodec_remove(struct snd_soc_component *comp)
>  {
>  	/* Empty function for now */
> -	return;
>  }

This function is called from snd_soc_component_remove().  You can safely
remove the whole function.  We do not like empty stub functions.

regards,
dan carpenter