Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b33c1fbe-a7b5-f5b0-5dc6-f017f5cfc7f4@amd.com>
Date:   Mon, 11 Apr 2022 13:55:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCHv4 1/8] mm: Add support for unaccepted memory
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, Borislav Petkov <bp@alien8.de>
Cc:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joerg Roedel <jroedel@suse.de>,
        Ard Biesheuvel <ardb@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        Varad Gautam <varad.gautam@suse.com>,
        Dario Faggioli <dfaggioli@suse.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Mike Rapoport <rppt@kernel.org>,
        David Hildenbrand <david@redhat.com>, x86@kernel.org,
        linux-mm@kvack.org, linux-coco@lists.linux.dev,
        linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mike Rapoport <rppt@linux.ibm.com>
References: <20220405234343.74045-1-kirill.shutemov@linux.intel.com>
 <20220405234343.74045-2-kirill.shutemov@linux.intel.com>
 <93a7cfdf-02e6-6880-c563-76b01c9f41f5@intel.com>
 <20220409175210.xik3ue3shpagskvi@box.shutemov.name>
 <adc87911-e1f2-4e2a-2394-17ee9213ae3e@intel.com> <YlRPdQP5c1DQqZeN@zn.tnic>
 <fae338db-f892-b234-6918-227219e45cbe@intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <fae338db-f892-b234-6918-227219e45cbe@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjJZaDhMUXdpeTNieUlYTUt4VkJtM1pXcG4rb1ovZnJ1UkIvNGY2eHNLVm5s?=
 =?utf-8?B?RVdZbzkreE1kbktqT1RuVmUzSWxnR3dleU5GMElpRUlhNTJRdHZqSjZFa2hK?=
 =?utf-8?B?YzJWVUJOSkJyam9ob2l5UXR6QU5razBDeTdwMWhpRHp4U01DZmEzS2N2VXEy?=
 =?utf-8?B?V2hoSEZVTWhGT1ZSU09Jdit2QlltK01wOWxMUXB2ckpDSU8wU21wNW01YWtz?=
 =?utf-8?B?Zm92eEVVWWhTZlN0Wnplb1VTbnZhOVJ6enZpQnhoQloyVnZRa3NPdmd3UjR0?=
 =?utf-8?B?SXRHOHk5V2lKMnkvZmpIM2ZWaGRwV25qOXpScXBPWk14MnNNL3NpQkZ1TkFh?=
 =?utf-8?B?NkR0VmFZVUJydWZ5ak9TRS9tM1pCN1VWSTY1M3hzWFMwTG8vTWRYQnV3K1JS?=
 =?utf-8?B?VUNleTgrSGNyL0NnVisvMTBGV2pWL2JGdzdoK0owVDNUeU1ObTZ2U2dhT0ln?=
 =?utf-8?B?Zk5BSG03U21jRmpWNGZGNnVzU0xoK2pXZlBycC8zMVV1aWZ3SmZudHdScWVV?=
 =?utf-8?B?dnYxaWhXaXNxODRpVStMSDBmZGZCSmJWb29tek1sNDNnRXBOMk9UMytaSnk5?=
 =?utf-8?B?VjltK0RBMm9qWGlMYjNiS2ptbllyUGpUVnBiK0x4eWh0eGFOd2tReUZZQ3M1?=
 =?utf-8?B?OXRRL05PVi83bzlYVmR6d0dYaStBSkdzeHhubVIwbHk4Ty81NWd4R1hHMEU5?=
 =?utf-8?B?RStkN3N5bjVyRVI5eFcwVUNNYWpDZDRJUDcwK25Ic3pocCt1SW1yajlxVkFp?=
 =?utf-8?B?TEM5bys2RzFCY3NncTBxUks0c25QSkV0UXJwWXhqU3FkUjIvcmp2OWwxUHU1?=
 =?utf-8?B?TGJZd1FDUmlGRHZyZjRwTzVlUEVVdXFEa1Q1Qkl1eEN1bkxTYnVaSE1pKzd6?=
 =?utf-8?B?ZVZYUEE2TEVKcG5QOGpzNEdES0VmbUVEbFE0TWdoVXh2TWo2QUxuVXZ4ZDNz?=
 =?utf-8?B?VWxwOEE0Y2dBQTNibG1oa0R3OFZydXhkS0NCS1dwajRXWlljOUNwNWRlREg0?=
 =?utf-8?B?WjFQcVFIVVJFN2JnRm5WcVV3b25MSWo2M1ByNHBUeE52R2hRclFIVHdoVlpG?=
 =?utf-8?B?b3U2c1UzQ0RZdjRRSVdVdTEya1dYQmhqd0FIRnYweCtLQmM5RmMzazFUNStY?=
 =?utf-8?B?eHlodU1ac3Z1c2JCZmxOZ1F2cUhoN01GcGpsR214ZjdpYTR6V0pHRFVYa0Vq?=
 =?utf-8?B?REVZd3REdzRTSFVyMzMvbS9Yc1FqQ1pzc2t2Z2VlelRwMW1oZS91SmZyc1c4?=
 =?utf-8?B?eWUvdlVoRlIyeVdEaFU0QjNDeDRYY054Y1dBVXlRWG9qUHQ1TFBLUlpsYTN5?=
 =?utf-8?B?TzZJN2t6Z2Zaa2xDeTdFT2hQZ1JrZzJFVVpzbU9UTFdwSWNBbW9VVTNCTFpB?=
 =?utf-8?B?TGJ2QUJ3NTU3Y29vMFlaNzBEdjZXRytXYnNuajl0NXR6MFYzaW9OSkJIQlIw?=
 =?utf-8?B?dmp0YVNKRzFYamduQklEclVSdnRWK3ZiM1phOFQyaHUzVU11a091SjgvSE5l?=
 =?utf-8?B?Qm0yOEVtZXVJQ0pUOEx0KzVFZWZ1RTZBYkkwMCtZK0F1YkJ4ODAxeWdGdDVR?=
 =?utf-8?B?Z2xOOUsxdGNWUTNPMENmcFI2OTUxUFRRRWlYUnRwQkx2VjcrYTZJbmszVWZF?=
 =?utf-8?B?YVlEUlVVL1VZTjdCdWcrMHkxOWpIVTQ4dkZpdEF6YUk5YlBwMG90aVBJMXlI?=
 =?utf-8?B?dk5wUzVreGRXMFkvRkxUcGpEalE1MFJOKzBIL3orQk1xeEVYV1FpTzF4RnFy?=
 =?utf-8?B?ZGxSMkYwaHhCRWZ0blZ6MW4ycTZZNkRrMEoyMnFwNGgzWDZubklKQTdZclNI?=
 =?utf-8?B?WTVQM2piN0JSa3VaSHJScGt1cm9hRnNIbmF3MVU0RkNOL1RLWEt3VHBzWnVQ?=
 =?utf-8?B?aUlnR0dYSmdua3JWUnJvanpqYlNkdFY1Yng4S2VrcGFOeldzdDZHSmRteDZL?=
 =?utf-8?B?S1pydkhhMDNscXBveGZRVDc3QmtKc2VyTWlzNUZoN24waG5waHlLWkREbCtm?=
 =?utf-8?B?NDVpcHpnVXZQeDBRb1djdFFNYTFuc2ZkVlloL2hZRXdNZjZDc09SME1ZMWVL?=
 =?utf-8?B?ZWswcGFoSko2czdoUTZXb0krS0xoSk1IemxhNi91Z2RFUGVrcTBJUWhFZm9O?=
 =?utf-8?B?OGVqVDdSUnJSOW5yN0VLcDF2SEp1cGxBb1o0VGlQd2RBUTAvNCs2MHo5L1ds?=
 =?utf-8?B?Y0tjc2lYREsyKzVPNXJpTmQ0ZXRVR2phOU9DSW9ma2xZRlhCb2xLWENVSFNk?=
 =?utf-8?B?dFhudEY5NHhIZ1JTSUREbUpKWUpLUmQ3bkxlQTR6SGlwWGFrV1VZaFg3dzMr?=
 =?utf-8?B?T1RxN09BKzI2SnFkR2xvbmN2RElBZVM0TzZGY2owMUYydFRPdWU2UT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e60ab51-3eb8-4557-1811-08da1becd605
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 18:55:25.1216
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mtTUfUagcansPbCRXDxWyIdVCVhSOHCYLWEAHAKwkwQcrtlIXvFyciqCzc+SPpUlgOlhbFOYbNKoodkcdrmIMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4271
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/22 11:27, Dave Hansen wrote:
> On 4/11/22 08:55, Borislav Petkov wrote:
>> On Sun, Apr 10, 2022 at 11:41:57PM -0700, Dave Hansen wrote:
>>> Let's just call out the possible (probable?) need for new ABI here.
>>> Maybe it will cue folks who care to speak up.
>> Err, why would you teach the user to go poke at some arbitrary sysfs
>> nodes when the accepting code can simply issue a printk from time to
>> time
>>
>>    "Guest unnaccepted memory progress: XX%. This slows down operations at the moment."
> 
> I guess that's not a horrible place to start.  It's also not *horribly*
> different from how guests work today.  If hosts lazily allocate RAM,
> they'll see largely the same kind of behavior.
> 
> What ends up determining how much memory is pre-accepted versus being
> done from the guest?  Is that just a normal part of setting up a TDX
> guest, like from the qemu cmdline?  Or, is there some convention with
> the virtual firmware?

With SNP, some memory will be accepted as part of the LAUNCH_UPDATE 
sequences that the hypervisor performs, but that is not all of the guest 
memory. Once the guest is started, the (initial implementation of) OVMF 
SNP support will accept (PVALIDATE) all of the remaining guest memory. 
When the kernel boots, there isn't any unaccepted memory.

Once support is available in the kernel for unaccepted memory, then OVMF 
could be updated to only accept a limited amount of memory and pass the 
information about the unaccepted memory to the kernel through the EFI 
memory map.

The approaches would have to be measured to see which ends up being the 
best one. The GHCB specification allows for lots of memory to be accepted 
in a single VMGEXIT (world switch) vs performing a VMGEXIT for each 2MB of 
memory being accepted.

Thanks,
Tom