Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
To:     'Jiri Olsa' <olsajiri@gmail.com>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: RE: [RFC PATCH v2 3/7] libperf: Add perf_evsel__{refresh, period}()
 functions
Thread-Topic: [RFC PATCH v2 3/7] libperf: Add perf_evsel__{refresh, period}()
 functions
Thread-Index: AQHYRD0e+lbI3eCp10CNuai8nxhivqzqc7Bg
Date:   Mon, 11 Apr 2022 08:29:20 +0000
Message-ID: <OSBPR01MB46008051704CF17164C05847F7EA9@OSBPR01MB4600.jpnprd01.prod.outlook.com>
References: <20220325043829.224045-1-nakamura.shun@fujitsu.com>
 <20220325043829.224045-4-nakamura.shun@fujitsu.com> <YkRgHmEc2GDtXfZp@krava>
In-Reply-To: <YkRgHmEc2GDtXfZp@krava>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?b2w2NXNGVEFGb1ZnWk0wOWtZU3NWTmM0UUgraVhScTh2dnpBdzh2bExD?=
 =?iso-2022-jp?B?MW54alJzdDhRRHlEblVaYS9yaEFBMXJieGxFbHFoN2E3NjlXSkFucGJV?=
 =?iso-2022-jp?B?OWJicFEzNTh2bXdpc3ozbmlaMFk2MEVlcFJZRDBnbWlQeGZuUGU5czdP?=
 =?iso-2022-jp?B?d3czRDFQN3BKSVYrZXlhN0EzWHVrY2RhRm1xT0N0emVpRlBWT0RGbUdB?=
 =?iso-2022-jp?B?QzNXcTZ3MzRhb0toa3Vmd3lhbjI5dVFqVncvbk5ycEJsS0NtdjR5Mk1n?=
 =?iso-2022-jp?B?ZDVxNUdIa1U2Ym1QUWpETUl1aWRuN3ZjU285eGJtRndSZnlka3ZUYWVr?=
 =?iso-2022-jp?B?bXkzVVZaVTV3NEdvbW5jRDhSY2dFWThYajlDY1JNdmF5dGNZWkx1clBN?=
 =?iso-2022-jp?B?OUxZSlUwUEFpU3VyeS9ScDMycEthSkNoWkhnQnQ5NUpYeVMycjIrVFRC?=
 =?iso-2022-jp?B?aldNblRVZ0p0UldtcnpoVVQvb3hCMjM0a1VNVzhDbnB1UTRYNWkrV1dD?=
 =?iso-2022-jp?B?MFBSQWxnTzFZd3dValdwOFZKK2FxWlB0SEFVNnpyR0ZxeFRQOGRZL0sz?=
 =?iso-2022-jp?B?aCtsZmdQODRuYmpLTGFzRDZIQllXT003TlBwTVlyRGh5czFmeHhXekt2?=
 =?iso-2022-jp?B?dTBlcCtNMVVhbUZSV2t0UE40MUxQTmVjWTQ1NGk3clR4bGI2QUdNN1Nz?=
 =?iso-2022-jp?B?WUFkS3JpWHo3bmFJZm5OVjRkMU8ycCsvdDZWUXVVRUo4TzN5WnN6NGNs?=
 =?iso-2022-jp?B?UDQ2d1JwSWRQVUVkK1c2aXUyeGQ4bzltalFSVlk2R212bVNRMDVHNXVK?=
 =?iso-2022-jp?B?Z0JUTkhrM1ZkOG03UXlUNitjSWUwZSttNWpyemsyQzZMVy9qYVlwZCti?=
 =?iso-2022-jp?B?NmZxRkJpVmVPT3RQSnIrMzF0dUo1TlhKODFuNmt4dGlrSzYzTTZ0aFFS?=
 =?iso-2022-jp?B?a3BPK1N1OGFLZktyeWE5UU9HVldzbDN6RVVETVlvam5rWnkrR2ltV0Nk?=
 =?iso-2022-jp?B?VkhrVVJYcm5HRTVPd1V6UDRJeE5PTDlmcmJZRnhCa1BaRXR0OVVJQTBE?=
 =?iso-2022-jp?B?a3VOcG1Calc3ZmdPS0wzUy8zVy9uMDEwZmhhT0JRd0taSi95WFo1YXBW?=
 =?iso-2022-jp?B?WGZXSjNRWDFWR0ZrTm9IakZOZDI4SXVwdWx4dm1IaVpRR213cVhTNjd5?=
 =?iso-2022-jp?B?ZGNGZzVabFkwMTlEMGFkK3l3RHQvUWxiSkNjTERtZXAzOVBFT3J4ZzlJ?=
 =?iso-2022-jp?B?b0FhbFI3WTdlaDQ0dlJuaW8yT1QweHN3MzJocHh3RjNYY2lEd215dXU4?=
 =?iso-2022-jp?B?YnorMHAzQ1dMUWNucFpJZ1VFdmxnc0ZpY2o0UWFzVTcwdWRScytKOU1w?=
 =?iso-2022-jp?B?OXo4YkJtSnI1K1BVc29rc3VIWlBDcjI0L0Nlamx0UFZlNnNFdU9tUnly?=
 =?iso-2022-jp?B?cHJrUzA3VkJYc2p5bEEzL2NJNmViOXJOcENmR3R3WjFjWVNMa2w1bjR2?=
 =?iso-2022-jp?B?NWNXWFJIVGhlQ2sydlFXYVdIUmZReVJDeWNDc2ZVNERNZHRubmJrc1da?=
 =?iso-2022-jp?B?aWdZYzVBSXh5dGNDK3FSRkFaVXF1TGx6N25BU1RCYmNUbXYyUmFkcnRz?=
 =?iso-2022-jp?B?MURWYUNGWnBWRU1zVjVHY3hCbzBRMDY2Z1E0Z2NRMXFYZldrbmUxbGsv?=
 =?iso-2022-jp?B?YnZBMWc4OVZPbWtFZGhra1B0N3o4UTA0Tjh4NlNTSXdtZXpsZ3VHdjFK?=
 =?iso-2022-jp?B?WE9SRW5vUFRhVExzbTRzTjVvRUIrbjBuamVEaHZ2aUxrcjVkTm9vUjAw?=
 =?iso-2022-jp?B?Y3BxRDBEL05uOEdRbDN2TkpoaXA2ZVNqSis1b3pXeUorRXB2T2pLSmR3?=
 =?iso-2022-jp?B?b1g3aUptai8rbEo0MXZCWkJ4eVF2a2ZMc29xZWZKbXp1WksrSHJZblBW?=
 =?iso-2022-jp?B?OTZGL2xsV2hUNktyTUl2aERHRG1walBXNzJQanRVZW15dEM2d3BGZ3Ro?=
 =?iso-2022-jp?B?OFFtZ3V0NlNxOHFXRkE1UEVRRTZrQjZaMzRhSGcwSjk3MGRsMFoydFhm?=
 =?iso-2022-jp?B?YWJsSThJeUF5ZnQrR3lFK2VYSzM4enBTMHFoOWM4d1ZCbWtIMjN2MlJB?=
 =?iso-2022-jp?B?S2huNjVNUUxmRUZVNm9PM3I5Ri93b1dmbWI5c04ycEEzS0Nhc1hKL2dE?=
 =?iso-2022-jp?B?VDZRU2xmcnd0QnAyVlRaTkJpTXZwMVl3NWpFV3Z0bkw5Zk0yOXFOSHhY?=
 =?iso-2022-jp?B?cVpDQkJUU1c1VmljUEswMmtOVGc4Y09UQ3gyNTJ0azJybDUzc1ZXWUR0?=
 =?iso-2022-jp?B?dm01Mis2cUhSZ3dFdFZDMmtiMEMzN05zM2lXem56d2pScWxSeVl1c1hG?=
 =?iso-2022-jp?B?d3M3MlQ3Y0ZWS0JDOUhIOERKMitvZStSRm9JdXJDZjBtTk5Xb1BWVjZW?=
 =?iso-2022-jp?B?b1hHQTZFZWM3Q1ZJWXVwVjcyZ0cyREVWb0N4RGd3S0hib2FIYndwV0RC?=
 =?iso-2022-jp?B?Qm91d0xYTElSNWVJWUtsSjhxWXBoZVRaeit3MW9vSDYvdndvSUd1azVH?=
 =?iso-2022-jp?B?TkYxTmZnWT0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB4600.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4abe55ff-d2f8-45b5-e3d5-08da1b95601a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 08:29:20.2017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: liWlnQtKPLPiJzqQJCbmuQqD9W4UrjwpHkCrP7ytsUOl/u5i6C0bcKkqoCSLfK9Do0kiiGVo7mjPmhLHOz0uYlf3uLmhmTyQC1wf7kwEM5E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8331
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi jirka

> On Fri, Mar 25, 2022 at 01:38:25PM +0900, Shunsuke Nakamura wrote:
>=20
> SNIP
>=20
> > +int perf_evsel__refresh_cpu(struct perf_evsel *evsel, int refresh,
> > +int cpu_map_idx) {
> > +	return perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_REFRESH,
> refresh,
> > +cpu_map_idx); }
> > +
> > +int perf_evsel__refresh(struct perf_evsel *evsel, int refresh) {
> > +	int i;
> > +	int err =3D 0;
> > +
> > +	for (i =3D 0; i < xyarray__max_x(evsel->fd) && !err; i++)
> > +		err =3D perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_REFRESH,
> refresh, i);
> > +	return err;
> > +}
> > +
> > +int perf_evsel__period_cpu(struct perf_evsel *evsel, __u64 period,
> > +int cpu_map_idx) {
> > +	struct perf_event_attr *attr;
> > +	int err =3D 0;
> > +
> > +	attr =3D perf_evsel__attr(evsel);
> > +	if (!attr)
> > +		return -EINVAL;
> > +
> > +	err =3D perf_evsel__run_ioctl(evsel, PERF_EVENT_IOC_PERIOD,
> > +				    (unsigned long)&period, cpu_map_idx);
> > +	if (err)
> > +		return err;
> > +
> > +	attr->sample_period =3D period;
>=20
> what's the point in updating attr? this will be used after event is creat=
ed right?
>=20
This is to maintain consistency between evsel->attr->sample_period and the =
sample_period of the created event.
Users can reference evsel->attr->sample_period using perf_evsel__attr().
So I thought it was necessary to update the sample_period of the event and =
the sample_period of evsel to avoid discrepancies.


Best Regards
Shunsuke