Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp812181pxb; Tue, 12 Apr 2022 14:07:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfdKzIEbSrE/e1tC6Yzuok8r3Tc2Yl//xaWThW6WH0nwFmpYhP/7amF5ygr9S7a7oJUGw9 X-Received: by 2002:a17:902:e94e:b0:154:3a4:c5e8 with SMTP id b14-20020a170902e94e00b0015403a4c5e8mr39775085pll.19.1649797676764; Tue, 12 Apr 2022 14:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649797676; cv=none; d=google.com; s=arc-20160816; b=dyKhDTKq5ZsyoRlSHJbXoYR2IB5uASUCDJwnfdCjxksz4E4tt2gNe1xO2ywyAuhcpW bnyGjhM7jyUyt2S6cb3y9y/sGpMagPVASGdW7dIoGjQKCNgvXoLZygIUye0rq5ek4hyM qsrONn+5e1fZeIx5KuX9o/EAxuE1feW6YyjElvFWSEH/zOUkW7V4jVeo/lCxcqZz0rPD NtmA46p31Js5PQXq9tdQiVXNmPtC7iPEPjS2w65FZlsSjC/nZ/VUqZ+IhH7zC6wco7vM U5AouO4zJX94Z/zunwpxV+a1CG9IGuRcqVBFRfYRGl8YWQ8LwTsiOCSg5yrW2KKce5jl NtEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:date :mime-version:subject:references:in-reply-to:cc:to:from :dkim-signature; bh=FrFKHbqm+gncNNr/GE7P/sCi5NUXYl6uoAtzOQJz0uw=; b=uPI3HqOcuOxJt+arry5nQiJEXLXmlkS3JsyJ1jJLcZEkPEe01F+oHXktKuhd7ql/ZY apDA08OCIYEgcABgOveB6uOP4Axc814z67jAJ/0/YUkHFbEW1eMjILL0IK0w8m/GXgyT AW1qSKuZNglZnLOT/BQTRIlcKX3lD5qep1G5hXTgFw3Up/VkwijEiS2tBx9QPn1RF7JU ADXLkc13cspEq+n8TqJpCSoJBNIufQRYWfPaJ+d6X38mWImELtRFO4p2z2WQ8Vp8EcWh oXJWYAYHIdR0s7hFMfmymS5fc4AeGZu1mvYYyaSsB6hWyLyEzwHepTQAg7Cv9u3Ra1qG fapQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=HY0+KUA9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 16-20020a630f50000000b003816043f11csi3233034pgp.785.2022.04.12.14.07.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:07:56 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=HY0+KUA9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E1E9E255A3; Tue, 12 Apr 2022 13:25:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351002AbiDLMHt (ORCPT + 99 others); Tue, 12 Apr 2022 08:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352142AbiDLMCu (ORCPT ); Tue, 12 Apr 2022 08:02:50 -0400 X-Greylist: delayed 138 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 12 Apr 2022 03:59:56 PDT Received: from forwardcorp1o.mail.yandex.net (forwardcorp1o.mail.yandex.net [95.108.205.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14F7B7EA2E for ; Tue, 12 Apr 2022 03:59:55 -0700 (PDT) Received: from myt5-23f0be3aa648.qloud-c.yandex.net (myt5-23f0be3aa648.qloud-c.yandex.net [IPv6:2a02:6b8:c12:3e29:0:640:23f0:be3a]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id C90C42E0ACC; Tue, 12 Apr 2022 13:57:35 +0300 (MSK) Received: from 2a02:6b8:c12:3e23:0:640:132c:43df (2a02:6b8:c12:3e23:0:640:132c:43df [2a02:6b8:c12:3e23:0:640:132c:43df]) by myt5-23f0be3aa648.qloud-c.yandex.net (mxbackcorp/Yandex) with HTTP id VvOSPl0K10U1-vZKqNsac; Tue, 12 Apr 2022 13:57:35 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1649761055; bh=FrFKHbqm+gncNNr/GE7P/sCi5NUXYl6uoAtzOQJz0uw=; h=References:Date:Message-Id:Cc:Subject:In-Reply-To:To:From; b=HY0+KUA9/KG1iPaEgqtWOLMqbB6ker3H6nJ+bEKkBUyk/GDVUCriFi6FuoScIBrH6 /zBSEZ+7cX49D7nm2UKVbrnih8PWzyX4roPO4J2rz0L7HqFWHFU79W/d4YOPFiowdj HMzfEthsWm2s6Ro706+uJSjgHtPKcPeDDhwdASdE= Authentication-Results: myt5-23f0be3aa648.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru Received: by myt5-132c43df2a33.qloud-c.yandex.net with HTTP; Tue, 12 Apr 2022 13:57:35 +0300 From: Dmitry Monakhov To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com In-Reply-To: References: <1649749204-186363-1-git-send-email-dmtrmonakhov@yandex-team.ru> <1649749204-186363-2-git-send-email-dmtrmonakhov@yandex-team.ru> Subject: Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 12 Apr 2022 13:57:35 +0300 Message-Id: <258541649761055@myt5-132c43df2a33.qloud-c.yandex.net> Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote: > >> For historical reasons we check only IRET_FRAME_OFFSET, but this check >> is no longer valid because we also access regs->sp field which is >> located beyond IRET_FRAME, so it is reasonable to validate full structure. > > Uuuh, what? IRET frame is: > > ss, sp, flags, cs, ip > > that very much includes sp. Oh. Indeed you are right. Sorry. Please ignore this patch.