Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp812909pxb; Tue, 12 Apr 2022 14:09:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyn2+5hUdVebOs8m10td1M0mXjcQ9hgWh2WU24zI7Rp8Bu3ISkbB0WjvPUJYsWM4z6yot+u X-Received: by 2002:a05:6a02:184:b0:373:a24e:5ab with SMTP id bj4-20020a056a02018400b00373a24e05abmr32432361pgb.400.1649797756898; Tue, 12 Apr 2022 14:09:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649797756; cv=none; d=google.com; s=arc-20160816; b=ZAHI92Z2qtWwFoKDoR0dCH/p9/I/82I+fplk0bK0lQePQ4fFkIRc8LIjCtuKVMtARr odVOL8l0+E9YHBufAWXx3hgY/Y73pBkUAy2WwIW6jYlGZvb+LiJe1/XUtAesY4NmjuMM sOvU3+Su3tpCEwl7MJ9alct6HD234MGu17D4rrJiR/SJDCG6x0UKhdmAakfrJ09gGKY1 kCtgs3R/VYqFkNhQxZYnS6LnhzdatNLM1CuB9wxztYKCJWDbA39tvGAcTEiwMyv7wbLP vlukQQHLFbc1JYRaARwCUFBrGY9x2W5bQjvFYqzsRt2Y6ZhXAcadTBQNsA7dl8/kZ0Je UPvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=P6HP8CnOdWJ8mbQIHMT9mqx61IimONCxWlcgUyHXj6M=; b=idBkaj7IitHymBV+/di2Ye9fR9e200EkjcGHpe2Y3lS3dfMZvB3CKNA02sL0pW7/5O rP44q7o+IzjDIfhLGh3teEyuGZE83Zbl6Xc+WZLb5nnxQq35e8VUnQHrXuYsT2WIVhs9 FBIhdnLH6kA0G75Du6jg11Ijs2yB59ld5mN77vI1vM+397KoA8wls2wRLqA6OoyWFJVf dBN1XV6oDXJlOG8Pzti38mB1fUunR1t7fALKG0Y4vcRFnCoKSQoOZqk/+laZnNHISk3v XExaJ2srdQ2pT9AVfR2mlEj6CWndvcoin3aCMB+eGohgDC0p5ANnrmvrPKHiFuDBFbne zfWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UdHX1P8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 125-20020a621483000000b0050575372d7dsi11897702pfu.336.2022.04.12.14.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:09:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UdHX1P8w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C8C188B01; Tue, 12 Apr 2022 13:26:16 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231557AbiDKMPc (ORCPT + 99 others); Mon, 11 Apr 2022 08:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbiDKMPb (ORCPT ); Mon, 11 Apr 2022 08:15:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96AB040923 for ; Mon, 11 Apr 2022 05:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649679196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6HP8CnOdWJ8mbQIHMT9mqx61IimONCxWlcgUyHXj6M=; b=UdHX1P8wmvNoJQzjSxXL68N3/rG/tT3bDz8NH1m3RXv8mWqqSXLECw+8KSCBGFWXmxY/Ke +BTVYjyoMHdv9L2hjCLRKLlcRCe4E46JiqbtwOlhcWNojnao2ufCIZrWGbWSl9QDH+kBEz GrsBIPjwTvoo+bTKAnfQjhdieJhAjaM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-623-FiTI3jh0N4-mp5e4EtChTg-1; Mon, 11 Apr 2022 08:13:11 -0400 X-MC-Unique: FiTI3jh0N4-mp5e4EtChTg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8BD1B801585; Mon, 11 Apr 2022 12:13:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F8C11415133; Mon, 11 Apr 2022 12:13:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220406075612.60298-3-jefflexu@linux.alibaba.com> References: <20220406075612.60298-3-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v8 02/20] cachefiles: extract write routine MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1090419.1649679186.1@warthog.procyon.org.uk> Date: Mon, 11 Apr 2022 13:13:06 +0100 Message-ID: <1090420.1649679186@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > It is worth nothing that, ki->inval_counter is not initialized after > this cleanup. I think you meant "It is worth noting that, ...". Btw, is there a particular reason that you didn't want to pass in a pointer to a netfs_cache_resources struct? David