Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp815765pxb; Tue, 12 Apr 2022 14:13:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoMkV2JpyIgNel4hC2lCL2w6NAMOcPvZYyCK/AvP/rOkhtyfYa2rUjzCXv5ZSWfEFPm0kA X-Received: by 2002:a17:90b:4d08:b0:1c7:7567:9f6b with SMTP id mw8-20020a17090b4d0800b001c775679f6bmr7197617pjb.134.1649798029242; Tue, 12 Apr 2022 14:13:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649798029; cv=none; d=google.com; s=arc-20160816; b=LkluJ15zXN5gb/tMrslBbmMDtZDL3T3nEAywleSQ25ASQ3jIb7F5ELJjimqQrb/4oT F1VB5nYsyi3k6I3Mriro2+IaNOR8Gur3N2Y9N8dWKed7yBKGAzYFde7Qe9EXgbVEBaTj MytnP8QMzz/Uxl9KJamSspkG+2+Wyfvhr+85AQY4PRfXuNbqYwO57e7lCr0X4+X7VuaN J1v8YsMnUHqtoCZ9mCo/TIFTmXTnJU3Y3yc8gyQvlhZ5iSTPwfiJa/nzmLewWEVsmo6E EodKHDRHkkqgFYUUvimuAbvK6tWUTdCT2JxaGRWQXu9soP46haxruEUSSR20IoPzT+hp RqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=WeVIYzTD6xKPotQdTwspVnT9ShEBY+rnIQ8+tz6sd5g=; b=YVevA5iv5jtep9K4nz7AROarOzjvjAqktQkm5CcR3YBCx/TUGQGQCV86gkrGtOu+lk Pm1+1CyqZmusaPVvXT3VD/GWFq9CG+EWOmwOmn/aadpgtMwsJzKGMDII5Wl+9UnGS1CN 05yk3juFddlzEsYFFpJqgmocACkvjFnwMUDS5sVuE0v0CW/zW8VK2JXbf+2p1Za+LjIn BjuLm8xPY/pDcqD/NqAnQwqFEpdxg2T9iXB8b1YYSd0pmrzdZXh5NTg545irWcx37/X8 OkhGzUXSUJ6WAVda7Lwro+spAEmzWH1LTrDb8RzIFIUJZgqzrevGDT+cFsjXLjWSVJXF oPBg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d192-20020a6368c9000000b0039d6a62c9afsi4095065pgc.289.2022.04.12.14.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:13:49 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E23FEECC77; Tue, 12 Apr 2022 13:29:33 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346221AbiDKMxK (ORCPT + 99 others); Mon, 11 Apr 2022 08:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346216AbiDKMxF (ORCPT ); Mon, 11 Apr 2022 08:53:05 -0400 Received: from out199-6.us.a.mail.aliyun.com (out199-6.us.a.mail.aliyun.com [47.90.199.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5799233369; Mon, 11 Apr 2022 05:50:51 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0V9pCfav_1649681444; Received: from 30.225.24.83(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V9pCfav_1649681444) by smtp.aliyun-inc.com(127.0.0.1); Mon, 11 Apr 2022 20:50:46 +0800 Message-ID: <1225fb70-a785-9d4d-5532-28bfde8214f1@linux.alibaba.com> Date: Mon, 11 Apr 2022 20:50:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v8 05/20] cachefiles: implement on-demand read Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com References: <20220406075612.60298-6-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> <1091905.1649681074@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1091905.1649681074@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/11/22 8:44 PM, David Howells wrote: > Jeffle Xu wrote: > >> /* >> * Uninstall anon_fd to the cachefiles object, so that no further >> * associated requests will get enqueued. >> */ > > "Uninstall anon_fd from..."? Okay, will be fixed. > >> +static int init_read_req(struct cachefiles_req *req, void *private) > > Prefix with "cachefiles_" please (or "cachefiles_ondemand_"). Alright. Thanks for reviewing. -- Thanks, Jeffle