Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220409042321.3184493-1-james.hilliard1@gmail.com> <CAMeQTsanEow=zq=MuZLjMqpzybdS=5S0=JrkxuCdT7d5MxpEWQ@mail.gmail.com>
In-Reply-To: <CAMeQTsanEow=zq=MuZLjMqpzybdS=5S0=JrkxuCdT7d5MxpEWQ@mail.gmail.com>
From:   James Hilliard <james.hilliard1@gmail.com>
Date:   Sun, 10 Apr 2022 13:40:40 -0600
Message-ID: <CADvTj4rBKzGFch8iVzHu1s+6=P0PcLEwoFi74xd_ormEX+2rMA@mail.gmail.com>
Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer
To:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson
<patrik.r.jakobsson@gmail.com> wrote:
>
> On Sat, Apr 9, 2022 at 6:23 AM James Hilliard <james.hilliard1@gmail.com> wrote:
> >
> > Select the efi framebuffer if efi is enabled.
> >
> > This appears to be needed for video output to function correctly.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> Hi James,
> EFI_FB is its own driver and not needed by gma500 to drive its
> hardware. What makes you think it's required?

I wasn't getting any HDMI video output without it enabled for some reason,
I assume it is doing some sort of initialization needed by gma500
during startup.

>
> -Patrik
>
> > ---
> > Changes v2 -> v3:
> >   - select EFI_FB instead of depending on it
> > Changes v1 -> v2:
> >   - use depends instead of select
> > ---
> >  drivers/gpu/drm/gma500/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> > index 0cff20265f97..a422fa84d53b 100644
> > --- a/drivers/gpu/drm/gma500/Kconfig
> > +++ b/drivers/gpu/drm/gma500/Kconfig
> > @@ -2,11 +2,13 @@
> >  config DRM_GMA500
> >         tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
> >         depends on DRM && PCI && X86 && MMU
> > +       depends on FB
> >         select DRM_KMS_HELPER
> >         # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
> >         select ACPI_VIDEO if ACPI
> >         select BACKLIGHT_CLASS_DEVICE if ACPI
> >         select INPUT if ACPI
> > +       select FB_EFI if EFI
> >         help
> >           Say yes for an experimental 2D KMS framebuffer driver for the
> >           Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and
> > --
> > 2.25.1
> >