Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220409143950.2570186-1-zheyuma97@gmail.com> <18cb711a-de2a-69e3-d753-7012a67bf2a7@linux.intel.com>
In-Reply-To: <18cb711a-de2a-69e3-d753-7012a67bf2a7@linux.intel.com>
From:   Zheyu Ma <zheyuma97@gmail.com>
Date:   Tue, 12 Apr 2022 09:55:30 +0800
Message-ID: <CAMhUBjnQO1vtGWc-RjGUE0_PAN7RGp_J7VZbMim1DeTvukS4-Q@mail.gmail.com>
Subject: Re: [PATCH] ASoC: SOF: Intel: Check the bar size before remapping
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     lgirdwood@gmail.com, ranjani.sridharan@linux.intel.com,
        kai.vehmanen@linux.intel.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, peter.ujfalusi@linux.intel.com,
        alsa-devel@alsa-project.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        sound-open-firmware@alsa-project.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 12, 2022 at 12:23 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
>
> On 4/9/22 09:39, Zheyu Ma wrote:
> > The driver should use the pci_resource_len() to get the actual length of
> > pci bar, and compare it with the expect value. If the bar size is too
> > small (such as a broken device), the driver should return an error.
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---
> >  sound/soc/sof/intel/pci-tng.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-tng.c
> > index 6efef225973f..7d502cc3ca80 100644
> > --- a/sound/soc/sof/intel/pci-tng.c
> > +++ b/sound/soc/sof/intel/pci-tng.c
> > @@ -75,7 +75,11 @@ static int tangier_pci_probe(struct snd_sof_dev *sdev)
> >
> >       /* LPE base */
> >       base = pci_resource_start(pci, desc->resindex_lpe_base) - IRAM_OFFSET;
> > -     size = PCI_BAR_SIZE;
> > +     size = pci_resource_len(pci, desc->resindex_lpe_base);
> > +     if (size < PCI_BAR_SIZE) {
> > +             dev_err(sdev->dev, "error: I/O region is too small.\n");
> > +             return -ENODEV;
> > +     }
>
> May I ask how you found this issue?

Actually, I tested this driver via fuzzing in a simulated environment
and got a crash. Hence, I try to propose a patch and ask for the help
of maintainers to determine whether this is an issue.

Thanks,
Zheyu Ma