Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031378AbXECRfn (ORCPT ); Thu, 3 May 2007 13:35:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031385AbXECRfn (ORCPT ); Thu, 3 May 2007 13:35:43 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:1354 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031378AbXECRfm (ORCPT ); Thu, 3 May 2007 13:35:42 -0400 Date: Thu, 3 May 2007 19:33:33 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Michael Schmitz cc: Dmitry Torokhov , Geert Uytterhoeven , Linus Torvalds , Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Schmitz Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support. In-Reply-To: Message-ID: References: <20070501195052.390551603@mail.of.borg> <20070501195129.842338339@mail.of.borg> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 28 Hi, On Thu, 3 May 2007, Michael Schmitz wrote: > > > + for (i = 1; i < 0x72; i++) { > > > + atakbd_keycode[i] = i; > > > + set_bit(atakbd_keycode[i], atakbd_dev->keybit); > > > > It looks like this driver is not using standard input event codes. Actually it does, it just sort of works because Atari generates mostly AT keycodes. > > If > > Roman does not want to adjust keymaps on Amiga and Atari that should > > be handled in legacy keyboard driver (drivers/char/keyboard.c). As it > > is programs using /dev/input/eventX have no chance of working. I explained already at a earlier occasion, why this "generic" keycode thing is broken by design, which makes connecting multiple keyboards with different mappings impossible. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/