Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp822914pxb; Tue, 12 Apr 2022 14:26:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6kwhKXHSx61BmDYnXmEYL9U3Zn6HgYw2Vz9jl/DQ6qA4DeqRL6P69TtktpxLkNiuzIaNb X-Received: by 2002:a17:903:3014:b0:158:921b:6ebe with SMTP id o20-20020a170903301400b00158921b6ebemr3183830pla.164.1649798810753; Tue, 12 Apr 2022 14:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649798810; cv=none; d=google.com; s=arc-20160816; b=TuzzGKOUMQFuR8jB2BEIi9uWWFurK/0LOEJieW2LKdu3Wv4WH7DlnFeG6PX9/9nzCL hdf0F5XOlON973C3xwnOMcTsGdVGhNgsNenDOzXKW9KjepPDzbqmik1NvU0jRJlwhfQM tzXUH5MrLpZXbkYMeip8j4W1QZ9NODQBYpWoV/hvVt0BE6TMj3wmA43e9UimREWya/vJ mzwtxeUnSa6GonG3Gy9FtfDorbHXWEn2AqfnrzNZZi4di9OY5D04rSCAVnDqHJFOxo3N ZxRcv80OvRfCbczfZfgbCKpVVg/UxQ5JXjNkPi1cuGa4h+2Zpeq9MjsUoOZ6xyvSpGBa 6ZFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zkxbdNQTj0ENKZ5Y7USEw9lpoUYO+JKNGFZ1diCYG7g=; b=JVFedVz4gHohAqlgERYeh6GVZ3vdrZ3gLOqM8oBt/RdxPfRaOwyJGp4j6V/uH5kHUf aycEmWXpTVvStzepsKJCa5bver6MjU+2YuG2kdFAvUx9Z0RXYhi6RxuuDHHpSDYZ8vMV JWBX+eQUUSQHyjOvfApAVmiuWF0djOrt698G2nUJqA4m/BlVrtVdhkKMtau12PnMHVxw 8i6dtHSiFTaoY7xcrh5Uh0nCfXb95lSidPxgSS0UDLBDTPgC8B9E0i8PPjKE1UVS1942 /4cHXelMQYPxMzJhxzenNmCYGjEA4VX1gak4KjjS+JhPxi1eQlMs/LIrYiLmANKbromo ilmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SgmUUsYF; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o11-20020a170902d4cb00b00153b2d16519si12810639plg.289.2022.04.12.14.26.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:26:50 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SgmUUsYF; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F280A10818F; Tue, 12 Apr 2022 13:37:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234626AbiDLIaz (ORCPT + 99 others); Tue, 12 Apr 2022 04:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353578AbiDLHZr (ORCPT ); Tue, 12 Apr 2022 03:25:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AD5943AE1; Tue, 12 Apr 2022 00:01:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA45A60B65; Tue, 12 Apr 2022 07:01:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2405C385A6; Tue, 12 Apr 2022 07:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649746902; bh=QglxR7xqTgao+Mu3n8Nk9NbuD0NuJMjSZJ6+4whERrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SgmUUsYFYvtj7UhkAocoIlYuYtR9Pbcrz2fx5CX3B/RylFibsq5XIJ0tMJBe0G5FE dhK+E25BVnBo7SH2iUQtS3OB6bRM7XZ36wb/jGiz8IJYnx8Jh2aHntfEryHzeEDk3T b/Ffc6TTbEry41VxFvNe9R0Fw1Y0Wgp7X5b6hldQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH 5.16 172/285] regulator: rtq2134: Fix missing active_discharge_on setting Date: Tue, 12 Apr 2022 08:30:29 +0200 Message-Id: <20220412062948.632207227@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 17049bf9de55a42ee96fd34520aff8a484677675 ] The active_discharge_on setting was missed, so output discharge resistor is always disabled. Fix it. Fixes: 0555d41497de ("regulator: rtq2134: Add support for Richtek RTQ2134 SubPMIC") Signed-off-by: Axel Lin Link: https://lore.kernel.org/r/20220404022514.449231-1-axel.lin@ingics.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/rtq2134-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/rtq2134-regulator.c b/drivers/regulator/rtq2134-regulator.c index f21e3f8b21f2..8e13dea354a2 100644 --- a/drivers/regulator/rtq2134-regulator.c +++ b/drivers/regulator/rtq2134-regulator.c @@ -285,6 +285,7 @@ static const unsigned int rtq2134_buck_ramp_delay_table[] = { .enable_mask = RTQ2134_VOUTEN_MASK, \ .active_discharge_reg = RTQ2134_REG_BUCK##_id##_CFG0, \ .active_discharge_mask = RTQ2134_ACTDISCHG_MASK, \ + .active_discharge_on = RTQ2134_ACTDISCHG_MASK, \ .ramp_reg = RTQ2134_REG_BUCK##_id##_RSPCFG, \ .ramp_mask = RTQ2134_RSPUP_MASK, \ .ramp_delay_table = rtq2134_buck_ramp_delay_table, \ -- 2.35.1