Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 11 Apr 2022 15:09:10 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 22/34] drm/i915/gvt: devirtualize dma_pin_guest_page
Message-ID: <20220411180910.GX2120790@nvidia.com>
References: <20220411141403.86980-1-hch@lst.de>
 <20220411141403.86980-23-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220411141403.86980-23-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RYBVNJIAjgIkNQB8jkB6q8wkczYB4ZXBQlm30qgBjSnBSpRpow/R9yy6zJyH?=
 =?us-ascii?Q?x3KVoQXz+UhlCn8ADXyueY5kb0iXUBTcFU3z+EhyfXuFUI5SNlJNjMOMwqJS?=
 =?us-ascii?Q?8VgcttaftE0qsWy6eGbfSjkYlrPRu5JnEZNDW13vivrVw6Eg1VbOpDUC7w07?=
 =?us-ascii?Q?6Q3peQ2EyOjbl3JiI6dJi1lfiKD/as7v7C6TXXxtsuEihoX61gi4nU2LqbKn?=
 =?us-ascii?Q?UdIEI1Q0ScM9F005A66sQ0hBUYt+EDOLmopsvHTHKj8ZNwOWf8kLz4HUAcHB?=
 =?us-ascii?Q?GsTQyAtk2c2n27eIWbokBrYxA7gv6xQzNB5u43G4ZdhiUgeaTwhSpKC+dYLK?=
 =?us-ascii?Q?aHfa4SWVnPp1gXkEv19eRX00+7dTQsF9cd9ejEUuc9kgrcsf5aHdY9fjHOuX?=
 =?us-ascii?Q?1DKR0/2IfB6a2MXBYFUhoGu6XvTCwnq2BZIpujrDuPN/Urxh4AZrcH3wp78t?=
 =?us-ascii?Q?xouwIMO7x9wXAmjDsMHuCHa7NeJJHpaVKDxqBGtRaQaQhvMr5PikqT2BHV1v?=
 =?us-ascii?Q?xacyOsFZC7ANEPtZzQ7suc6PxWnGIDMFp9rWo1IQNAhlU4aBnEVMIJvvkmHE?=
 =?us-ascii?Q?cNbEqe3zZtLpJSr8/cWKAhga7SblU8k0go/SDJtLDDrXXGxcn842fTGOVoMo?=
 =?us-ascii?Q?V7Yp5r1S1MyPRucTWTR+8rQWbuMJEcZCl17mXCisRHjmcTbwsX4E0/3N3Z9e?=
 =?us-ascii?Q?76AJbTI24bt3TFVMP9GbeqqkzW3tMJYqLSkG0yBRydRkmr8o4cMuQUTH97NM?=
 =?us-ascii?Q?YfPH9LhXAxgEcgGZzQVuyf10AJH1z8O69xyGJBZfSOvf4uBLT5wMiFBwOtyD?=
 =?us-ascii?Q?Y+2X1avnxwDJqxbLlFkZONoItC177oJUKs2NSssxP0oy49v2D3Pd8NhAgykl?=
 =?us-ascii?Q?GYyCDOOxm8FTBM9SDN0iQwena39c5TOML3Onv+Rr0klmRnNERXO9c0efl198?=
 =?us-ascii?Q?cJa8CaqPrtW4Op6GA89l8pTpKUViHNwWkcDXS2XRpKEQLwKCBTA2vJYBcDSF?=
 =?us-ascii?Q?eP/Gp2izjIgvzoFilCtFuRGX5GmMhkCg7ps7Otgujvys8H/aKzhThz02/Owi?=
 =?us-ascii?Q?/7BvmOPiNnn/IOOhBPH6zYp/aCnynSeamRlxGQ9QcvwXTzZcxuZY6QXH9BA0?=
 =?us-ascii?Q?KArNBzSp7XmigWAHo4pB0Cg0gHbmjv5R9OrtTtkVVW2BcxjVkCW8JOnJEbTz?=
 =?us-ascii?Q?CHL+kS3fdEmFSKgu1ghOvBJ7DAB4rDxpGq7SzjGz//heonRoycsd2tBrBC3t?=
 =?us-ascii?Q?jdDBVXc3hthDeTAg2KfMMfUF41DE1tSq18/rVZyD9albF/J6SjUL8KBvCV8H?=
 =?us-ascii?Q?ZyoctKu6sB64s1GdE+0ptOOIAGxPSGi8b49ZTQEFdCwYoEp+zlzXBpCvejVi?=
 =?us-ascii?Q?NJ+kuxEms2X/eG8PTELBf78W+BcvCB5oFZ2uWm6nqnxWu+ZInG3/1t/LGz00?=
 =?us-ascii?Q?JqWnbIgvEMYOqCkuEStKGAJBxlqu/hTenyFKf2/EMLZ+WWscUQlhwV/X2fIl?=
 =?us-ascii?Q?Bs7Qd46jzt/X9+6q7Mwl2c2wcBbO/1a7IKGKClohdz8BZ4h84r8CcQNKXe5r?=
 =?us-ascii?Q?wO8aiFt5StrcGuXLZ5WVWJiQHC02/ENGRJXLsyLEKaimeNtsxiPH3nJRiRLk?=
 =?us-ascii?Q?LcpC2NOun8A//EVAF6V3LOmCGvzAU2ZDoPxYTCP5Qhe6IM7A7Eym7AS1NFmz?=
 =?us-ascii?Q?gmtGZpaIvri1KbQCNx7/rzHW/JGyc2PsOdiCsbRdyHQLjSYT4v3eJ9wI/k4S?=
 =?us-ascii?Q?Bwr0IGO4fw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af949e3c-f909-4a5f-23b4-08da1be6615d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 18:09:11.9236
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 28KZymQzn1Eu0USA/5tipk4/PnkQbZyw5ruPzfskw3+hkr5g/pXIqQRaOd6IMS+A
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3893
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 11, 2022 at 04:13:51PM +0200, Christoph Hellwig wrote:
> Just call the function directly and remove a pointless wrapper.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/gpu/drm/i915/gvt/dmabuf.c    | 14 +-------------
>  drivers/gpu/drm/i915/gvt/gvt.h       |  1 +
>  drivers/gpu/drm/i915/gvt/hypercall.h |  2 --
>  drivers/gpu/drm/i915/gvt/kvmgt.c     |  4 +---
>  drivers/gpu/drm/i915/gvt/mpt.h       | 15 ---------------
>  5 files changed, 3 insertions(+), 33 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason