Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   <ggiraudon@prism19.com>
To:     "'Neil Armstrong'" <narmstrong@baylibre.com>,
        <kernel-dev@prism19.com>
Cc:     "'Rob Herring'" <robh+dt@kernel.org>,
        "'Krzysztof Kozlowski'" <krzk+dt@kernel.org>,
        "'Kevin Hilman'" <khilman@baylibre.com>,
        "'Jerome Brunet'" <jbrunet@baylibre.com>,
        "'Martin Blumenstingl'" <martin.blumenstingl@googlemail.com>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20220411140401.450-1-ggiraudon@prism19.com> <8bde8ee2-ee3f-bba6-66da-28adb3897178@baylibre.com>
In-Reply-To: <8bde8ee2-ee3f-bba6-66da-28adb3897178@baylibre.com>
Subject: RE: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1
Date:   Mon, 11 Apr 2022 10:22:17 -0400
Message-ID: <001401d84daf$8d001cc0$a7005640$@prism19.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-ca
Thread-Index: AQFrGI7YFugmhoni/8+f7eNP0fB8BAOIHqkvrajs4iA=
Precedence: bulk

Will do. Thanks Neil.

G

-----Original Message-----
From: Neil Armstrong <narmstrong@baylibre.com>=20
Sent: April 11, 2022 10:21 AM
To: Guillaume Giraudon <ggiraudon@prism19.com>; kernel-dev@prism19.com
Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski =
<krzk+dt@kernel.org>; Kevin Hilman <khilman@baylibre.com>; Jerome Brunet =
<jbrunet@baylibre.com>; Martin Blumenstingl =
<martin.blumenstingl@googlemail.com>; devicetree@vger.kernel.org; =
linux-arm-kernel@lists.infradead.org; linux-amlogic@lists.infradead.org; =
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: meson-sm1-bananapi-m5: fix wrong =
GPIO pin labeling for CON1

Hi,

On 11/04/2022 16:04, Guillaume Giraudon wrote:
> The labels for lines 61 through 84 on the periphs-banks were offset by =
2.
> Realigned them to match the Banana Pi M5 schematics.
>=20
> Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5=20
> board dts")
>=20
> Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com>
> ---
>   arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts=20
> b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> index 5751c48620ed..754c3d43ef0b 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> @@ -448,7 +448,7 @@
>   		"",
>   		/* GPIOA */
>   		"", "", "", "", "", "", "", "",
> -		"", "", "", "", "", "",
> +		"", "", "", "", "", "", "", "",
>   		"CON1-P27", /* GPIOA_14 */
>   		"CON1-P28", /* GPIOA_15 */
>   		/* GPIOX */

While reviewing more closely I figured that in fact the issue comes from =
the :
		/* BOOT */
		"eMMC_D0", /* BOOT_0 */
		"eMMC_D1", /* BOOT_1 */
		"eMMC_D2", /* BOOT_2 */
		"eMMC_D3", /* BOOT_3 */
		"eMMC_D4", /* BOOT_4 */
		"eMMC_D5", /* BOOT_5 */
		"eMMC_D6", /* BOOT_6 */
		"eMMC_D7", /* BOOT_7 */
		"eMMC_CLK", /* BOOT_8 */
		"",
		"eMMC_CMD", /* BOOT_10 */
		"",
		"eMMC_RST#", /* BOOT_12 */
		"eMMC_DS", /* BOOT_13 */
		/* GPIOC */


it contains 14 entries, but there is 16 BOOT gpio lines.

So instead, send a V2 with 2 entries added in BOOT and leave the GPIOA =
entries as-is.

Thanks,
Neil