Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Miaoqian Lin <linmq006@gmail.com>,
        Song Qiang <songqiang1304521@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Ivan Drobyshevskyi <drobyshevskyi@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: proximity: Fix return value check of
 wait_for_completion_timeout
Thread-Topic: [PATCH] iio: proximity: Fix return value check of
 wait_for_completion_timeout
Thread-Index: AQHYThl99NRYKGRf3UqRiCXMHbklwqzrzqNQgAAAY5A=
Date:   Tue, 12 Apr 2022 06:23:45 +0000
Message-ID: <PH0PR03MB6786F62DE142E3E2C66C937F99ED9@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220412030022.20249-1-linmq006@gmail.com>
 <PH0PR03MB67863270EC86D06606F1E44E99ED9@PH0PR03MB6786.namprd03.prod.outlook.com>
In-Reply-To: <PH0PR03MB67863270EC86D06606F1E44E99ED9@PH0PR03MB6786.namprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ujO2Y7s5w9RUu/+++txcxCFrzGe0GWI8Yjm3fcCH/GGDJDMOZhOPORfwuu?=
 =?iso-8859-1?Q?YWMrdn35e655d7qRtvN0X2XbYMqXwmGqea6/Elp7wNPB5299hAmyJGrhkS?=
 =?iso-8859-1?Q?QSkRSBkWxZEnQ7AsVysL0cWanOjWB/6tQujZcZseb08HAglHSBKfLSD4mo?=
 =?iso-8859-1?Q?mvVnkRIIGfwyK1s/VuUqfBzcbcvzYpTH3XZYFMAyLzOLUOx0jJHVCV15wr?=
 =?iso-8859-1?Q?vjja2hLMWOAHdlVIt1FeY3RT8o9Gu8inF/DpU3IjCb1Gilh0Jfio6cxoIU?=
 =?iso-8859-1?Q?9UcsOJhbZ8HfDH14bPqKz4G0TV77Dir09D4Q5Vr+31cqd5fiwxVpNH50to?=
 =?iso-8859-1?Q?haoYu4xKAyC7N2Tv4F0u8RgA7UwS4owDs/8EpgyhjjmH+5VETdsCk36dks?=
 =?iso-8859-1?Q?TKZYIUg1JDopf0cEz71xUUu5E+OqoXTjsvbBpwtJM1fsAzcoKE/y2SkZTI?=
 =?iso-8859-1?Q?P9JZ/GCOjdLYSlNE5WNZhM6eRjjpQ1DjrC55jBPKLEErG7iYcItxwuZ6O/?=
 =?iso-8859-1?Q?D79llwGMzxCzkUBSw/BMSRArsol4/BqnyEH4tYUszCwU6+yw37ADjsirmO?=
 =?iso-8859-1?Q?YswVIVg2vyanedDycaOeI7Gr8G91CicewYJg+a1pa8aOuIDQle2lvUcjz3?=
 =?iso-8859-1?Q?PntD/P1SPx58PKisy1htioZoSr1MB/wtfTotdMl95wVR4LYQV4YdCVgwwB?=
 =?iso-8859-1?Q?H2hFiKhz3g2ouImSFIpgUVxuENjau0IX7Kb8X4wP7eArG8v8JbMApGLK1Z?=
 =?iso-8859-1?Q?t4MzbQpfrF+EvawiGv6FJVXh2zbgFUgLbUR9DP1gk5sml+dM8IHLsCRks7?=
 =?iso-8859-1?Q?jPHWya6pJjcOIbxVFk93yz2QORWe3+ueet9Fi+GWXOHl0NOtlg8CbeBZ6g?=
 =?iso-8859-1?Q?iXw7xRkip49isolErRQUOcMMv0Y+4nnUetb++E1mmShya/jXN6ggYcJXBv?=
 =?iso-8859-1?Q?UvPMOouya/Y4ZjLM8tzffkpmataGMnOC+tNKVysHsOJh9kYXk6M1X0DfGV?=
 =?iso-8859-1?Q?j4VoRGZqqzAZ7Y4i3tsCGfpXc1qUMYrDzijzbV9HDQpj42n+I1qDZBT+fa?=
 =?iso-8859-1?Q?2LExWgT+rOMtrqKr0y4cjJ11EYwoaci6h1v3moHPL83fspGeq6xDAceuSK?=
 =?iso-8859-1?Q?W1JATg+OYdNZWTO6r3bgxc5sf4YBs0hg4N4cpc8DtLTTrzGBsKoO1hZGUY?=
 =?iso-8859-1?Q?6hDLUY5pINVKFrQWtXNLWN0r43tegFO8vHtNE7YzMx3YYSVugfnCsqlSJr?=
 =?iso-8859-1?Q?AtL43m9FfBJJZvkiqw87cGQnmhgXtvHEKwznw3JMZ+Jj+xr2sBZ2831X6Y?=
 =?iso-8859-1?Q?SjL7TqvvkBcVyANPnrfGSBxpixKP7XK+jLBHqEBaxuitsLl3ySCUIVch3y?=
 =?iso-8859-1?Q?jRZtFKVmFTGERLBYNu4B4Ip+mpxEewKjeKBjOssFnxNyr/Hw7K47fU1UWD?=
 =?iso-8859-1?Q?2CEY0YgBsLAbf/8Vk3rebRR2GZzxz7785lvvZIF0ObL6GxKcfjiAe8neuu?=
 =?iso-8859-1?Q?2ddcxYu+wjOlzG8qqmBDwCO1lHbKWfeQOQCufgYHrcB34lWBY4zf9d38Mr?=
 =?iso-8859-1?Q?Oct1jz7PtxGmC47hA+FEqlOTje38IPpxDBCWf8BzeAshW5DiIZ+3eyCBL5?=
 =?iso-8859-1?Q?BKJ5BRG9ps4icnWlhU0RDU1KFiJiry0LdTHWJ2x8GDoTYjY24/kWyPDisJ?=
 =?iso-8859-1?Q?5B5G5hvuoUKQ43UlnoJ/7jwY1yC4756p2LazkPn5L35DcD9U8Bt4BUe6X/?=
 =?iso-8859-1?Q?mVy7Z80S3uzjxo/JhldIGwAtjyk278SjsO+zNX6YQ/R+/lfGtTA1hcI64p?=
 =?iso-8859-1?Q?9q2fTf+mw7rJv5WEhwqHfW81SNzX6q242+DDSsLgJflEpx9d65AxJw78oY?=
 =?iso-8859-1?Q?In?=
x-ms-exchange-antispam-messagedata-1: wpVJwCV/lSyc6A==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e98d5c5-a58f-42e1-345b-08da1c4cffbd
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 06:23:45.9247
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AveX4dCCaxNGJsB1bztsn+DOTJ8KugS9n0eUPgyzHWifj/2SX93pnIQbxSgjQ8x2+tDIsh0o6eBxiLpqF+gIkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4668
X-Proofpoint-GUID: i9wThgiqQAeUGRok-iGLgu_7DukyGY4-
X-Proofpoint-ORIG-GUID: i9wThgiqQAeUGRok-iGLgu_7DukyGY4-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-04-12_02,2022-04-11_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 phishscore=0 mlxscore=0 priorityscore=1501 adultscore=0 clxscore=1015
 mlxlogscore=887 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204120029
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Sa, Nuno
> Sent: Tuesday, April 12, 2022 8:21 AM
> To: Miaoqian Lin <linmq006@gmail.com>; Song Qiang
> <songqiang1304521@gmail.com>; Jonathan Cameron
> <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Ivan
> Drobyshevskyi <drobyshevskyi@gmail.com>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] iio: proximity: Fix return value check of
> wait_for_completion_timeout
>=20
>=20
>=20
> > -----Original Message-----
> > From: Miaoqian Lin <linmq006@gmail.com>
> > Sent: Tuesday, April 12, 2022 5:00 AM
> > To: Song Qiang <songqiang1304521@gmail.com>; Jonathan Cameron
> > <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Ivan
> > Drobyshevskyi <drobyshevskyi@gmail.com>; linux-
> > iio@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: linmq006@gmail.com
> > Subject: [PATCH] iio: proximity: Fix return value check of
> > wait_for_completion_timeout
> >
> > [External]
> >
> > wait_for_completion_timeout() returns unsigned long not int.
> > It returns 0 if timed out, and positive if completed.
> > The check for <=3D 0 is ambiguous and should be =3D=3D 0 here
> > indicating timeout which is the only error case.
> >
> > Fixes: 3cef2e31b54b ("iio: proximity: vl53l0x: Add IRQ support")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
>=20
> Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>

Hi Lin,

Just one note regarding the patch subject. You should indicate
to which driver this patch applies "iio: proximity: vl53l0x: ..."

- Nuno S=E1