Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767741AbXECTRk (ORCPT ); Thu, 3 May 2007 15:17:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767742AbXECTRj (ORCPT ); Thu, 3 May 2007 15:17:39 -0400 Received: from wr-out-0506.google.com ([64.233.184.227]:47135 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767741AbXECTRi (ORCPT ); Thu, 3 May 2007 15:17:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WbaF6K8Czk9PLoYO7VbB7uAozgW3+c6bvMlIJv8csaLR3Ed82MniULSM+AGknCZANipNViKshYiCBKlqv3xdsG4yswAXLCZQW9RlKAdJbYnV7RtfHOclJl8uXPsluFVLhOP9yL6v1ALLmc789epZ3N4kpzjCxm+oHB0FEqZcEVU= Message-ID: Date: Thu, 3 May 2007 15:17:32 -0400 From: "Dmitry Torokhov" To: "Roman Zippel" Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support. Cc: "Michael Schmitz" , "Geert Uytterhoeven" , "Linus Torvalds" , "Andrew Morton" , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, "Michael Schmitz" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070501195052.390551603@mail.of.borg> <20070501195129.842338339@mail.of.borg> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2043 Lines: 55 Hi Roman, On 5/3/07, Roman Zippel wrote: > Hi, > > On Thu, 3 May 2007, Michael Schmitz wrote: > > > > > + for (i = 1; i < 0x72; i++) { > > > > + atakbd_keycode[i] = i; > > > > + set_bit(atakbd_keycode[i], atakbd_dev->keybit); > > > > > > It looks like this driver is not using standard input event codes. > > Actually it does, it just sort of works because Atari generates mostly > AT keycodes. > But not the input core codes, does it? > > > If > > > Roman does not want to adjust keymaps on Amiga and Atari that should > > > be handled in legacy keyboard driver (drivers/char/keyboard.c). As it > > > is programs using /dev/input/eventX have no chance of working. > > I explained already at a earlier occasion, why this "generic" keycode > thing is broken by design, which makes connecting multiple keyboards with > different mappings impossible. > No, I don't think so. Your points were: 1) You did not want to adjust your legacy keymap on Amiga 2) You want userspace programs to know how to program scancodes for every type of keyboard and have different keymaps for different type of keyboards (So you need to have n_kbd_types * n_international_mappings keymaps). Answering 1) I sent you once a patch for review that would have amikbd send raw scancode events in additional to standard input events and drivers/char/keyboard.c pick these raw events on amiga so both legacy driver and evdev could work, but I never heard from you. As far as 2) goes I think it is better to have unified keyboard map across different types of keyboards and then overlay internatinalization/other settings. And you still have per-keyboard configurability as you can change scancode->keycode mapping on a per-device basis via evdev ioctl. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/