Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp7595lfv; Tue, 12 Apr 2022 15:04:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3ax+eQg13ppR7eEnF6P75WaMy9v/hdXSXcZ4YPSawHEeOloBVk1HEXzv1RnYfEHQvDtru X-Received: by 2002:a05:6a00:1a01:b0:505:b3e5:b5fc with SMTP id g1-20020a056a001a0100b00505b3e5b5fcmr14677312pfv.53.1649801047721; Tue, 12 Apr 2022 15:04:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649801047; cv=none; d=google.com; s=arc-20160816; b=WmCljF1hpLI/57wzmCOpME5sqs1JDdoIK+QtYgp6YEiTrYLvuDZJH6FVUiWI5drGtg DxliZMJFbgFXPWscUzfs6fs4039cWEcDXrtxhsbWVhUoRNJEsRR5XXqcfTG5WwFi5ZSx bOXChkS/m3id222nIJIR3J2qMc1MZ1d4wzuYvZeLl+Bz4Kg1IkYOjEdDcL4xH7VyOqFq S8Z3+wR6lEI2ja+lv91AKYf1X3OVszDeMYZDhY48aqQOyoGo7GmLQJyVxAw9ol56LHy1 oe4ezjxn2zfMwT/47VADqFO2UBlh7RMKlO1ZCtCsjUewjuXAQ0aFN5VDPakox6vt+Mfe bmsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FizDWakq14YE0/VcmvfEY0PLJpTngbgHqpmgDu0u9Vg=; b=hQy+ZvlKRMqIrsfJmnFXxUkDozolLXO0kQ18Gh/IH/GziRS7/SWE9hUe0DjRQw1Svy aRr23D1w+6gH/uKth50Mror5n67/TMZIk8C2ogK6vRemB233ieBX4cMNG/C9IVc56EJt BIZlDvufCyKeDYbrXJ6iVjBjhtY7/hHuV6wxYjeTlKGe1rYe3zLBtSI839l5BoMqtOrG /z39LAK+d7/DAZOSGv00KN/ICmMKppQB8AiJqn9V4GZiCMoWy6JKTIw5wmhfPcvhcpH8 3IGUtOJN4Ea8bOlEN1yttVI0O76L9W1hneMqrVItg1GvzrYiX+YiRC/4Hi1TK6C4LYZ4 LOYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I0aSQznA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h18-20020a170902f55200b00153c3f96abesi13590933plf.137.2022.04.12.15.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:04:07 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I0aSQznA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3F4FC15407E; Tue, 12 Apr 2022 13:55:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383959AbiDLIio (ORCPT + 99 others); Tue, 12 Apr 2022 04:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357105AbiDLHjr (ORCPT ); Tue, 12 Apr 2022 03:39:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE065DEB4; Tue, 12 Apr 2022 00:12:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93ADBB81A8F; Tue, 12 Apr 2022 07:12:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1FC3C385A1; Tue, 12 Apr 2022 07:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747532; bh=RVCl0QueOUEdBG+WdafdDuCg8pAcvRppNDasLe0JeiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I0aSQznAjyslXpfuDE0ybt9nm6oYgXMZa/ZAQCJd4aQv3k7rqn0lM6Ulx+su7C/wy XPrOPuDswcL3AX0kUg5w7BTdfGhTppcfJ+2D/bnRkP6utik/pHg8YtePWw9YFhoOoI pT8Is2NSr9vwegP/AVXDNP069FGt1mj040LjXf2w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jack Wang , Damien Le Moal , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.17 106/343] scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() Date: Tue, 12 Apr 2022 08:28:44 +0200 Message-Id: <20220412062954.155454566@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062951.095765152@linuxfoundation.org> References: <20220412062951.095765152@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Damien Le Moal [ Upstream commit f792a3629f4c4aa4c3703d66b43ce1edcc3ec09a ] In pm8001_chip_fw_flash_update_build(), if pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex allocated must be freed. Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com Reviewed-by: Jack Wang Signed-off-by: Damien Le Moal Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index ccc7f53ddbd6..27ead825c2bb 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4880,8 +4880,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, ccb->ccb_tag = tag; rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info, tag); - if (rc) + if (rc) { + kfree(fw_control_context); pm8001_tag_free(pm8001_ha, tag); + } return rc; } -- 2.35.1