Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp12596lfv; Tue, 12 Apr 2022 15:15:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoKI/GNLVfFtnSrUgOL8vv7Ilbd612bgbnUI9MrZ2O36I/j1RHOsoM+t5OqViAxbZpqsfF X-Received: by 2002:a63:a902:0:b0:398:cdd3:f85e with SMTP id u2-20020a63a902000000b00398cdd3f85emr32462557pge.122.1649801704108; Tue, 12 Apr 2022 15:15:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649801704; cv=none; d=google.com; s=arc-20160816; b=i4/c8DDX/eu1nV+NuARNZ5xx6iCn54k9xiBX0N6pstYsyQhaPx/8ddkB6KXTYUnGCE a2xgfdl37E5bh/+bSWY2+qjAqQB26xQM9XOJlKXC9GoHZo1kmgz1ANumUicrdqh3I6r/ av2r87bCB9A57k7evp8jqciC1aofkUkKtHu0CqwKd9ebfWywcQLwDFPLd/Z/TTs7hl2t 7kxdWHNOUZ85behCrcA67p3Qy0r5xkS9l7NXi8Pp/gB8/qLkmu7qhUa1G/75XRbsCxxe 0x5BU7oUFTKSagtoTNR+NBzMCONKhOdwNr76R5kAftGaX1WtwYem2eAscdK/MQuaNIrH ONUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=XqTuJ+0CQa1rTSsMxpdNx2yZyyG8cpfDZeya3NpHn30=; b=muZnoWuybKMiZ/QkMl74RAo4dF5L5K70AdgC2I58+gATI+TS+SLl+xrEgF8y7/YsaE 3xWwzc1vb1Hd3jy5QKcroufGQ9CZoAqhhnZmB+3qKiJkIjKYDQlp6dJc4hcYw4kx5eKx xHYWJHWt8u/w7E42oOI3r5ZU0LxMWzq9ro+lodlD5+/bu+2bd07bYspBu/BD3hGraZ3P aHTyn0y3ioJx0G744NuQnrz4FWzZY8gGICBvmxcdP8KDRsfL3W3VWTPUVBj42Tle1OJ1 zZ5rmIlBcFM1QYJI4ihXHY5JLYHOzdG7weg5SNk8PVW1i5uRQfKCm1H+eU0g5imjGB/n wqmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UjIJzPKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d17-20020a634f11000000b003816043f0adsi3660046pgb.674.2022.04.12.15.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:15:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UjIJzPKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0144E41FAA; Tue, 12 Apr 2022 13:56:50 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358539AbiDLRlL (ORCPT + 99 others); Tue, 12 Apr 2022 13:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356075AbiDLRkm (ORCPT ); Tue, 12 Apr 2022 13:40:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2576212D; Tue, 12 Apr 2022 10:38:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 76E26619D7; Tue, 12 Apr 2022 17:38:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DAA5C385A1; Tue, 12 Apr 2022 17:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649785103; bh=3LtPJpBag3FhKWTyd+lv8UDX78WC5GQyaw42g+nIqes=; h=From:To:In-Reply-To:References:Subject:Date:From; b=UjIJzPKAWvTCCDrcA4R3ttd9UxR9RuVChvAK6SmbrP2BngxvpQeiEzvpyAXU58NqG XOlE43X2n9QAo9TjXzXSgYj0JQxPVK0K9z1zB6rsKNtIS2I9ES9N6kk7pq1cp828Zu KH2lfWe1NyJH4hyJCaqaZ1GnX22l3pmDQOszT03WhZN1JsWR0mWVirK+6YbkRzggwC sKCzNpu+ZQWUoLOLKEPyTVIXIokdKMsHrHknLu7TOwa1YTAaaUNWg4x6yx41q6Yjkx 0jL3QVaJSxe0yIysga/YEFhNPsKDwlNprAm0952JWNro561CN1LZXK19fA7AXB7YYD XG4oAXW9TgLbw== From: Mark Brown To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linmq006@gmail.com, vigneshr@ti.com In-Reply-To: <20220411111034.24447-1-linmq006@gmail.com> References: <20220411111034.24447-1-linmq006@gmail.com> Subject: Re: [PATCH] spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout Message-Id: <164978510277.404853.11478015977958567610.b4-ty@kernel.org> Date: Tue, 12 Apr 2022 18:38:22 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Apr 2022 11:10:33 +0000, Miaoqian Lin wrote: > wait_for_completion_timeout() returns unsigned long not int. > It returns 0 if timed out, and positive if completed. > The check for <= 0 is ambiguous and should be == 0 here > indicating timeout which is the only error case. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout commit: 8b1ea69a63eb62f97cef63e6d816b64ed84e8760 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark