Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4dc6a76b-cdb4-e43e-cd04-4d77f9133ddf@roeck-us.net>
Date:   Tue, 12 Apr 2022 07:18:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] watchdog: rti-wdt: Fix pm_runtime_get_sync() error
 checking
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Tero Kristo <t-kristo@ti.com>, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220412070824.23708-1-linmq006@gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20220412070824.23708-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/12/22 00:08, Miaoqian Lin wrote:
> If the device is already in a runtime PM enabled state
> pm_runtime_get_sync() will return 1, so a test for negative
> value should be used to check for errors.
> 
> Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/rti_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c
> index db843f825860..00ebeffc674f 100644
> --- a/drivers/watchdog/rti_wdt.c
> +++ b/drivers/watchdog/rti_wdt.c
> @@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)
>   
>   	pm_runtime_enable(dev);
>   	ret = pm_runtime_get_sync(dev);
> -	if (ret) {
> +	if (ret < 0) {
>   		pm_runtime_put_noidle(dev);
>   		pm_runtime_disable(&pdev->dev);
>   		return dev_err_probe(dev, ret, "runtime pm failed\n");