Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 11 Apr 2022 20:50:42 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Christoph Hellwig <hch@infradead.org>,
        Dave Chinner <dchinner@redhat.com>, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: update IOMAP FILESYSTEM LIBRARY and XFS
 FILESYSTEM
Message-ID: <20220412035042.GC16799@magnolia>
References: <1649733686-6128-1-git-send-email-yangtiezhu@loongson.cn>
 <20220412033917.GB16799@magnolia>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220412033917.GB16799@magnolia>
Precedence: bulk

On Mon, Apr 11, 2022 at 08:39:17PM -0700, Darrick J. Wong wrote:
> On Tue, Apr 12, 2022 at 11:21:26AM +0800, Tiezhu Yang wrote:
> > Remove the following section entries of IOMAP FILESYSTEM LIBRARY:
> > 
> > M:	linux-xfs@vger.kernel.org
> > M:	linux-fsdevel@vger.kernel.org
> > 
> > Remove the following section entry of XFS FILESYSTEM:
> > 
> > M:	linux-xfs@vger.kernel.org
> > 
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> 
> WTF?
> 
>  ▄▄   ▄   ▄▄   ▄    ▄
>  █▀▄  █   ██   █  ▄▀
>  █ █▄ █  █  █  █▄█
>  █  █ █  █▄▄█  █  █▄
>  █   ██ █    █ █   ▀▄

*OH*, I see, you're getting rid of the M(ail): entry, probably because
it's redundant with L(ist): or something??  Still... why does it matter?

Seriously, changelogs need to say /why/ they're changing something, not
simply restate what's already in the diff.

--D

> 
> --D
> 
> > ---
> >  MAINTAINERS | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 61d9f11..726608f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10238,8 +10238,6 @@ F:	drivers/net/ethernet/sgi/ioc3-eth.c
> >  IOMAP FILESYSTEM LIBRARY
> >  M:	Christoph Hellwig <hch@infradead.org>
> >  M:	Darrick J. Wong <djwong@kernel.org>
> > -M:	linux-xfs@vger.kernel.org
> > -M:	linux-fsdevel@vger.kernel.org
> >  L:	linux-xfs@vger.kernel.org
> >  L:	linux-fsdevel@vger.kernel.org
> >  S:	Supported
> > @@ -21596,7 +21594,6 @@ F:	drivers/xen/*swiotlb*
> >  XFS FILESYSTEM
> >  C:	irc://irc.oftc.net/xfs
> >  M:	Darrick J. Wong <djwong@kernel.org>
> > -M:	linux-xfs@vger.kernel.org
> >  L:	linux-xfs@vger.kernel.org
> >  S:	Supported
> >  W:	http://xfs.org/
> > -- 
> > 2.1.0
> >