Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp15124lfv; Tue, 12 Apr 2022 15:20:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykaQ/6wO1KdeqUGgu/e+uxAel0TjLoWKKYte2/WCRL49GAKy+ILGbYIBNJLCWbBurqXF1H X-Received: by 2002:a05:6a00:234f:b0:4f6:f0c0:ec68 with SMTP id j15-20020a056a00234f00b004f6f0c0ec68mr40673085pfj.14.1649802036378; Tue, 12 Apr 2022 15:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649802036; cv=none; d=google.com; s=arc-20160816; b=BFYqgZ20KpDIkVnyvPVI6DB1dBAXLSYeWk7PaYQ0K4rAKTwsTit9tPzbOUg5bX9pG+ /+vNg0dHNnP73BFDIAZap+k1HUzTf51LXwwJwjugcEYUQHcdux+Qhr38wMb5QpLekxSL NivskhRtdvlrfbBF3N2pGjvwDyL6Zba17CP6bSj1uAW7EIN8xfTJ2IhPkJ+Pr54UmCW2 PEIXVtCM/EuxU7K+qHzY2XSmt10gU6AwRbsKog84xiN8PMSnYCdDoCd2GDfa67LGxUT4 Sococx42OHMl0q4xBS/Jq5FKBmqHks5KrZbd/Vnw65K6cHZGDO6wztC70BDKn7D75WvD lsZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fV02oSCuMzcl9O3m5Vjy8ute4C/2Nm8HyhHVWlMjXrI=; b=LcNr3STkS+JzqgFRdnqUyaGfcAfoWl+IPcCOZDXR0250Bi5rYxTZSzG82uH9gk4cif lpzCODNv7s/yC4C0Mgyi0nx8i+LuDgzmHHQZ+Ny61dELp34z5whAiCY9CKquI1zi8kK2 DcVf3JGW/V4cOb+c+Ml6UG7yW2ylnREzQOOFdB8923wC6KS8/3XZnKOzgPAWeQkm9os+ +wLAxreekgkqPXlvsxLXhxXbxavp5Pi9Uhker1fcIQW/QMpyRrnSSOiyht3lcG+E/oL3 wjo93nG3+7+iQbRMrZjqrgKC5iP6y3uKpCf/V0OqjWppsIvqKKqTdwG2j7/ru/8IB1fX JlDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o7rOm4Yp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d8-20020a170903230800b00153b2d164bbsi5657501plh.195.2022.04.12.15.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:20:36 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o7rOm4Yp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5F827D556F; Tue, 12 Apr 2022 14:01:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351126AbiDLG5j (ORCPT + 99 others); Tue, 12 Apr 2022 02:57:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351121AbiDLGwu (ORCPT ); Tue, 12 Apr 2022 02:52:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF142BB00; Mon, 11 Apr 2022 23:40:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9ED7A6194F; Tue, 12 Apr 2022 06:40:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC030C385A1; Tue, 12 Apr 2022 06:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649745602; bh=cc8s8qit5LAd78fWU8PWp4ehetundYYwIwOjn+ta9CE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o7rOm4YpiGRem2D4FLY2zkzyh+PIuFv/PrZEF7yJSizSO/wGBheYREUVc2vxOpvke xMsk4rtBVgP8EetEfR46+v2mnK0WROr3ofyzcfA9l3r1chh249SOLMXyfkz6w38xFM C/zkjsxTsY8A8H1fZLBpLCiTHYJvaxeyvCGd83v8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Menzel , Alex Deucher Subject: [PATCH 5.10 152/171] drm/amdgpu/smu10: fix SoC/fclk units in auto mode Date: Tue, 12 Apr 2022 08:30:43 +0200 Message-Id: <20220412062932.291669391@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062927.870347203@linuxfoundation.org> References: <20220412062927.870347203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Deucher commit 2f25d8ce09b7ba5d769c132ba3d4eb84a941d2cb upstream. SMU takes clock limits in Mhz units. socclk and fclk were using 10 khz units in some cases. Switch to Mhz units. Fixes higher than required SoC clocks. Fixes: 97cf32996c46d9 ("drm/amd/pm: Removed fixed clock in auto mode DPM") Reviewed-by: Paul Menzel Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c @@ -709,13 +709,13 @@ static int smu10_dpm_force_dpm_level(str smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinFclkByFreq, hwmgr->display_config->num_display > 3 ? - data->clock_vol_info.vdd_dep_on_fclk->entries[0].clk : + (data->clock_vol_info.vdd_dep_on_fclk->entries[0].clk / 100) : min_mclk, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinSocclkByFreq, - data->clock_vol_info.vdd_dep_on_socclk->entries[0].clk, + data->clock_vol_info.vdd_dep_on_socclk->entries[0].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinVcn, @@ -728,11 +728,11 @@ static int smu10_dpm_force_dpm_level(str NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxFclkByFreq, - data->clock_vol_info.vdd_dep_on_fclk->entries[index_fclk].clk, + data->clock_vol_info.vdd_dep_on_fclk->entries[index_fclk].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxSocclkByFreq, - data->clock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk, + data->clock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxVcn,