Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 12 Apr 2022 10:34:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jaehee Park <jhpark1013@gmail.com>
Cc:     =?iso-8859-1?B?Suly9G1l?= Pouiller <jerome.pouiller@silabs.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH V3] wfx: use container_of() to get vif
Message-ID: <20220412073444.GE3293@kadam>
References: <20220412041218.GA2859599@jaehee-ThinkPad-X1-Extreme>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220412041218.GA2859599@jaehee-ThinkPad-X1-Extreme>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IDAYtQ80XasYzSA0l4AGJqMJptjUrW08J+0PFQ8urjRCliwQOUpXAT2xjV/t?=
 =?us-ascii?Q?hNOIkvBROO9NZY+ieNVGBI0vt+8o5y6SnM3+9Pv0GUI78zyY4+f3iyk+PqKV?=
 =?us-ascii?Q?f8Kr41MT3x9Yu4qmymOOKcb8s7WhEQ8wcWFEqNoBxdOL63oCFNZO8pD4m3ZV?=
 =?us-ascii?Q?gEG/5FvCJjskzdaghDuYwdCQSnTA73WtlCdeZjk/7KVhiSQeKNM/2OBEW1WR?=
 =?us-ascii?Q?5C9c94tWyMCcL6HlnbLk7AyVLNixRNRIWD3TLN5iz9sHl2fRHaCvu2v0WXRr?=
 =?us-ascii?Q?7gxlbbFWwhXk25mhu70VWdr0D8EWnsh7mXvO5AesDwAnhEqbEM2IaKFDmctx?=
 =?us-ascii?Q?pOp5/hb+PmR6zlYC0u94cFoCvZqep4lHw9Bd4iiFnXKtLJrG5G9/VkpcAJmO?=
 =?us-ascii?Q?VTnvZYiGmpfYmy7814JHYZ34McL2iyQE5wEC1ze+hzvGbRTnMJ++SHKkPiTj?=
 =?us-ascii?Q?ru72zk+eYmcSlE0hgPM4sZAsV7YiPQCwEi1ZWbEfL3JoxSttaqgdvCuMr31H?=
 =?us-ascii?Q?N/cu275zhuYS+2spjRFGZVznYzMmkumvKCIaAh/cH5vdPPDJKbFFDLvmX2x/?=
 =?us-ascii?Q?/NOo4xbIg+t9CRll88O3eBhBRCG299xLRlRKGyKUCbYUG8FnMrv7AoFNjqGJ?=
 =?us-ascii?Q?6Wz9k6hJDMXBPPNmbKxrkRZz/IJzJNVZPYCnzIBdjlfMFAurRj6LmMjrNIG8?=
 =?us-ascii?Q?dfSs9agTQv/0eAEYFD2qvlGAF4BrNZYRZcHl5MTzsu2B9sSfWJVpaSiZpX1n?=
 =?us-ascii?Q?cZTL5SZlZP7jQQ4SuKuLqkZmm0J64wZq8kN3eiVwC8cYwOgqv4rH4ny/TQwY?=
 =?us-ascii?Q?9KZ2bFAcXvA0C3th4WbDbGyQnOMgVxKG3c9R2Qbpczdy8VPsKifatiUywdoH?=
 =?us-ascii?Q?UI5b6OOiZzI2wFQ105EnSW7EDdAgXG5eeBG1Rr2xiw9UtHJA9RbPxGlN24J9?=
 =?us-ascii?Q?g5IUwFPVW6l+7fgQSIb8GDduNPRnjHQgcSUU6Yb8pL/E5TE41rtbzOAcUzd3?=
 =?us-ascii?Q?sEl0et71X2ouhrjj9ydD0XuI+ha8GP7HiTaD4Zl4Olh5pqu0oddIktPZPC2t?=
 =?us-ascii?Q?9Vi/EMkt7XdeMUXlwxE0GHbWapn0SQ77WFlzQ/kyoD1DUrrxmLa3SfoNZewQ?=
 =?us-ascii?Q?fxHopR1fudZdPv5WdzkwUsHs3N7kZworvzqCnq59jTZV8j3J2Nx+mmDiOi1z?=
 =?us-ascii?Q?3ctxY0XpkVeGCpAXZYFSFdWlkbt+P2Vdm1l9gu6jwHQYhId3Lcjif7C6IAUm?=
 =?us-ascii?Q?pBD6wz0Slnzt0h534crYtQMwx0b0NMl/vXsR3pp1/njdxjtZ0sfnTUFa3FjB?=
 =?us-ascii?Q?ZJSRqNBQ1DQJtTjm/0DBOpLwOCHOBQpMazB3Xq1Yfk0w5tHIipX+hUs3PXOT?=
 =?us-ascii?Q?vRi+E5OPHKNP7cKgcRejmd8K0aC/nuasTm7RgXhlP+OfZ95gSjwwZk4/5pNY?=
 =?us-ascii?Q?e2KWFeD0ATqsvxs7p5IMg+/vj9mUNJiGfXtD5pInpKZlTy1DpAnWOdkQXE6A?=
 =?us-ascii?Q?wjXhNkzBv5d9s25gUOHdttmeJXAzQxp7lobWtm2rNOVOnGslKCcmbJ4VhxXV?=
 =?us-ascii?Q?WwUw2velI990o4iusCmdOdjRDgAgF2HZAXnHMfiGLkXW1LzNe6oj9Fj+JzUw?=
 =?us-ascii?Q?m9QUM7f0mVzcMmruDvMatRoKnL7p7/x1EpVwLiJucfmv4V514Ihs31zgULdW?=
 =?us-ascii?Q?GqlRtm8yXkJGNiBRrnHZLMVYSbU/J6hBBqWmmRJbgEs1zr050YSTdXz5BTlc?=
 =?us-ascii?Q?801DtEM5FBJM07zdftXS3hiMGTqp804=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: badfef4a-cbbc-46f6-9cbd-08da1c56f71c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 07:35:06.9490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KXjtwSs2O2ZcCR0LEYR72SbBh4x1HUiVprYuJSzb45TQHIXnTn0e+M7pptzm8f2ltb3ZL2Oh37SnUWea5HJZmMP71GRiTg3m3XDQisdBe98=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2813
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-12_02:2022-04-11,2022-04-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204120035
X-Proofpoint-GUID: STR57IbJSYVfAF72RgT4vF6FyyzvEj1U
X-Proofpoint-ORIG-GUID: STR57IbJSYVfAF72RgT4vF6FyyzvEj1U
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 12, 2022 at 12:12:18AM -0400, Jaehee Park wrote:
> diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h
> index 78f2a416fe4f..a07baadc5e70 100644
> --- a/drivers/staging/wfx/wfx.h
> +++ b/drivers/staging/wfx/wfx.h
> @@ -25,7 +25,7 @@
>  #define USEC_PER_TXOP 32 /* see struct ieee80211_tx_queue_params */
>  #define USEC_PER_TU 1024
>  
> -#define wvif_to_vif(ptr)(container_of((void *)ptr, struct ieee80211_vif, drv_priv))
> +#define to_vif(wvif)container_of((void *)wvif, struct ieee80211_vif, drv_priv)

Missing space character:

#define to_vif(wvif) container_of((void *)wvif, struct ieee80211_vif, drv_priv)

> diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c
> index 5c25fde3fc41..e90170062d42 100644
> --- a/drivers/staging/wfx/scan.c
> +++ b/drivers/staging/wfx/scan.c
> @@ -24,8 +24,9 @@ static void wfx_ieee80211_scan_completed_compat(struct ieee80211_hw *hw, bool ab
>  static int update_probe_tmpl(struct wfx_vif *wvif, struct cfg80211_scan_request *req)
>  {
>  	struct sk_buff *skb;
> -
> -	skb = ieee80211_probereq_get(wvif->wdev->hw, wvif_to_vif(wvif)->addr, NULL, 0, req->ie_len);
> +	struct ieee80211_vif *vif = to_vif(wvif);
> +	skb = ieee80211_probereq_get(wvif->wdev->hw, vif->addr, 
> +				     NULL, 0, req->ie_len);


You need to add a blank line after the declaration block.  Also there
is trailing white space.  Run checkpatch.pl --strict on your patches.

regards,
dan carpenter