Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp20698lfv; Tue, 12 Apr 2022 15:33:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh93B+ciaeJgXrH1nNCRf0tuJWgL/gOvLX3G7rhPNtRdIi85SUoLizNTaNp08C32yV12bx X-Received: by 2002:a63:250:0:b0:386:4fd7:432b with SMTP id 77-20020a630250000000b003864fd7432bmr32239002pgc.26.1649802780132; Tue, 12 Apr 2022 15:33:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649802780; cv=none; d=google.com; s=arc-20160816; b=qhDANmyOTPRgScbJjWcetwZ9F6F2RdwG6/tsCDImC8QGkA006SJNVtrSO/jhdC25Wy dOLpCU64NLKT1KLQRPP3+xDdvsbpj8a2603CJSwtdVlvOltJ8ka2powr2QTbPHDrYxe1 ucSRLyDjFi11BtMAm94AfPxQi7lbv9O42vXE+MohBa1SQWFqE7up+jYx/rvkZ66SeIq7 CRuYozVb/5kUW0cd40ZvghOKCHq3sPExsQkAbtQ6Ir8ZiehOZ/j1BCsomKVUVf7dBH1q Tk6RpvoqnBTT/M+K4AvHHgApw8Mj0GqEPa7UByz0HQkiiGoLxFSMidQsIieNmm6Qrm6I MBtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OS6HXCbi50rLQ+5+wJff/UtzHgRxWLH9s4eIWSI+9Ho=; b=skZNVcZkVtMkbTkoANyW1AfkkMwOEz4JVnSrhvdqioN1CXaa9J9JmcJzgTBlh7XTqL 6E5K7ksTveNdLfRo/j3xipl611Dmn8B47qb6uggbo33FEb2mY2hHH0Xdm5XiGEpFaN8E mN7Jkv6vi/9dtZK2EmrgDGx9euSH35Xwja4mMxjE0CMpMi8w3Qn+8PYdjRrRG/H4fZ14 XIf4sZEk+cbgxRBSAswrnz3990cak7OvNL2PUNTh+3ILA32pJ1fKTc1FSESLbbOHO8K+ PtqoQ0df4K3eYkHMs7SbfSjhqD2odLarp4f33tRHcLjMylimOXoLZqdqB1EWO2HVkOYq ZoTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02XGFvIt; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f9-20020a636a09000000b003816043ef28si3900095pgc.285.2022.04.12.15.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:33:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=02XGFvIt; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BB1A019478D; Tue, 12 Apr 2022 14:09:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353875AbiDLHiA (ORCPT + 99 others); Tue, 12 Apr 2022 03:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352367AbiDLHN5 (ORCPT ); Tue, 12 Apr 2022 03:13:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A9024F02; Mon, 11 Apr 2022 23:54:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D290CB81B49; Tue, 12 Apr 2022 06:54:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D09CC385A8; Tue, 12 Apr 2022 06:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649746480; bh=qjaUBTBW20T7UWuTxWW0iMkCQ6k2PxjPtqmtjDEux3E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=02XGFvIti7TCmscmIaBS3nTt/5wdcOWM1XzLnrAXZnvk2vzGXGt0fzZr/qOiwD4z8 Tq8M6Dhz1dX3WE7Ql6M7DZm0IKk7oUyZt48G7ffedMiRgblzkNey5WZdihH4UiMid5 NFh7Uw9GDU5dp+vRnJfJfSLY07EE2CjgOSLTpNbI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zeal Robot , Yang Guang , David Yang , Richard Cochran , "David S. Miller" , Sasha Levin Subject: [PATCH 5.16 020/285] ptp: replace snprintf with sysfs_emit Date: Tue, 12 Apr 2022 08:27:57 +0200 Message-Id: <20220412062944.262362779@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Guang [ Upstream commit e2cf07654efb0fd7bbcb475c6f74be7b5755a8fd ] coccinelle report: ./drivers/ptp/ptp_sysfs.c:17:8-16: WARNING: use scnprintf or sprintf ./drivers/ptp/ptp_sysfs.c:390:8-16: WARNING: use scnprintf or sprintf Use sysfs_emit instead of scnprintf or sprintf makes more sense. Reported-by: Zeal Robot Signed-off-by: Yang Guang Signed-off-by: David Yang Acked-by: Richard Cochran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/ptp/ptp_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c index 41b92dc2f011..9233bfedeb17 100644 --- a/drivers/ptp/ptp_sysfs.c +++ b/drivers/ptp/ptp_sysfs.c @@ -14,7 +14,7 @@ static ssize_t clock_name_show(struct device *dev, struct device_attribute *attr, char *page) { struct ptp_clock *ptp = dev_get_drvdata(dev); - return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name); + return sysfs_emit(page, "%s\n", ptp->info->name); } static DEVICE_ATTR_RO(clock_name); @@ -387,7 +387,7 @@ static ssize_t ptp_pin_show(struct device *dev, struct device_attribute *attr, mutex_unlock(&ptp->pincfg_mux); - return snprintf(page, PAGE_SIZE, "%u %u\n", func, chan); + return sysfs_emit(page, "%u %u\n", func, chan); } static ssize_t ptp_pin_store(struct device *dev, struct device_attribute *attr, -- 2.35.1