Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp20753pxb; Tue, 12 Apr 2022 15:38:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKpQiV3R/KwHHp0C/2gNd8nxhxQG7KKH4xfbVU/7BIyT3ElnmkBh7q6K0qbW46M2ZfPkRa X-Received: by 2002:a17:90a:1b02:b0:1cb:a256:c0a7 with SMTP id q2-20020a17090a1b0200b001cba256c0a7mr7275158pjq.185.1649803088490; Tue, 12 Apr 2022 15:38:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649803088; cv=none; d=google.com; s=arc-20160816; b=q0Nmx4Ru6A969LUGzGmX4DjMVlWZQ4g4NQzh67qOGwayfUvautpIVgHpsKYuut1AIz CbmvhEvF1vGKoj5YSj/WCqUojw4VlXV83lZgwPm2EKfQCpWpR/OjjrdqNVYOejDO9juN qFGJe3ZTZqPQR/9XGTercuj24+GhZaObwYGn5Y1BQlW0UDUbxgx6p0Bie2o1a81Ud7D0 uPy2EJeLiL7Ax2iDx/wsQEL7fvvdrqLn5CnhzYpUQu7Zb/CIH/3CwY96lCw4kbckcA5a 9NvaPo3etSjU8D4Nbzl4E0j2IzDUJdD6eeXAJHLeX41xK45+06Z86Of5xkWJnSOutM0f zEZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D8qXcSmrD7YYt4dQl7/p2JF9y53VzHedkDqHtn40lOw=; b=e/nkGBmYFgK3DQMs463b76aSggL06D1G0l5Iv1Ludd1/njsbqlYxd1F+0K5VjsQ7MM I4s0C4qNXNIlOMCpxjdpiCJbCKR2UwPN8H2c1zx3enAXrOL5lnlSaVQfFK3ieqrVa8h+ JlHxQ5m5ZGfozIAPvUYrhhCTumdG82gRoIP1x+3iO64tugUlzbbgG1z+wk61qUnUhj1C Ef1vmT8nwuUd4WT4vmSbMdQbJPXxPjpboOxtk1YpCsec+4nBD+v48EPjv/6ts3wKmQrl 0UqKUY3pQ/jw0qXyr+cWjZsbfgHVn2OZO5rt0v/itjzQDrZPc2ZaWzxk4BGSMBbCSPX4 bsZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SFI9YTCc; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l71-20020a63884a000000b003816043f166si2359335pgd.859.2022.04.12.15.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:38:08 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SFI9YTCc; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC468F3A45; Tue, 12 Apr 2022 14:15:45 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351865AbiDLHow (ORCPT + 99 others); Tue, 12 Apr 2022 03:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354343AbiDLHRf (ORCPT ); Tue, 12 Apr 2022 03:17:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A441F4BFC5; Mon, 11 Apr 2022 23:58:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4EF71B81B35; Tue, 12 Apr 2022 06:58:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9595DC385A1; Tue, 12 Apr 2022 06:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649746734; bh=3535TF05XMwI7IlTt70GcFU3BoNH+1hFeZqaTcbTgZo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SFI9YTCciT8TUHhpuWV1gDtgx4+pjiGripmR+UHUev6KjKRtzjIpD4aiWNGHuI5Rh kK5mIqgaTFir/PY4+2cGloArmS82Rh3GAeUDL9lopd0e1kSI/FHe/UKbBddWRWFDhl rSvCLoayXKbWT7dPqqyWb26Epw0NRvj3mNSWE/Mk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jack Wang , Damien Le Moal , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.16 074/285] scsi: pm8001: Fix memory leak in pm8001_chip_fw_flash_update_req() Date: Tue, 12 Apr 2022 08:28:51 +0200 Message-Id: <20220412062945.802805257@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Damien Le Moal [ Upstream commit f792a3629f4c4aa4c3703d66b43ce1edcc3ec09a ] In pm8001_chip_fw_flash_update_build(), if pm8001_chip_fw_flash_update_build() fails, the struct fw_control_ex allocated must be freed. Link: https://lore.kernel.org/r/20220220031810.738362-23-damien.lemoal@opensource.wdc.com Reviewed-by: Jack Wang Signed-off-by: Damien Le Moal Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index e447b714df2b..1a5338917a89 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -4907,8 +4907,10 @@ pm8001_chip_fw_flash_update_req(struct pm8001_hba_info *pm8001_ha, ccb->ccb_tag = tag; rc = pm8001_chip_fw_flash_update_build(pm8001_ha, &flash_update_info, tag); - if (rc) + if (rc) { + kfree(fw_control_context); pm8001_tag_free(pm8001_ha, tag); + } return rc; } -- 2.35.1