Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp21982pxb; Tue, 12 Apr 2022 15:40:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwmkQvGR5wZUISb0iTXdIO+LpkkwACi82M10c3GqFwRn3XFVJGcd3/7zUbnYgHkI56WN+8 X-Received: by 2002:a17:90a:fe05:b0:1cb:b98e:8c78 with SMTP id ck5-20020a17090afe0500b001cbb98e8c78mr7276082pjb.181.1649803231385; Tue, 12 Apr 2022 15:40:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649803231; cv=none; d=google.com; s=arc-20160816; b=ptXCmih+PPSByVv3ajzDeVdDN7DMO8LJQ1cuvvvymCKbAWte5YUhWMb73sjhz3MlBb FdfnnlrIz1dKXvhZDt2LKBhQMLZ/2W1PYZ2d5KBDJaVaej1utVCfZZGxzjJeKoiFMYlZ smtbgWGwkPThafIQ6LZmgFUVFmdiZ7dXa51rxcZSZUE1RIcyjC9Y8bgA80309JF8wKGV 6TowzDP3iHz38ODyuh6FuIPaSu89rSTCibsA7lQP9e5jzQYNX6YOkFaVWE/SXSGqB8fr L2cj4RwJpzu+Q07OkTZcndX2ZCNcffzLjiaAqtqBK8v4t3wWNYSuDDcaY2N8jAPRMN0w Cskw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=9lC0yv022i0CueqKYelOpTAIE5sprvHncsYQxz3lXPE=; b=LuicrMQXOA2b3rVu1pPFO/Cw+a62csPwzVNH4jEYKNjda9JbPR1QfrJdkWjkTnWXsM iL7A/OV1G+F3vCEZr5sIH/p9be+pJmBeKajaoow3zxz92bxlv7PTPYSx/hYczUF472pU a9ToB0xM6B4e8wM6ddz1l7V5q0EFFYmPC8Ia5r7Z1q+ka/RxJ0wSXLrJSNsptyVpoSlW aA6GnnZ5gnwp/wc6Ch2N/d3E/BaXqWWrp1oDbBkoFU6yCYXS0Goe1Re/eXprue3vZqsQ 5+m1N383K6hdPnCN58Qgfm6xf5neHInc+XA6aOPCqO62JtI8/QTfj86cjWq6agi7qF/Z K9GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Htkb5rlS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e69-20020a636948000000b0039d1ee91117si3792369pgc.744.2022.04.12.15.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:40:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Htkb5rlS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 276B2FFF55; Tue, 12 Apr 2022 14:18:50 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346131AbiDKMhw (ORCPT + 99 others); Mon, 11 Apr 2022 08:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346134AbiDKMhd (ORCPT ); Mon, 11 Apr 2022 08:37:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 79F2B1B789 for ; Mon, 11 Apr 2022 05:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649680518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9lC0yv022i0CueqKYelOpTAIE5sprvHncsYQxz3lXPE=; b=Htkb5rlS7qXrEaBijnil9Lzd8OkNCtUx80GpZQaVuEllpf4zJQbiQpYnKvjURrBOF+HDVi OX4BKp22kAdy7UreSOMr828jDzO+oxXWd0i+IbSpLzc2Y5hA40ojlmohtmCejhQS7DAI0J 6RwVnm28pANjT5IYp7y7XrFYHpQC1R4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-449-ZPIfAO1VN8qxKXuAQn97-Q-1; Mon, 11 Apr 2022 08:35:12 -0400 X-MC-Unique: ZPIfAO1VN8qxKXuAQn97-Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E6AE803D67; Mon, 11 Apr 2022 12:35:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 166A2C2813D; Mon, 11 Apr 2022 12:35:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220406075612.60298-5-jefflexu@linux.alibaba.com> References: <20220406075612.60298-5-jefflexu@linux.alibaba.com> <20220406075612.60298-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v8 04/20] cachefiles: notify user daemon when withdrawing cookie MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1091404.1649680508.1@warthog.procyon.org.uk> Date: Mon, 11 Apr 2022 13:35:08 +0100 Message-ID: <1091405.1649680508@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > +static int init_close_req(struct cachefiles_req *req, void *private) "cachefiles_" prefix please. > + /* > + * It's possible if the cookie looking up phase failed before READ > + * request has ever been sent. > + */ What "it" is possible? You might want to say "It's possible that the cookie..." > + if (fd == 0) > + return -ENOENT; 0 is a valid fd. David