Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <7d6893a9-01d2-e1ab-06c2-745aa8bcd2b0@gmail.com>
Date:   Tue, 12 Apr 2022 17:19:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] ipc/sem: Remove redundant assignments
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>
References: <20220409101933.207157-1-michalorzel.eng@gmail.com>
 <YlRNmXucZwNasoFq@thelio-3990X>
From:   Michal Orzel <michalorzel.eng@gmail.com>
In-Reply-To: <YlRNmXucZwNasoFq@thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nathan,

On 11.04.2022 17:47, Nathan Chancellor wrote:
> Hi Michal,
> 
> On Sat, Apr 09, 2022 at 12:19:31PM +0200, Michal Orzel wrote:
>> Get rid of redundant assignments which end up in values not being
>> read either because they are overwritten or the function ends.
>>
>> Reported by clang-tidy [deadcode.DeadStores]
>>
>> Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
> 
> Thank you for the patch! This should go through Andrew Morton, now CC'd.
> 
> For the future, having some history behind the origin of these warnings
> would make review a little easier. I'll comment on each below.
> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> 
Thanks,
I will keep that in mind when sending other patches fixing static analyzer findings.

Cheers,
Michal