Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp28910pxb; Tue, 12 Apr 2022 15:54:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxv0VYxRDxipR1wfwhnI675+A58H0qb8w871hues7JNkrUnvtHgujYEeL6XI92r12yFMEMV X-Received: by 2002:a05:6a00:27a2:b0:4fa:e893:bb68 with SMTP id bd34-20020a056a0027a200b004fae893bb68mr40274397pfb.82.1649804068058; Tue, 12 Apr 2022 15:54:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804068; cv=none; d=google.com; s=arc-20160816; b=If0AkSugS2WeTAGACNBFLLOe86fw7dqLX6ih94UL5PgE6lr7GjaXtVVKi7uRMt1xNP Kd7t3nULhsQ++O7KnlkqNQmrWuMnorv4SUSyG2COqHuw35z3Rw1sFBthPVgPZFhKmuxu NmO2V91BVVuD8Xah+khWmD1eNc5tIYrRcjYAY0OEyKBVB1TSP4tlLrnt67k8N5IeBHiE V6E7bz4pCKjyS7Ujpgmr52x8z1ywgaotE/j3N3iGglGd32sSSjv3A75vPiYOB3kHOi3m ihWXdqCbTp592fuCMjpcuwZOkoAOVnzb11zN0Qv1wt7u+NZN+EiNUGJFL/MxxBPB4F/t F1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9AjGwL7WiAVhq1FS4/gT4ENo946vc+7sugKvvlESnV4=; b=0OC95n/sFApjcGz39Ux2Rwxo0VvAl/htDUde1Uq4Oh+1d2FKMf2B1wWLOmJBL+o3Qi kIy/GxKrSE5jJM/+ZcqMFda+JPWn69nSBqo/aXUMiG42FflCGkti9IR+gkoPGuXT97do +6wklLAym+cu35xq5YaSM7Nj2tDY+mOrWPAWsRgrQBiQKMOcirexegpCnm3Nki0hMYva jSQEmrUN2T2Id9Bh17c88Rh0ChKbzzYgAMAdlZRoj9mYFhV6+S6GQzRMLfEnuWe5HskW Xe1//BvRqDXXk+MVNKOv6oTfdeJSiVCwvOyryVPVemV2AjvgNLw+Hjh4ZS8KQXE93lei jrHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kJEPD98m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j65-20020a625544000000b005060813b327si1772157pfb.168.2022.04.12.15.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:54:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kJEPD98m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B5AEE1CB17C; Tue, 12 Apr 2022 14:36:21 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384873AbiDLIm1 (ORCPT + 99 others); Tue, 12 Apr 2022 04:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357271AbiDLHjz (ORCPT ); Tue, 12 Apr 2022 03:39:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F2CDFFB; Tue, 12 Apr 2022 00:14:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8522561045; Tue, 12 Apr 2022 07:14:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AEDFC385A1; Tue, 12 Apr 2022 07:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747675; bh=vAiDl1GwVbQ82UKpOaMdXzGgdpkyRkO6Fv8harzJaY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kJEPD98mgdrCaH7jXoTlUJrCY6SMP2Fxvpz2G+6X0891E5/JYE7ZiskqJ69qlpv3d p27R8hsz0iVvvdOKso+mgVtAJzlkEDdVCk3B8ITGjEGQKAoXuz5fEjCg70UgYxOz0d JqxB2kontUorx/9oihrImgD5P6OWuuirbHK9l8gg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= , Ulf Hansson , =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= , Sasha Levin Subject: [PATCH 5.17 166/343] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200 Date: Tue, 12 Apr 2022 08:29:44 +0200 Message-Id: <20220412062956.162857858@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062951.095765152@linuxfoundation.org> References: <20220412062951.095765152@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jérôme Pouiller [ Upstream commit 96e0cbca1cb96e9d3deac3051aa816e13082f3fd ] Until now, the SDIO quirks are applied directly from the driver. However, it is better to apply the quirks before driver probing. So, this patch relocate the quirks in the MMC framework. Note that the WF200 has no valid SDIO VID/PID. Therefore, we match DT rather than on the SDIO VID/PID. Reviewed-by: Pali Rohár Reviewed-by: Ulf Hansson Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20220216093112.92469-3-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/mmc/core/quirks.h | 5 +++++ drivers/staging/wfx/bus_sdio.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 20f568727277..f879dc63d936 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -149,6 +149,11 @@ static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = { static const struct mmc_fixup __maybe_unused sdio_card_init_methods[] = { SDIO_FIXUP_COMPATIBLE("ti,wl1251", wl1251_quirk, 0), + SDIO_FIXUP_COMPATIBLE("silabs,wf200", add_quirk, + MMC_QUIRK_BROKEN_BYTE_MODE_512 | + MMC_QUIRK_LENIENT_FN0 | + MMC_QUIRK_BLKSZ_FOR_BYTE_MODE), + END_FIXUP }; diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c index a670176ba06f..0612f8a7c085 100644 --- a/drivers/staging/wfx/bus_sdio.c +++ b/drivers/staging/wfx/bus_sdio.c @@ -207,9 +207,6 @@ static int wfx_sdio_probe(struct sdio_func *func, bus->func = func; sdio_set_drvdata(func, bus); - func->card->quirks |= MMC_QUIRK_LENIENT_FN0 | - MMC_QUIRK_BLKSZ_FOR_BYTE_MODE | - MMC_QUIRK_BROKEN_BYTE_MODE_512; sdio_claim_host(func); ret = sdio_enable_func(func); -- 2.35.1