Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <66f417b0-c323-1b9f-d5b0-30f1c9bcd90b@axis.com>
Date:   Tue, 12 Apr 2022 16:08:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Camel Guo <Camel.Guo@axis.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzk+dt@kernel.org" <krzk+dt@kernel.org>
CC:     kernel <kernel@axis.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220411100329.1783432-1-camel.guo@axis.com>
 <20220411100329.1783432-2-camel.guo@axis.com>
 <c13a0f34-4938-3d56-43e0-5a9053e0bc25@linaro.org>
From:   Camel Guo <camelg@axis.com>
In-Reply-To: <c13a0f34-4938-3d56-43e0-5a9053e0bc25@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/12/22 13:53, Krzysztof Kozlowski wrote:
> On 11/04/2022 12:03, Camel Guo wrote:
>> From: Camel Guo <camelg@axis.com>
>> 
>> Document the TMP401, TMP411 and TMP43x device devicetree bindings
>> 
>> Signed-off-by: Camel Guo <camelg@axis.com>
>> ---
>>  .../devicetree/bindings/hwmon/ti,tmp401.yaml  | 111 ++++++++++++++++++
>>  MAINTAINERS                                   |   1 +
>>  2 files changed, 112 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
>> 

>> +      - ti,tmp401
>> +      - ti,tmp411
>> +      - ti,tmp431
>> +      - ti,tmp432
>> +      - ti,tmp435
> 
> Blank line, please.

Fixed
> 
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
>> +
>> +  ti,extended-range-enable:
>> +    description: |
> 
> No need for "|". Here and in most of other cases below.

Fixed

> 
>> +      When set, this sensor measures over extended temperature range.
>> +    type: boolean
>> +
>> +  ti,n-factor:
>> +    description: |
>> +      The value (two's complement) to be programmed in the n-factor correction
>> +      register.
> 
> Do not describe the programming model (registers) but hardware property
> instead.

Make another try. Hope it is clear now.
> 
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    items:
>> +      minimum: 0
>> +      maximum: 255
>> +
>> +  ti,beta-compensation:
>> +    description: |
>> +      The value to be programmed in the beta range register.
> 
> The same, register values should not be stored in DT.
> 
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    items:
>> +      minimum: 0
>> +      maximum: 15
>> +
> 
> 
> Best regards,
> Krzysztof

Fixed in v2. Please review that instead.