Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp31663pxb; Tue, 12 Apr 2022 15:59:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCZ+twjKMjjb9fhMptkNyHUkPECfPXUCm2C+e5DEPDqh1mc9ErqPpcU3PWjOs8qhWSZ0Ct X-Received: by 2002:aa7:8888:0:b0:505:a3e1:d246 with SMTP id z8-20020aa78888000000b00505a3e1d246mr17592803pfe.76.1649804390901; Tue, 12 Apr 2022 15:59:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804390; cv=none; d=google.com; s=arc-20160816; b=Oy6FyAE0ngB8OEE0zmqu6q34ZmGFUYkdUNvP9D5GpH4av4kpN97vDTRkosv0JMs+LS baWe63/kKCjUUm+BUBCpZ/d8tAW7up2FRv4R5GaSiHwe9AXNgrxr0z46Fx9gtatENe3Y S0jCIS0eIzl/IIaS2yo8fdmV10lkh3lt6YZiRvmeiUq2uZ0sB5MRn66UDwu35V/PpDaV GbgiA1+xUBLIpY83aT4JH9VS1SZDqBd/WBQEU/0Nih+V0NZ9h8OmroWSLkyjR+qRjCK3 kTyKrsIW3+57O/PP4woqBQLWHRsiezk+69HnQQfYMr2OfJCLVmGslKsfwcrX3KSARfVV ah0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ryVmliCBm1J9BWOlvk1aMg3eZLsXRY9HUbbB4r3t8q4=; b=XHvIw2Ptv2qlo4w4Oa0lS227WIpU8Judcbj4cKnvaCwYDvSvCh0ROl8oEO7HWRE8iw icFYrv6ncg6In3FRIdbQ3xZPVE3ry/ImeeGz28iKuyBegydK2ryjLyFaMKXIBljSVxEA LDHl+vdLBHxqjG2HgbWBgZYKjSvKhBy1pqeofMiLsu4kWFr0NnMq4YNsLa59WqVjBo32 iM0wUKITq0/q9vD1oRu5A5QrbN0Dbzu/+6oEjtQiHajgIe4RzmGV/+Z1HwuRH7g9jCdN 5cDYywkzutXR1Dq6aaq/dKWAKdqkd3Sq8biaxqp/1fuyI2iZi3sng3RpyagSXqbUXpU5 j85Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g3DqxdJj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id g14-20020a1709029f8e00b00156c7f7b950si11530420plq.347.2022.04.12.15.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:59:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g3DqxdJj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 22A501DB8B7; Tue, 12 Apr 2022 14:41:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352899AbiDLHOg (ORCPT + 99 others); Tue, 12 Apr 2022 03:14:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352603AbiDLG4E (ORCPT ); Tue, 12 Apr 2022 02:56:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BA324BC7; Mon, 11 Apr 2022 23:46:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83CFF60A21; Tue, 12 Apr 2022 06:46:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 969CAC385A6; Tue, 12 Apr 2022 06:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649745973; bh=bAPP0KeYlE4Rw4hQig6h+AE3aP+2SVdMxEk/gwMuZbk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g3DqxdJj9mB32ya4DGJj1oak7duRJg8oNRFPbWUhrsS4slnNADWsrdCtLPrdIR+lD ZssgJfqgJkzIKHR1mAx1eq9Sw/wz2U2/rUjdv7WBUu67SCTSDFm2InSROP0/M9ozqb MBR43LMXrl2iNdZZOvBdJQ3jlPWJ8wPWeosKchwc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Amjad Ouled-Ameur , Martin Blumenstingl , Neil Armstrong , Vinod Koul , Sasha Levin Subject: [PATCH 5.15 114/277] phy: amlogic: meson8b-usb2: Use dev_err_probe() Date: Tue, 12 Apr 2022 08:28:37 +0200 Message-Id: <20220412062945.339283299@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062942.022903016@linuxfoundation.org> References: <20220412062942.022903016@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amjad Ouled-Ameur [ Upstream commit 6466ba1898d415b527e1013bd8551a6fdfece94c ] Use the existing dev_err_probe() helper instead of open-coding the same operation. Signed-off-by: Amjad Ouled-Ameur Reported-by: Martin Blumenstingl Reviewed-by: Martin Blumenstingl Acked-by: Neil Armstrong Link: https://lore.kernel.org/r/20220111095255.176141-3-aouledameur@baylibre.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/amlogic/phy-meson8b-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index cf10bed40528..77e7e9b1428c 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -265,8 +265,9 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) return PTR_ERR(priv->clk_usb); priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL); - if (PTR_ERR(priv->reset) == -EPROBE_DEFER) - return PTR_ERR(priv->reset); + if (IS_ERR(priv->reset)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset), + "Failed to get the reset line"); priv->dr_mode = of_usb_get_dr_mode_by_phy(pdev->dev.of_node, -1); if (priv->dr_mode == USB_DR_MODE_UNKNOWN) { -- 2.35.1