Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp35806pxb; Tue, 12 Apr 2022 16:05:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7amutofRsIrI5UGA9g9w6gxseRNujLy9NwlFtq6xVkoUU5ZJ0MdUmsDvzp3EnT7oj/Afk X-Received: by 2002:a17:90b:4c8e:b0:1c6:8dfb:3cb6 with SMTP id my14-20020a17090b4c8e00b001c68dfb3cb6mr7582042pjb.72.1649804713383; Tue, 12 Apr 2022 16:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804713; cv=none; d=google.com; s=arc-20160816; b=KJ6o9ODB6Ht338HdYpFYAerLKofJjsUGJqoHmjlmKSnBF0o2ZHwZ6jEAjhqXpGwzQ2 u/1wdK/qBJKa9y/E5PcA9PZHkCLL7gZUgd0LjzYX9h8xluDAZniI1VeUzlPm7L+7UFsG HaQL0eDj8pAx3YJtaLtwQiRb0dlhk6CYmC5wHjksXrJSUHMyDMSomb0FC09VdVig5Hp4 zBBGQTWlQxazcpvZT0EfA7tDRhi8Qg7InYszYjaGlnkiyoXoLgpSuu8gL1CCKNAFk2CL CcKWXU9JdgUizdhXTfF9nPG2pJePH1HnzIMtdUMovV/KkcqMcEXsEcPlqBjXxpFmi0sq E3WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kwv5t8TDzkweYtSYHxv8FdtO6QgPcESo5uLM6k9pq1U=; b=DbqnoVW/xFaoV1A+pL4+jk6KWAj7VkEMMSUTnkTNgLacnMNW815pk7TSYBWzpfXZZ6 aN/JwPtSfxMWgER6b1PPKvHP6aB5XyhKV/X6ThbdSa1YpzJqsk5oL39rZKh6hXm9Cj/B 6B6/lecSr4SXYp2IuJWrv+YOPz9mRwyWmR3qWo5uLTG4uQASq0phkeCowxdojHKxWPev k8BO/62CP6IKoFAzMiOA6slPhcr3W7xdYSkn+Arefwsu2wVV7id9ICKdk+V8ThBJbml6 +jaxpK8MVnfjqBo1LOyYo6Nvbw95PqRP7Q3yoU53CBSF6RnIGZ8BzV2bnSLYMwFKY+Mu DmIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GoCRUkCC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id ob11-20020a17090b390b00b001cbd844e55bsi3273245pjb.5.2022.04.12.16.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GoCRUkCC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 04AE113A1E4; Tue, 12 Apr 2022 14:47:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381203AbiDLIXQ (ORCPT + 99 others); Tue, 12 Apr 2022 04:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353717AbiDLHZw (ORCPT ); Tue, 12 Apr 2022 03:25:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64BA9F6E; Tue, 12 Apr 2022 00:04:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E16C761045; Tue, 12 Apr 2022 07:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC6D2C385A1; Tue, 12 Apr 2022 07:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747047; bh=QfgYC+KY/2KOvHfkTtApVBJJ78wgukpzMTQSv8FIaSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GoCRUkCC3qqnJ3QRFmGptNRVvcdk5RgRl+jpDhYCokPitCkh3PjnVCzAcXh8AdCDl 138J0ekY8j2bYpp0gXPTHZSgXDD77dxr9SBN4sO8KJoB4p0Q6gdqFsSUJe5i9jsC7R 5LvgmZSRdAbEf6sJgh/3EsfRMUEHa4vN/HYJTOnE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe Subject: [PATCH 5.16 224/285] io_uring: dont check req->file in io_fsync_prep() Date: Tue, 12 Apr 2022 08:31:21 +0200 Message-Id: <20220412062950.122417427@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe commit ec858afda857e361182ceafc3d2ba2b164b8e889 upstream. This is a leftover from the really old days where we weren't able to track and error early if we need a file and it wasn't assigned. Kill the check. Cc: stable@vger.kernel.org # v5.15+ Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 3 --- 1 file changed, 3 deletions(-) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -4155,9 +4155,6 @@ static int io_fsync_prep(struct io_kiocb { struct io_ring_ctx *ctx = req->ctx; - if (!req->file) - return -EBADF; - if (unlikely(ctx->flags & IORING_SETUP_IOPOLL)) return -EINVAL; if (unlikely(sqe->addr || sqe->ioprio || sqe->buf_index ||