Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 12 Apr 2022 12:00:09 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Qing Wang <wangqing@vivo.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hsi: clients: remove duplicate assignment
Message-ID: <20220412100009.nd5akezypy5lycdm@mercury.elektranox.org>
References: <1648728460-37288-1-git-send-email-wangqing@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hnaftqma46pljnb6"
Content-Disposition: inline
In-Reply-To: <1648728460-37288-1-git-send-email-wangqing@vivo.com>
Precedence: bulk


--hnaftqma46pljnb6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Mar 31, 2022 at 05:07:38AM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
>=20
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
>=20
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/clients/ssi_protocol.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi=
_protocol.c
> index 21f11a5..7aacb19
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32=
 cmd)
>  		dev_err(&cl->device, "No memory for rx skb\n");
>  		goto out1;
>  	}
> -	skb->dev =3D ssi->netdev;
>  	skb_put(skb, len * 4);
>  	msg =3D ssip_alloc_data(ssi, skb, GFP_ATOMIC);
>  	if (unlikely(!msg)) {
> --=20
> 2.7.4
>=20

--hnaftqma46pljnb6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmJVTZwACgkQ2O7X88g7
+pqFmQ//Tk7WimaocfFMEigICLkJ9XDeWiK8siEAL2Ent2o2HOyGYtlLVAB81cyr
xTGyTKvxbnSJ2yyt7qXsgwOFV2U7wlloE9l8PXuBLYFMjtC34nPlKUvOBbVlJX7u
Z2+3aAJeCjyL9lXesqCmCwJEsY/ObHWTVKLnbvvS/IwQQ9GEpWJKAELauvaWu2y0
wWcuUubIC1ssTXwVSClTFl4WV+pVg6ZiDJJo/PKYR7AIwnFPit8AVl/oUbTN4VmW
pNZSDU8uhTcEsoGncd0AEn1rxYjzuwiQajOhd63X/X6s43G4z6/2v77bKYQJZ3c7
u7b3TyfxCZytJwq9LbDYRPYFgjTJ5egWRZIm6vf3UqIdSPMzZsy4mrWm5lV4Rxta
wTyW0seYrmorOZdLLvtRRkxfc40zcKw4sQzjp8Jhh0Pc1BII/WzuYI/NkBlL5XB5
i6g412uOFvU67DWICs03+v5i3zwCHy3RyyzstDWFp9mxhaCdtmwnu7I8oWDnj2QT
cfJsTC0c2Zf2EohwOtniCdFLYCLaqA+xRg2MMYSy3/MgIEeewWOqy+lTTDqvXTrw
HBG5TGwUq8/JLdXBGG9rrwxR5pb2IyJexrJ9QB8wlPtxhhbV7u3Wduv/bc5Se916
yn1JdUB1VE2fR1mMgiK3EDYc9wdaXRpv8USQSv9wtlq61ZkXyAI=
=uU61
-----END PGP SIGNATURE-----

--hnaftqma46pljnb6--