Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp38630pxb; Tue, 12 Apr 2022 16:09:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDAPnaUELRibhhpftMXHtlk8iXyB6EAtRfpK8HlhoTWLHisWDSh/6ASJ8NQKLq10ykFEo8 X-Received: by 2002:a05:6a00:1701:b0:505:c49b:d2e4 with SMTP id h1-20020a056a00170100b00505c49bd2e4mr6900108pfc.60.1649804949133; Tue, 12 Apr 2022 16:09:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804949; cv=none; d=google.com; s=arc-20160816; b=przuDgndTYWW046qAmLw0z5+lKK3ZDLepUU+KVto5P3WbqGj92rhFCPJWtCf7MJ9zI w1I0F6zqBMfN5stPCgW6WaGog1YU1m42quHsJ+pSXHXWDsc6o93YnjcnfKGoj3xCosLg oB6hXQE0GyM5WdhC2l/N+SaDQmLwGHlTx/79ULvLZkWXCmOq4EtgQPzsJK+CPrfzVArc s73NNZfjoVR2DTVjQeZLqBKJdzZB/il1e8LwPn7Pu+l9h2w6zFlVf2ZFwFJJdDbMWUWJ 2b3uDzgH4K/vNKitfDQlOIkRz6DstgKpYqZTLMfGD2pLzPT3ruBw4PShXB1/APociNRa aCiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WONrR2LpUhTq1ZEkzDNXLVb2NgWZIcb3qvglaPNZ+rk=; b=JqQfncZkyGNYaVyXCHkqmpsHfE0oZxi6AwoZZy0Q3wnLzu+a+DuvxbYDXTTv5/4H6Z zUFERQwdnF7iQGgdd512te99NhDjd/nGrk051NdbnlAaII2jJSztiLlEC742cf5Ae1i0 5QzkhGeuM00l4s9WF+TU9IXU555OUQ+OwkX7PLYFJNBPf7vSfegrGxc3fOmCA1cXqkxi b/PC/UpChDW0mymlVl9WtraTyh47jW8GGNFrAalZQEFCE7F41ITHIizsxsfh0pdg86Xi 6HhO4/7e4SA0g5IZLRhzv0n88+CywOo3LKRMjkNRzCTLIKE5wgi8WbNRwsjScEzZRRuB 6usQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KMavsTZW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q11-20020a170902dacb00b001589c9ea308si1147677plx.349.2022.04.12.16.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:09:09 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KMavsTZW; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2B3CC14FBB6; Tue, 12 Apr 2022 14:51:26 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379997AbiDLIVM (ORCPT + 99 others); Tue, 12 Apr 2022 04:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354064AbiDLH0C (ORCPT ); Tue, 12 Apr 2022 03:26:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D35D17A9F; Tue, 12 Apr 2022 00:05:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 50EB3B81A8F; Tue, 12 Apr 2022 07:05:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18ADC385A6; Tue, 12 Apr 2022 07:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747128; bh=McsC9ZufxaUuzydXB9cDgdwI6fwZUeI+va5tpXteTiA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KMavsTZW0iom5ZjIrKNSaI19zZ7PZ9fre7+zCeXnl9thxqjJ6/IskZ0E0gthxdotW Y6b3uFi2SImAtr23PQvqwBjTk+XunwHzHKBymN53xnDJUewG97SynyDmAq9UolFsMS mRRN8XwYJJz5ot8ToVPvNdgAkXwMihx1pXzE8svk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Menzel , Alex Deucher Subject: [PATCH 5.16 254/285] drm/amdgpu/smu10: fix SoC/fclk units in auto mode Date: Tue, 12 Apr 2022 08:31:51 +0200 Message-Id: <20220412062950.991069461@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Deucher commit 2f25d8ce09b7ba5d769c132ba3d4eb84a941d2cb upstream. SMU takes clock limits in Mhz units. socclk and fclk were using 10 khz units in some cases. Switch to Mhz units. Fixes higher than required SoC clocks. Fixes: 97cf32996c46d9 ("drm/amd/pm: Removed fixed clock in auto mode DPM") Reviewed-by: Paul Menzel Signed-off-by: Alex Deucher Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c @@ -773,13 +773,13 @@ static int smu10_dpm_force_dpm_level(str smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinFclkByFreq, hwmgr->display_config->num_display > 3 ? - data->clock_vol_info.vdd_dep_on_fclk->entries[0].clk : + (data->clock_vol_info.vdd_dep_on_fclk->entries[0].clk / 100) : min_mclk, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinSocclkByFreq, - data->clock_vol_info.vdd_dep_on_socclk->entries[0].clk, + data->clock_vol_info.vdd_dep_on_socclk->entries[0].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetHardMinVcn, @@ -792,11 +792,11 @@ static int smu10_dpm_force_dpm_level(str NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxFclkByFreq, - data->clock_vol_info.vdd_dep_on_fclk->entries[index_fclk].clk, + data->clock_vol_info.vdd_dep_on_fclk->entries[index_fclk].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxSocclkByFreq, - data->clock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk, + data->clock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxVcn,