Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp38753pxb; Tue, 12 Apr 2022 16:09:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzf6NbEKhUoSSBQSGfxPyvSbX2pwlLt1JUmqlLlIdQ4tTRT4b1dc4BfcBxyN6KUetpcsX0e X-Received: by 2002:a05:6a00:1388:b0:505:9b0b:ba61 with SMTP id t8-20020a056a00138800b005059b0bba61mr19084024pfg.4.1649804959476; Tue, 12 Apr 2022 16:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804959; cv=none; d=google.com; s=arc-20160816; b=QjHTRhKuiF9bSdNZOI3ZovqL6vrrj4chTs5LD5jTDbQi9Stp9yxfMl0pb/LP9qhTD5 3GI3d9/SFxrpgQP45YBj1NU3OTYmbfK4tZMcNMn96YBw/Oa+jWduYYCnoHeIBKvvKc1x wyili/EgJ40atjK2cQSxrpUI6iQBuXOK13MKCSVhBwGjH5/TFy87fQq2qB7TaLRkCbvb 7Neie75s8sbRktNnHz7+w3DTewfDAMAPe2+eh1nElVDS4GC5i7rTjJr0jaXR9dmGZKCf Kkuozs0AfjvU6+bHK27GFb2HS6N6aEPPmcRsaAFVB2Sd1yUe3fD8fmuX+Rnhc94ZzyQt VIxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZXWYsMM0jWe9WNmzwVDHh+IQ1/Wzcf3Ef2kUBa1fVxg=; b=V1QlEG1pbg3pMUQvpckDrDjrYhObDvze89oIDeACBPbExPPjhDusBzNj2cmtVo9gSG YynQcEKxbN6iV6vwIe8MC5X/2jSmqu3FdonjmLUjcxqrQDGWKVNIzHv2n2IcJ6i1buc3 pXa5xUyGBYXBDhPV7ciw8oXXy/R52WhKB/VZwV64Dm9Eq/aX02EGVvslw1nRpv5OcAgG iyoGoqRDijtECVQjZboLZZU2MIt8sEyGjQbuwBzr0444qSHIi+z6hyG8BAHZbB9HmgdR 4Gfw1mWB3z1Ha/OqcL4owzEaJ1OSbUCRc/yZSLjB+jLWspqTmSO4kkCmfW5QhrTDCW4P 5rYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UkN+G21Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 17-20020a17090a1a5100b001ca8947e749si12672573pjl.20.2022.04.12.16.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UkN+G21Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ABF2F1FCD33; Tue, 12 Apr 2022 14:51:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354750AbiDLH5y (ORCPT + 99 others); Tue, 12 Apr 2022 03:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353627AbiDLHZv (ORCPT ); Tue, 12 Apr 2022 03:25:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9883E2654C; Tue, 12 Apr 2022 00:02:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3668B60B2B; Tue, 12 Apr 2022 07:02:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CD75C385A6; Tue, 12 Apr 2022 07:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649746937; bh=AY9XliJqhQHz3+D1GqTzQinJSnUeCbZ2PTPqsNyVaYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UkN+G21YRqEApqCqfzhXmgDtJ/uNY9VkG5wFrmiE+ZCn8vE2lyN4KZcLrVzl0R6lU MKhKLMStRjW2292cTJZJqn7Ub1AcxY4dgy/1rHa1KpbVr4fd5lI8nAt8DVPWO0RJAM EgIoRS2fQMlFGwL7njwmWDhPKQocWUMOefcUMnH0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Paolo Abeni , Sasha Levin Subject: [PATCH 5.16 184/285] dpaa2-ptp: Fix refcount leak in dpaa2_ptp_probe Date: Tue, 12 Apr 2022 08:30:41 +0200 Message-Id: <20220412062948.975026606@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 2b04bd4f03bba021959ca339314f6739710f0954 ] This node pointer is returned by of_find_compatible_node() with refcount incremented. Calling of_node_put() to aovid the refcount leak. Fixes: d346c9e86d86 ("dpaa2-ptp: reuse ptp_qoriq driver") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220404125336.13427-1-linmq006@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c index 32b5faa87bb8..208a3459f2e2 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c @@ -168,7 +168,7 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev) base = of_iomap(node, 0); if (!base) { err = -ENOMEM; - goto err_close; + goto err_put; } err = fsl_mc_allocate_irqs(mc_dev); @@ -212,6 +212,8 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev) fsl_mc_free_irqs(mc_dev); err_unmap: iounmap(base); +err_put: + of_node_put(node); err_close: dprtc_close(mc_dev->mc_io, 0, mc_dev->mc_handle); err_free_mcp: -- 2.35.1