Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp39152pxb; Tue, 12 Apr 2022 16:09:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbsThPGbU77tM6UnIBErXQtxqfIaCnqIrRB7LFkTzPGq13dFvT25+SsrixocBzib/J7n/u X-Received: by 2002:aa7:8888:0:b0:505:a3e1:d246 with SMTP id z8-20020aa78888000000b00505a3e1d246mr17638562pfe.76.1649804995986; Tue, 12 Apr 2022 16:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649804995; cv=none; d=google.com; s=arc-20160816; b=yfzHGj1TzmQoK+DdvOvEPOSLsl3aOTBhVaYdT/ShQheGWXxo1xirNtQfy1MCgfDLjQ aO4pY9kd3ckIjjS96bEA2VLHsHl9TKZupmIT/viikmMahNxkjPKAYR7y0nZJnnn6aY8l Hzxkbk/uAMEBIarDvwSe4Nw2V2f/VU94IhWhbHK+uEJi3vzyX03B+zk8V2Uussv+vX80 XERPg3dCK144rhB6FkMe66OuGoJBV1hAcxNQRSzyU2qPYRymhhrJ+IhOKjomKxr+8FWj RhJvYyTvc/Pu33EReUp9WRWfP6WPleKHNze19pvB3yNW68ejtUXSFNxLvZbu3CbIGf+l 2row== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VUzQhVlmMVLI59w1MKtDK1iLXxrtfmH3p/Z3+o1cBUA=; b=bhS5/GT2X1nxPEqmh/IglwHmPbpVnwvMrWkcNP2hSW8UAdQ6cIo1Vv1A1xMNmohya+ kSvdrZmNnTOKS9om7q94wRHZI9oQB5eaD9eVBVBvtqEueotSc96oHQfm3dkOnDmPP3Pu ZCx1f0UAt3C8gwxh49ChYAyc51hyQeBVRBKSfuVkpr7BUWiP3Y8531sn/mdr8a/D0SQ1 /mKyfA8d1LILNWvuIA112BckfGOOeBVuvDVm9NZNVU9wBZzTDYfH7JpDVNxonQFxs5Ya JwG54EYfI7Md+n/QEMdGuSShgwTadE1oO0Mhoh/HVq7nkxlcmhcNSZtTVI+UldgU9Y+f /gtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lk9VWBIC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q185-20020a632ac2000000b00386231ec326si3942600pgq.613.2022.04.12.16.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:09:55 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lk9VWBIC; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 57F171FD57A; Tue, 12 Apr 2022 14:51:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350150AbiDKVYI (ORCPT + 99 others); Mon, 11 Apr 2022 17:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245205AbiDKVYD (ORCPT ); Mon, 11 Apr 2022 17:24:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E9812FE5C for ; Mon, 11 Apr 2022 14:21:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 08C1BB815C8 for ; Mon, 11 Apr 2022 21:21:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EB4EC385A3; Mon, 11 Apr 2022 21:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649712105; bh=KMidD+w99wAIiwGhewAltcaEDYwfTgwuH9rySlM7owU=; h=From:To:Cc:Subject:Date:From; b=lk9VWBICFXjGKTnI22r2ysF69//hMym+TGv5xnjmfAAu0maDn0rXzdvqNYHyGD9Ev RiQerYKR1ioyJJQTrAY1ZTljIQNFs1HVWIt3TSrCoF+w+MKXoep1FwVmVhecdcINvc 10EzMt5SIL63+xwx2HwNTQnREAZSAn3phmSwvqo6cvy67kjQk9S3YKNQzWeaFWau29 hrvuOxMiQ2hfb6IYm4wfIdvz9iDDCLKkVbQFQLTRsDIcgfKT8HjqL7Z8m2+8A/Jw1V Z0Az20XQUp24kxfdlJ3QylhQTbzxq7LCUj4XRjqTSNmQ1p77v9OmpcBhYFDMwBsWCw N5TO3c0Q9UPWg== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH 1/2] f2fs: fix wrong condition check when failing metapage read Date: Mon, 11 Apr 2022 14:21:40 -0700 Message-Id: <20220411212141.1775589-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.35.1.1178.g4f1659d476-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes wrong initialization. Fixes: 50c63009f6ab ("f2fs: avoid an infinite loop in f2fs_sync_dirty_inodes") Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index aba1b8a1ce66..ed61ac99a3cf 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -98,9 +98,9 @@ static struct page *__get_meta_page(struct f2fs_sb_info *sbi, pgoff_t index, } if (unlikely(!PageUptodate(page))) { - if (page->index == sbi->metapage_eio_ofs && - sbi->metapage_eio_cnt++ == MAX_RETRY_META_PAGE_EIO) { - set_ckpt_flags(sbi, CP_ERROR_FLAG); + if (page->index == sbi->metapage_eio_ofs) { + if (sbi->metapage_eio_cnt++ == MAX_RETRY_META_PAGE_EIO) + set_ckpt_flags(sbi, CP_ERROR_FLAG); } else { sbi->metapage_eio_ofs = page->index; sbi->metapage_eio_cnt = 0; -- 2.35.1.1178.g4f1659d476-goog