Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 12 Apr 2022 14:05:16 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     xkernel.wang@foxmail.com
Cc:     mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: scu: fix a potential memory leak in
 __imx_clk_gpr_scu()
Message-ID: <YlVc7J2UMhTc5Rkn@abelvesa>
References: <tencent_27FF59903EE6AB5C0D0E6D0A8E7059A59007@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_27FF59903EE6AB5C0D0E6D0A8E7059A59007@qq.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sPzwV5Olp7OYke0TlHVGmTIZNpKSYNt/hXXSiXX17JL0KsDkRCxZvEb5Zo+b?=
 =?us-ascii?Q?HkejevgVG5L/A4YHR7hRm+p8NhnrNKPFiltGCHPdhrh+sS2jQ+fEoPw7+y+y?=
 =?us-ascii?Q?SUeQ4PerXYHZy9qZPAuJchQVk7Hxhkiu7yUQMsgcQoiUniAuqeL0ydOde0MB?=
 =?us-ascii?Q?53JnskaZMzez4/WTsuYlS8UJS+x6DURqfo2u1FEjJ2MLRompmKs1D04/9Dcg?=
 =?us-ascii?Q?qkTQO/AGuItTaSJKI7p0saA8X03ExdUxfKRkd89HclyxFLdP56zHKXsFPAMC?=
 =?us-ascii?Q?jekI/MfCXC4i3/0BLD0EYmm7i3H2+1qO0SzP18iAyU+Qpcx2ZZnpkrOjMRNx?=
 =?us-ascii?Q?0DFgD2D6nJ13/G3D1srrVp1ejwKXbtl2GXhc4PnZhGNoM5pELozTgf7yWi3/?=
 =?us-ascii?Q?nbywcANQuSX+++MTIlk0eTHtxuqS8LL+KIdoJ3CPPvGBc+frIE5Ayd/iyHln?=
 =?us-ascii?Q?/rg0WU64l15g1ieZn57xADd0cWV4sb/fxoyc700lhnNtuyJTktRzAH/dQ9DI?=
 =?us-ascii?Q?Q1WRHYkLP/UpEzaYf/OxeKMgqVqDV5xBeSiCf5ohrd3Sg9mIcRoXRo2RtaiN?=
 =?us-ascii?Q?O44WrYA3qG174O65N5a1fMpb5kKT/THLqTDRo+jydkGwt4uP3CCifnYI/lfp?=
 =?us-ascii?Q?tYy8ev6L+VlBkCWsRV7DNygFrzNJDzJsM6H2UUC4FfPHdnOEwV123IHW0ZZl?=
 =?us-ascii?Q?K57QsvRZsjbdsPqhdHPxRngsTdQcUn6kwdpKUCSJnQLjtxVQnw5giL1dGanz?=
 =?us-ascii?Q?ZaJ36sRLqt8U6dZVsicdihAYq3aEKbNHZKt1pS7TCqG4mWxcNBQKsSJ1e7ab?=
 =?us-ascii?Q?D3XSiKBmAbMeYiBFKKKwafEDzZseLNmYvB1QtDF5a+YgD1b921nL3O7LJyEJ?=
 =?us-ascii?Q?AXUB7JvspUZx/iZhV3+Z1PMERrp7yvRD9BaOhMj2sPnD/Zf7QFPJkFj9/i3U?=
 =?us-ascii?Q?W1LREl3KpgQJ+vJEEnpybuue5b93thP2AaMTlmbC24/KxAkuzYmMNCASMTPQ?=
 =?us-ascii?Q?20fVfKB3auBhAhtlZW1qw3OJnilRvLroh0X6xB2G6XC9j7WsrPnYVefbnwId?=
 =?us-ascii?Q?SNPWT+Wat3YYyuWvirka7h0mTnSGUBMPQUHkUYgq+W2BRWDdm+K6i4HbhLJq?=
 =?us-ascii?Q?b0/H1/MOwjbHNgj5EQ98U5TEGj1waXWs4ycFvXd8Swhwgum/tqHNuEV24rci?=
 =?us-ascii?Q?+6ZpJpUZDimySDr5PyMxffUS63WhO7PDYi65LFa5CYXTtckBDZOBaPlrFn6q?=
 =?us-ascii?Q?U6PVkQMVjCO1M/5mAcN/hphU8N+SzPyw4dY9xUQSLps0HqqljRIptcFC2dWr?=
 =?us-ascii?Q?vBBc+PWw9mhoC9c/O/48mg7m+a9+BTs6TfiL8BQZf+5n1Gf7M98drJ7ForiO?=
 =?us-ascii?Q?vHrx1Qzo7FqLewgMOCU9WFvxQdfWZwgf5FCreQ/NOm0sEVNXSLGVyhdQHBDI?=
 =?us-ascii?Q?U9VawsJ46/C0n8qgOr+SoZoyjlCPRJO7MAZcWJTmjC8bOJtHG8ddpXeWytwM?=
 =?us-ascii?Q?UL53fbvogm/GdA2ZxOAf7P8JuwWMjOplWKWyZLX+nkP9TY0A9jOWb/Caf7vF?=
 =?us-ascii?Q?RW6829KJTyfkOTYH9PRLywnx4Jn67nHGr1r94BHukuZ9yl2Uwn6wxuhi9U9j?=
 =?us-ascii?Q?Lg8DgUkfHGM25S8QZP8cyESXiy+33xyLu4WEuqYbSMq/ohs+yG48b7JOFVnN?=
 =?us-ascii?Q?d3VqX43vKMJDtbtT13YdiK3Mcxz/A80kSfx+lftl1slupv6j08rg0YXKsuSs?=
 =?us-ascii?Q?98X0EKYJ/A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c89ddda3-f567-4e4c-653d-08da1c7453d7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 11:05:17.6161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MHybVlB0ZvcNpLE9ucCaaUPPT4Q+9qeGnwms6kFw745J1vLLcOLLTVQzmMWbNxZrPXg0GceZ77G8kcFB60vRTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7386
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-04-07 15:37:22, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> In __imx_clk_gpr_scu(), if imx_scu_clk_is_valid(rsrc_id) fails, then
> `clk_node` which is allocated by kzalloc() is not properly released,
> which may lead to memory leak.
> So this patch added kfree(clk_node) on the above error path before
> return ERR_PTR(-EINVAL).
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Applied, thanks!

> ---
>  drivers/clk/imx/clk-scu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 083da31..ed3c01d 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -837,8 +837,10 @@ struct clk_hw *__imx_clk_gpr_scu(const char *name, const char * const *parent_na
>  	if (!clk_node)
>  		return ERR_PTR(-ENOMEM);
>
> -	if (!imx_scu_clk_is_valid(rsrc_id))
> +	if (!imx_scu_clk_is_valid(rsrc_id)) {
> +		kfree(clk_node);
>  		return ERR_PTR(-EINVAL);
> +	}
>
>  	clk = kzalloc(sizeof(*clk), GFP_KERNEL);
>  	if (!clk) {
> --