Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp41235pxb; Tue, 12 Apr 2022 16:13:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwfaRHOavNhUb/+WvcsttUr0AwoDCSnje2GPFYaqfMTnsHIAGlutZl0n6VrST3FNndT/7s X-Received: by 2002:a17:90a:2b41:b0:1cb:62ba:d53 with SMTP id y1-20020a17090a2b4100b001cb62ba0d53mr7463487pjc.201.1649805201140; Tue, 12 Apr 2022 16:13:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649805201; cv=none; d=google.com; s=arc-20160816; b=eFbHD6nOCU/pC2MwlH1TmfHJUjI8DQaMu0qsyaHfVXfw43A8iXNAJKq6fP2x2iqhy+ t10Oize1aqMfBvN7bWKyAukX658USyINqqhsPr/lWBYDlMVy/qK0iCaqUjAF7Uwrafw8 zEA2XrN1+CyeXGBeMLGBPdkqum/boKS76U6oLs9QzdrGuUG1bwU1+A8ImgQlKFiXQr6I u+FxOnTVSe1970bAcPzS6HFLP4RwFKsjD9b+Ny93J09c+Vfig2wzDL+EODFhJviB7Bgf FlaOIZ72u4RZZvjkMQDGDMxfuR9WRgWT6xIGVR58aX2iSDsrvD/F1xXBrn6QJsf7HMFJ qP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0IhJHq907qlNjwaXEgjr+ybtnuc11Xy1YLS2fIDircQ=; b=p1f/Fy/pjT3brEJDIzrSDo9DFlMEW3Lnju33LZbdr+Qnavpe9hL/4o2ziVQiAzhzSw zdFiia5RqidasM2FfJNgkR1bW11tipYmlkQAHNJ8CdzvEj6syIm3/ItsCuIjn8d3ufb8 jUNmU27qm7bt6/ZsVZnWwnKERMv9EWKNSXKgkaKaH5Mcopl65MpmieBzfX7vAc91HMuj BIRSJJx8JfzSfhhIdrma0592zjRVFnvmDj4psPOc+db00bWrPDs7a8mufkGwVeSnNDq2 fKiF/TXHW4h9wVn1yIMgXj1+TT/cfLOyDVTKMRCicVPEtJfl+K4i4/9jc3jbaPWRYuCs V2iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xqU7WWCp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id y1-20020a056a00190100b004fa3a8e002esi13359877pfi.229.2022.04.12.16.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:13:21 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xqU7WWCp; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 49571129E8E; Tue, 12 Apr 2022 14:56:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383133AbiDLIfw (ORCPT + 99 others); Tue, 12 Apr 2022 04:35:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356388AbiDLHfZ (ORCPT ); Tue, 12 Apr 2022 03:35:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B927D5131D; Tue, 12 Apr 2022 00:09:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04DBEB81B5D; Tue, 12 Apr 2022 07:09:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 576B8C385A5; Tue, 12 Apr 2022 07:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747363; bh=VVkldtKKzVFjq87XcXUHMuOaGul0Zrdrv27o1u0BB7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xqU7WWCp1b4g3PADaizDXE24t7gHrut7xQY7GkEfNOWiMwstr81+HhpZfCiYCkMUm sRtZNc9JZ9silF0iepHOpB+/J88dngCzlNGmil7xBtrWVBNrj3/Pr28Ps/PATLIMIb /de5V5EFqj+zHEyLFBS5crWFKBj8E3Ug4NqkIw0w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Avraham Stern , Luca Coelho , Johannes Berg , Sasha Levin Subject: [PATCH 5.17 051/343] cfg80211: dont add non transmitted BSS to 6GHz scanned channels Date: Tue, 12 Apr 2022 08:27:49 +0200 Message-Id: <20220412062952.579111880@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062951.095765152@linuxfoundation.org> References: <20220412062951.095765152@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Avraham Stern [ Upstream commit 5666ee154f4696c011dfa8544aaf5591b6b87515 ] When adding 6GHz channels to scan request based on reported co-located APs, don't add channels that have only APs with "non-transmitted" BSSes if they only match the wildcard SSID since they will be found by probing the "transmitted" BSS. Signed-off-by: Avraham Stern Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20220202104617.f6ddf099f934.I231e55885d3644f292d00dfe0f42653269f2559e@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/scan.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index b888522f133b..b2fdac96bab0 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -700,8 +700,12 @@ static bool cfg80211_find_ssid_match(struct cfg80211_colocated_ap *ap, for (i = 0; i < request->n_ssids; i++) { /* wildcard ssid in the scan request */ - if (!request->ssids[i].ssid_len) + if (!request->ssids[i].ssid_len) { + if (ap->multi_bss && !ap->transmitted_bssid) + continue; + return true; + } if (ap->ssid_len && ap->ssid_len == request->ssids[i].ssid_len) { @@ -827,6 +831,9 @@ static int cfg80211_scan_6ghz(struct cfg80211_registered_device *rdev) !cfg80211_find_ssid_match(ap, request)) continue; + if (!request->n_ssids && ap->multi_bss && !ap->transmitted_bssid) + continue; + cfg80211_scan_req_add_chan(request, chan, true); memcpy(scan_6ghz_params->bssid, ap->bssid, ETH_ALEN); scan_6ghz_params->short_ssid = ap->short_ssid; -- 2.35.1