Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <48be3b1e-1707-8867-07ed-7ec7ed18314e@nvidia.com>
Date:   Wed, 13 Apr 2022 02:21:59 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops
Content-Language: en-US
To:     Christoph Hellwig <hch@lst.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>
Cc:     Jason Gunthorpe <jgg@nvidia.com>, intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20220411141403.86980-1-hch@lst.de>
 <20220411141403.86980-33-hch@lst.de>
From:   Kirti Wankhede <kwankhede@nvidia.com>
In-Reply-To: <20220411141403.86980-33-hch@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDBaQnNPaXNqYXBiM0pBL1BMMVFDc3JJT2tCdHRTUEZtbzdrdWpjZlYzbzZ1?=
 =?utf-8?B?NXdnS283b0pnL1NOclBlc2x5cnppd05paVV1cVRHSXdZcUJNdzF6Y3hJa250?=
 =?utf-8?B?ZVQxZWNHRHA0YkhqSkRtK0N4eW81UTlFYmNpU1RFTVM4aE5QdnFGSXlVaEg1?=
 =?utf-8?B?SkFXTmh3UTBBNkNQMG1ycmNmM3RHTk44M2tFaHR5QWxBMFYvMWNTbDVweGt5?=
 =?utf-8?B?c1dKdEJNd2RwcnU5WU5FcExTQzZQSk9ZcjdLa21WMkQwNVl0dXd5bHI5M2da?=
 =?utf-8?B?KzdMcFJWSFdneHRsZmgvOUo2MmdPZXBmLzZSZWo4a2xRWTA1a1YxaXRQWjgr?=
 =?utf-8?B?R0dsWUs5UXByaU0xV0thQTFVNTVweGR5RFFCZkt2c0VFdGl5OEI3RnNoVS9x?=
 =?utf-8?B?RlIvLzNlamRKNC9obVVHNkZvZjRyRlAvSzRXak9nM2c1emkwU2oxRjdoMmx3?=
 =?utf-8?B?cDFtdHZhOVU5ZlZ4MlNuSkphQVdFNXExS29LOG5YcXpRY0NIK3hLYVFiRTRx?=
 =?utf-8?B?SHQ0YS8xVzFXcVN5dVJUZkJsUEJwRHZtbVZTRnFjTGJxQ3BCTVNCOWJoSmJl?=
 =?utf-8?B?YTF4d0N1bTBFWXJDbWdxNmFkYUthVnV0cC9pbEoyWVBUMFBhTk8zNnU5NUpv?=
 =?utf-8?B?cVhQcHRia2MzYTY2Y1hoa0NZTXRFenlUSzkrZ2lDK2YrQitmUFZuT0hhdjA3?=
 =?utf-8?B?S0NYZzVJaU5rT3dxeEZoYmU4dTRHeHhoNVY3UG5RYjkzb3dOcFc4SFlhcDFa?=
 =?utf-8?B?M25INGZoamRza3FMMXRCNS9QQ1FRWVczZUtEZWFHTlp4NjRycVhYNm1RZjN6?=
 =?utf-8?B?M29WZHh3bktNTTJXaW5PNDczOUh3aG14S2hOaWpqVjhFSGl1aGxWTWhHd3FI?=
 =?utf-8?B?TDd1L3NCRk14K1ZpYUtCRUNOOE9PeUVPdXBnM3pVRVpQMitsQjJJWUZQYUlP?=
 =?utf-8?B?Zlpvc1hhVGxYT2tYRFJ4N25xVFBjdDRwalp3amRiMnpMak9VN0dUVDMxTHRz?=
 =?utf-8?B?Ulh6WmpnK3doMmFjMFVobllsMnBNN0V0TUdJMDVtUGc2aWlScTlUNmFHaGNX?=
 =?utf-8?B?dDJXaW5ucEdmQVBOWFhYM1FtN3NtakVnTXhXQXVhK3pDeHNnek5vdi9qRmk4?=
 =?utf-8?B?TTJRZS9GVmFVTE9iRzV6TzVrWUxuL3ZBcjkvUzliUUdrSjl6ZlJySXNtQ3NV?=
 =?utf-8?B?ZE5mb0h6MjhJalAvUENUUXNYdXRQSWpwU2JYeldDSEQ3dUowRUhnZHFTY2dQ?=
 =?utf-8?B?STZvaGhLRC9EbmROUWtER0FzZ3RqZWFHL0lZUDZEVkJ2M2Vja0N3d3RydExY?=
 =?utf-8?B?cWV2YTMxSmxEL2hmSEJJZGlXVklNSHlIQUJ4eG9qQU0vdjVUMElnN3hrKzVp?=
 =?utf-8?B?bXlWSDJaUXRDMlM2TzhwWXczNitDNmFKeHczdHFmNVhzdFlNc3NYL0MwcXlp?=
 =?utf-8?B?NTFsVkUxUkJqdW1wdWJPZDREOHM3T2hnbjlNUXNtQWZpSDQwTEY3YmhsTkl4?=
 =?utf-8?B?eVhpbFNsRVJWY0tGWG4rTUZwK2VpZ3lBdHBQU2N2c3kwYUxTZ3hVU2V0Z3oy?=
 =?utf-8?B?djNUUXA3WTliVWtVQi9HUmp4SmJYMjJXNTVFalRtc0RhWS9VdktGeWdwbHJ2?=
 =?utf-8?B?QlJqVUhXSFlDUm93MjlmNUF0MHBCZWhMTE9rL29wYXRxZTF2enlHdHIrM1BD?=
 =?utf-8?B?cjVJZHJTbGRTNXdGR1RaSVQyVEhJQkNUWGdjSytkRjBrVXNXdHJ3OGl3S2F5?=
 =?utf-8?B?UXdBZ2VMY3BKazZPMzZPRmxQSkMzOXc0aWpMekgxdkdROHdHUEMvME52WHY5?=
 =?utf-8?B?YnR6TkNOMmNCSElBVDFZaEhEcWU5NmpZejNiQzJEL1lqMjVwU0Flb21RRUtO?=
 =?utf-8?B?Y2xraUxHdExHVERqdXUzbk4vVkZuMnZPVnR3SHVrd0NibW04ZnFTRzNDMlZX?=
 =?utf-8?B?bmp4dnhFczlrSEluVEhOeUxqY3F0SzB3VEp1TnBwdHFPYThRYS9rbW5KZFZw?=
 =?utf-8?B?SUpYK25zNXN5ZzkySjVDOWN1RVN1VE9FOWlManBpc0pKTVc5RkRPSWM4ci85?=
 =?utf-8?B?bUdwdTZWZjROc3dJbHhQYzQ4dXJaNDdqb2hPWkFwWEIrdTV5b1ZPNWowaFFz?=
 =?utf-8?B?M2Ziak1BQzJMMmR6LzVoSUpyTkJsd3cwZlBnY2puc3hUTVlWcHd4SklVRkdR?=
 =?utf-8?B?UUo1dkZuNHdDRWYzcGI1QUt3eUlBUzhNSHFqTCtOKzMxbFdHdUt1RW1FZWJR?=
 =?utf-8?B?V0N2MUJDT20vSllIMnZJYytaTERINXRYbjFMdE44Y25MNnFBZ0NrcGkxV3pv?=
 =?utf-8?B?azd0R2l3MmdFTitRUjhSRjM0U1hoYXY0SXd4NW03bGovSUI2MU5CQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 877639ab-d3f0-4fae-3fdf-08da1cc651dc
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4206.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 20:52:13.2742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RYsAKMDNvXNdCSbVcTsZ8fw5QWT7UKlmz3grYfezyDevNyzB0a+pRn41/lwmS7KX0YruRitHj1w5NIM9zc7lYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1679
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/11/2022 7:44 PM, Christoph Hellwig wrote:
> From: Jason Gunthorpe <jgg@nvidia.com>
> 
> The last useful member in this struct is the supported_type_groups, move
> it to the mdev_driver and delete mdev_parent_ops.
> 
> Replace it with mdev_driver as an argument to mdev_register_device()
> 
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   .../driver-api/vfio-mediated-device.rst       | 24 ++++--------------
>   drivers/gpu/drm/i915/gvt/kvmgt.c              |  7 +-----
>   drivers/s390/cio/vfio_ccw_ops.c               |  7 +-----
>   drivers/s390/crypto/vfio_ap_ops.c             |  9 ++-----
>   drivers/vfio/mdev/mdev_core.c                 | 13 ++++------
>   drivers/vfio/mdev/mdev_private.h              |  2 +-
>   drivers/vfio/mdev/mdev_sysfs.c                |  6 ++---
>   include/linux/mdev.h                          | 25 +++----------------
>   samples/vfio-mdev/mbochs.c                    |  9 ++-----
>   samples/vfio-mdev/mdpy.c                      |  9 ++-----
>   samples/vfio-mdev/mtty.c                      |  9 ++-----
>   11 files changed, 28 insertions(+), 92 deletions(-)
> 

Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>