Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp39520lfv; Tue, 12 Apr 2022 16:22:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdQ0wRv5+J7pBRtMGzI6fZ+Aq3/EeE/luVH7O8oJVRyMjPCh/QkEOaC1oLy3aBdvciV58O X-Received: by 2002:a17:902:b185:b0:14f:2d94:184 with SMTP id s5-20020a170902b18500b0014f2d940184mr39768478plr.56.1649805766603; Tue, 12 Apr 2022 16:22:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649805766; cv=none; d=google.com; s=arc-20160816; b=cyl67LRZnlxDo5DjAoVO1N/CnT1AlbZZFH5nl72GddYKfA+5G4c1914v7ukN6Y/Fm+ s9H9SBBboEuyMuZR0vHs3Ysrsond6J95GmY7jKWMRW/1jKJesxIBmcJWOa2NbhTVHNy+ 4HuWcoe+XHE3WqbjjnmZOB0Kc8PO1yGRmLSvaX2XwXjwSpww43yug375bi047kf/cKD7 sTD7ujDvT/eCvzCvo0rJAZm9dclYOsQw/AV0dns2EtxM45EvQg6sTTmLclfRxTvIv+d3 hHQEnp/VXwFsxRFErC2iy4P7RHRIRFkN20q2LoY/o1VjoC9HYBA9zdATDV0g2OBsmpcJ K89Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QvrC8gbKx5KZZOlFpxaw9F/KhWRvnopbHQdb6v3wIMc=; b=ZJhJtOItb0Tjbhwd7GSL/Qh+nUh8MrBVoFADio3T2RJWh75IBWe2Ior4OqJIrGV2Pk yPI+UNIUirhnAG4IQ5iOyVl3pyB0DkkByS82YOjHCD5xooWcG+2TvX9oHEAuMTQ1pLBA utGVu03FAdrZWtZhEyZkUihH+vhjrTCOhu1tkoQqqBRe1Es10s32yfkuLvQkqJzULFJF 4BCMIc5hhixqbO9fSpxW4vJQmt89usr21huMuBHEcuPzMN+JgN8JG7dWXE+amPEkjCa+ 53MpphxPHhw4hFBwVn/PUj/2D4UxZCsdmtuLiVND8boeb8JnikKbNFFL9Ai50c7bYzLd q2+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c+oiCuwV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id rj8-20020a17090b3e8800b001bf7b9c1dfasi13304475pjb.66.2022.04.12.16.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:22:46 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c+oiCuwV; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DABDE19CCFD; Tue, 12 Apr 2022 14:14:44 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385644AbiDLIwW (ORCPT + 99 others); Tue, 12 Apr 2022 04:52:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358979AbiDLHmY (ORCPT ); Tue, 12 Apr 2022 03:42:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AEBF54BD4; Tue, 12 Apr 2022 00:19:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A058A6153F; Tue, 12 Apr 2022 07:19:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACE01C385A1; Tue, 12 Apr 2022 07:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747987; bh=wYgE6jyFK7WGv03kxPI2/kG/+lpmU4aK7Xwji4y+v0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c+oiCuwVC6aTR7K7E4LagEWbOS7+PLQoaJkE+b8h1bdP3kYw4bD9zVQTrOzV0o2mW irC6cuLEmbWuCFI5NNJZHMLDfIgdgSBzxdcOwIzupyGCJsinVPqMJugG7tc4vEYJk1 2vleNNwyObOfk0EAuEvQruZNwjupnhaf8NTVkPPU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe Subject: [PATCH 5.17 276/343] io_uring: dont check req->file in io_fsync_prep() Date: Tue, 12 Apr 2022 08:31:34 +0200 Message-Id: <20220412062959.289235162@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062951.095765152@linuxfoundation.org> References: <20220412062951.095765152@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe commit ec858afda857e361182ceafc3d2ba2b164b8e889 upstream. This is a leftover from the really old days where we weren't able to track and error early if we need a file and it wasn't assigned. Kill the check. Cc: stable@vger.kernel.org # v5.15+ Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 3 --- 1 file changed, 3 deletions(-) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -4245,9 +4245,6 @@ static int io_fsync_prep(struct io_kiocb { struct io_ring_ctx *ctx = req->ctx; - if (!req->file) - return -EBADF; - if (unlikely(ctx->flags & IORING_SETUP_IOPOLL)) return -EINVAL; if (unlikely(sqe->addr || sqe->ioprio || sqe->buf_index ||