Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220404151036.265901-1-k.kahurani@gmail.com> <6b6a8f5c-ceb9-ce97-bf79-d7634b433135@gmail.com>
In-Reply-To: <6b6a8f5c-ceb9-ce97-bf79-d7634b433135@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 11 Apr 2022 18:11:14 +0300
Message-ID: <CAHp75VdkPJuHLFfQzPS==G_K1fqai53eT-=Gh-kL9mTED1x2fw@mail.gmail.com>
Subject: Re: [PATCH] net: ax88179: add proper error handling of usb read errors
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     David Kahurani <k.kahurani@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com,
        "David S. Miller" <davem@davemloft.net>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>,
        Phillip Potter <phil@philpotter.co.uk>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 5, 2022 at 3:05 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
> On 4/4/22 18:10, David Kahurani wrote:
> > Reads that are lesser than the requested size lead to uninit-value bugs. Qualify
> > such reads as errors and handle them correctly.

> I'd personally cut this log a bit and would add this part of the initial
> report
>
> Local variable eeprom.i created at:
>   ax88179_check_eeprom drivers/net/usb/ax88179_178a.c:1045 [inline]
>   ax88179_led_setting+0x2e2/0x30b0 drivers/net/usb/ax88179_178a.c:1168
>   ax88179_bind+0xe75/0x1990 drivers/net/usb/ax88179_178a.c:1411
>
> Since it shows exactly where problem comes from.
>
> I do not insist, just IMO

I insist though. It will reduce the resource consumption (i.e. storage
and network load on cloning / pulling) a lot (taking into account
multiplier of how many Linux kernel source copies are around the
globe) and hence become more environmentally friendly.

-- 
With Best Regards,
Andy Shevchenko