Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp40039lfv; Tue, 12 Apr 2022 16:24:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzW9j0ViPLs7ttnnG4XZGlPc7uDlteIA/TiQ1qxBlkx/fU7kKFMOglme6rXb9XbX7ks1thX X-Received: by 2002:a17:90b:4b0e:b0:1c6:f499:1cc9 with SMTP id lx14-20020a17090b4b0e00b001c6f4991cc9mr7563845pjb.133.1649805845973; Tue, 12 Apr 2022 16:24:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649805845; cv=none; d=google.com; s=arc-20160816; b=K4mC3IGUH47LTsfk/R5FbYhroORk/1sHf7tV2Tmb++Cvf6JsnqjbfOxc8nMsCeYdcU zE7doNQ8/rYo+YZpDju+9MpvK+P+kDfIUYM3FEdDf5G/Yl35q5SXampvApu2cCkI7y7X RwHc+uzvR6RRbgS5NnDVN3NzNGlBRfXmKvLR4QyTj4MX5OlI0+WyGllrwQB+GS2koapc Xrku4EsP7RRzVoT1pdJHLr6+lbWoqm8ScZKWtzeUN+1e+/Cf6FWAQYivpi9fv2AuBBHr 018bsO7hv4zbhsVZrOBBz9Ok0moW78w6Tjx0N6zISa3MC6OuZD+f8JXmFnNiR2Yvf9z3 0ilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ctcFTn0w6V6dn60hCVOeQY6EpY2IAZwsL/yX59ESRQ8=; b=RgDfumxD2F0bDCXJGCQ64mWAmZw8pioS+2giIu8IHbpbpg9jtomq33OtHwmR/7BPN/ IE7Giptf6ExlSap7OoZk6ciqB38j6a8n8wbqZ/DzTWJRMcMsiA5yI3COcl5SAcmC+HRd FGdDx+IQHsaTtVYMVrHlwqaiYWczuwSCMYIghW2OT/WNlMF1KREs6ve+ir26Oik/Le5m U5YWMJSZTEDxKTzAr8kLneAOLQX/xb93d+lxo35o+RGdYk7Pg10+BccQOZK6EXqzSto4 uSWXha6Wd0y+G1JQi1YounlrsynLIWv5Fq/5lpGj5V2LLelsVuvh4rYa32YHiTIZdjZu vBTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=dOK9E5lZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d6-20020a170902c18600b00153b2d16578si12100283pld.384.2022.04.12.16.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:24:05 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=dOK9E5lZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 278F2EE4CD; Tue, 12 Apr 2022 14:16:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236572AbiDLLLu (ORCPT + 99 others); Tue, 12 Apr 2022 07:11:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241733AbiDLLKK (ORCPT ); Tue, 12 Apr 2022 07:10:10 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB50485945 for ; Tue, 12 Apr 2022 03:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ctcFTn0w6V6dn60hCVOeQY6EpY2IAZwsL/yX59ESRQ8=; b=dOK9E5lZyl1dz7vt9gPzx3CK1M 1F801At0ybIZuqpDkKGuxj4PwTUF7x2EqJ+/uU/bZQqSY1DEPp5dh/qZ3BiQ4Iz4If9nDsc7mi6d7 I7xJ9/uJRDQ2EB76fDW7JoydZ+k/u7XWYogrJkZnJZXHFMwi09ZDRri2GM4vz0lTRH54V0aT1EBOb HABTFQrrP0gjWF3Zes79lkFGydbodovm74L0laTZ9rY5Gvyi2IfWOhF7fb+rdknRmgXxQBP/8Roix 44DIsw8JA48FVAQWbec3NQAQnW1q7D+84sjkE6s1DtY8XqJDUXbrXRbtq5ubl0jAHzkGLMjtO0Vzn pWjPWv3g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDLC-004HeE-5W; Tue, 12 Apr 2022 10:01:42 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BC9D4300250; Tue, 12 Apr 2022 12:01:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 944022DB89DC9; Tue, 12 Apr 2022 12:01:39 +0200 (CEST) Date: Tue, 12 Apr 2022 12:01:39 +0200 From: Peter Zijlstra To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com Subject: Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs Message-ID: References: <1649749204-186363-1-git-send-email-dmtrmonakhov@yandex-team.ru> <1649749204-186363-2-git-send-email-dmtrmonakhov@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649749204-186363-2-git-send-email-dmtrmonakhov@yandex-team.ru> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote: > For historical reasons we check only IRET_FRAME_OFFSET, but this check > is no longer valid because we also access regs->sp field which is > located beyond IRET_FRAME, so it is reasonable to validate full structure. Uuuh, what? IRET frame is: ss, sp, flags, cs, ip that very much includes sp.